As I'm going through and assigning priorities to various effects, I've noticed that sometimes ships have taken mine damage, other times it's been repaired. Some of the damage control effects process before mines, others afterwards—that's not ideal and it probably needs to be added to the list of things to prioritise. So, options:
Mine damage is applied before damage control effects, increasing the odds that mines will blow stuff up
Mine damage in applied after damage control techs, meaning that when you get a sitrep saying "X has taken mine damage" that damage will be visible to you, but ships are less likely to die from mines
If you're in an enemy system, most if not all damage control effects shouldn't be usable, ships need to withdraw to repair
My preference is for option 3 (it's already the gating for some of the techs), however even if we do do that for most effects, there are some things (nanobots, bioadaptation and logistics coordinator) that are designed to be working during combat which basically means they should get to do at least some repairs in situ. So if we go for 3 for most of them, we still need to decide between 1 and 2 for the rare 'in combat' repair setups (which should be priced/balanced accordingly).
Opinions?
Mat Bowles
Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.
3 followed by 2 for the others.
In general, damage control seems like a summarized incremental change (1 hp/sec, a turn is 30 secs = +30 hp). After the longest time lapse (actions during last turn, other player turns), they should be the first processed.
I'm all for giving mines more impact in some fashion, they are seldom researched here.
K, just commenting to say I put the change in with a few other tweaks, mines now happen very early in priority, before even VERY_EARLY_PRIORITY to ensure there are no future clashes, I also gated virtually all ship and damage control to not happen during combat, which I'll discuss elsewhere in more detail.
Mat Bowles
Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.