Head on a Spike

[yandonman]

Per the A Collection of Heads discussion, here is the submission for the "head on a spike" aspect of it. Works as intended in all cases I could think of to test.

Barring additional feedback, ready for submission.

[yandonman]

I'm curious if this patch was rejected?

[Dilvish]

I'm curious if this patch was rejected?

Ah, no, I don't recall anyone objecting to it. I think it's just that I kind of took the lead on working with you on it but then around the time you were wrapping it up I got all caught up in a bunch of work on Conditions & some other efficiency related stuff; I probably dropped the ball on a few other things in addition to this.

I just reviewed the patch again and posted a comment in the discussion thread.

[shawndream]

I wasn't fond of it (in a galaxy with Concentration camps and world devastation, is a head on a spike way over there really important?).

But improvements to it made it seem more reasonable. I'm down with a small bonus for holding an imperial capital, and especially if it changes depending on whether you captured it through battle or diplomacy.

(With the popup standing in for that for now).

[Dilvish]

I made the "OwnedBy AnyEmpire" change mentioned in the linked discussion, and the patch tested out fine for me. I decided the recapture issue I mentioned in the discussion thread wasn't really such a big deal & I went ahead and committed this.