Ship Names 'Da' and 'Vinci'

Creation, discussion, and balancing of game content such as techs, buildings, ship parts.

Moderators: Oberlus, Committer

Post Reply
Message
Author
User avatar
Bigjoe5
Designer and Programmer
Posts: 2058
Joined: Tue Aug 14, 2007 6:33 pm
Location: Orion

Ship Names 'Da' and 'Vinci'

#1 Post by Bigjoe5 »

Are those supposed to be on separate lines in the stringtable?
The Stringtable wrote:

Code: Select all

Da
Vinci
Warning: Antarans in dimensional portal are closer than they appear.

User avatar
Bigjoe5
Designer and Programmer
Posts: 2058
Joined: Tue Aug 14, 2007 6:33 pm
Location: Orion

Re: Ship Names 'Da' and 'Vinci'

#2 Post by Bigjoe5 »

Also, within '''ed strings in the stringtable, is there any way to insert a comment? It would be nice to mark in the ship names where the author names start, where the animal names start, etc.
Warning: Antarans in dimensional portal are closer than they appear.

User avatar
Geoff the Medio
Programming, Design, Admin
Posts: 13587
Joined: Wed Oct 08, 2003 1:33 am
Location: Munich

Re: Ship Names 'Da' and 'Vinci'

#3 Post by Geoff the Medio »

Probably should be one line.

Standard comments will probably be treated as part of strings. A workaround with evauates-to-nothin macros might work, or the list could just be several macro insertions which have names descriptive of their contents.

User avatar
MatGB
Creative Contributor
Posts: 3310
Joined: Fri Jun 28, 2013 11:45 pm

Re: Ship Names 'Da' and 'Vinci'

#4 Post by MatGB »

I've actually fixed that obviously extra linebreak in the en.txt amendment file along with other things, little bit more work on it and I'll submit the patch, probably tomorrow unless something comes up, maybe later this evening if I can figure out what I've got wrong with my SVN install. There were a couple others like that IIRC, and some really weird spelling issues (including at least one German word that was similar but not the same as en-US).
Mat Bowles

Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.

User avatar
Bigjoe5
Designer and Programmer
Posts: 2058
Joined: Tue Aug 14, 2007 6:33 pm
Location: Orion

Re: Ship Names 'Da' and 'Vinci'

#5 Post by Bigjoe5 »

On a related note, it seems that the UserStringList function separates by any whitespace. For example, it seems that "Eternal September" evaluates to two different names: "Eternal" and "September". I'll take a look at that today - it shouldn't be too hard to figure out.
Warning: Antarans in dimensional portal are closer than they appear.

User avatar
Bigjoe5
Designer and Programmer
Posts: 2058
Joined: Tue Aug 14, 2007 6:33 pm
Location: Orion

Re: Ship Names 'Da' and 'Vinci'

#6 Post by Bigjoe5 »

This is fixed, along with a re-organization of the ship names. Sorry if this messes with your current work, MatGB.
Warning: Antarans in dimensional portal are closer than they appear.

User avatar
Dilvish
AI Lead and Programmer Emeritus
Posts: 4768
Joined: Sat Sep 22, 2012 6:25 pm

Re: Ship Names 'Da' and 'Vinci'

#7 Post by Dilvish »

Code: Select all

CMakeFiles/freeoriond.dir/__/universe/UniverseGenerator.cpp.o: In function `GenerateSpaceMonsters(Universe&, GalaxySetupOption)':
UniverseGenerator.cpp:(.text+0x5563): undefined reference to `NewMonsterName()'
I get that if I try to compile rev 6747 or later
If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0

User avatar
Geoff the Medio
Programming, Design, Admin
Posts: 13587
Joined: Wed Oct 08, 2003 1:33 am
Location: Munich

Re: Ship Names 'Da' and 'Vinci'

#8 Post by Geoff the Medio »

Dilvish wrote:undefined reference to `NewMonsterName()'
Probably needs an FO_COMMON_API out front of the declaration.

User avatar
Vezzra
Release Manager, Design
Posts: 6095
Joined: Wed Nov 16, 2011 12:56 pm
Location: Sol III

Re: Ship Names 'Da' and 'Vinci'

#9 Post by Vezzra »

Dilvish wrote:

Code: Select all

CMakeFiles/freeoriond.dir/__/universe/UniverseGenerator.cpp.o: In function `GenerateSpaceMonsters(Universe&, GalaxySetupOption)':
UniverseGenerator.cpp:(.text+0x5563): undefined reference to `NewMonsterName()'
I get that if I try to compile rev 6747 or later
Strange... I've been able to build 6748 just fine today on OSX. Usually what creates this kind of problems on Linux also doesn't work on OSX.

User avatar
adrian_broher
Programmer
Posts: 1156
Joined: Fri Mar 01, 2013 9:52 am
Location: Germany

Re: Ship Names 'Da' and 'Vinci'

#10 Post by adrian_broher »

Dilvish wrote:

Code: Select all

CMakeFiles/freeoriond.dir/__/universe/UniverseGenerator.cpp.o: In function `GenerateSpaceMonsters(Universe&, GalaxySetupOption)':
UniverseGenerator.cpp:(.text+0x5563): undefined reference to `NewMonsterName()'
I get that if I try to compile rev 6747 or later
Fixed in r6759. The issue was, as Geoff said, a missing export macro.
Vezzra wrote:
I get that if I try to compile rev 6747 or later
Strange... I've been able to build 6748 just fine today on OSX. Usually what creates this kind of problems on Linux also doesn't work on OSX.
The Xcode setup resolves the symbols dynamically. This setup hides that kind of issues but is needed for now because of the dylib cross dependencies between common and parse.
Resident code gremlin
Attached patches are released under GPL 2.0 or later.
Git author: Marcel Metz

User avatar
Dilvish
AI Lead and Programmer Emeritus
Posts: 4768
Joined: Sat Sep 22, 2012 6:25 pm

Re: Ship Names 'Da' and 'Vinci'

#11 Post by Dilvish »

adrian_broher wrote:Fixed in r6759. The issue was, as Geoff said, a missing export macro.
Thanks much; I'll try to keep that in mind next time I see a similar issue.
If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0

Post Reply