FreeOrion

Forums for the FreeOrion project
It is currently Mon Nov 20, 2017 2:06 am

All times are UTC




Post new topic Reply to topic  [ 22 posts ]  Go to page Previous  1, 2
Author Message
PostPosted: Mon May 25, 2015 2:29 pm 
Offline
Dyson Forest

Joined: Sun May 11, 2008 10:50 am
Posts: 231
Actually, This got changed 8 days ago or so by adrian_brother - he added the find_package(PythonInterp REQUIRED) without a version (other similar calls for server and client have the version 2). Maybe that's what broke things for my environment.

_________________
Attached patches are released under GPL 2.0 or later.


Top
 Profile  
 
PostPosted: Mon May 25, 2015 3:30 pm 
Offline
Release Manager, Design
User avatar

Joined: Wed Nov 16, 2011 12:56 pm
Posts: 4241
Location: Sol III
Chriss wrote:
Actually, This got changed 8 days ago or so by adrian_brother - he added the find_package(PythonInterp REQUIRED) without a version (other similar calls for server and client have the version 2). Maybe that's what broke things for my environment.
It says "authored on 23 Apr", so that would be a month, not just 8 days ago, but other than that, your guess sounds absolutely reasonable.


Top
 Profile  
 
PostPosted: Mon May 25, 2015 4:04 pm 
Offline
Dyson Forest

Joined: Sun May 11, 2008 10:50 am
Posts: 231
:shock:
oopsie :oops:

Kay, if you could commit that change and the boost 1.58 fix then I can go ahead and migrate the Arch package to Git sometime later this week.

_________________
Attached patches are released under GPL 2.0 or later.


Top
 Profile  
 
PostPosted: Mon May 25, 2015 4:23 pm 
Offline
Release Manager, Design
User avatar

Joined: Wed Nov 16, 2011 12:56 pm
Posts: 4241
Location: Sol III
Chriss wrote:
Kay, if you could commit that change and the boost 1.58 fix then I can go ahead and migrate the Arch package to Git sometime later this week.
I want Dilvish to take a look at your fixes before, as that's Linux stuff and I'm not on Linux here - can't test your patches. Dilvish?


Top
 Profile  
 
PostPosted: Tue May 26, 2015 8:34 am 
Offline
Programmer
User avatar

Joined: Fri Mar 01, 2013 9:52 am
Posts: 1040
Location: Germany
Chriss

  • What's the output of `python -V`?
  • The boost python library needs to be compiled against a specific version of python. FO requires 2.7. I don't know what Arch provides. Fedora provides both library variants as separate and parallel installable packages, The Debian package allows to link against either python2 or python3.

_________________
Resident code gremlin
Attached patches are released under GPL 2.0 or later.
Git author: Marcel Metz


Top
 Profile  
 
PostPosted: Tue May 26, 2015 5:17 pm 
Offline
AI Lead, Programmer
User avatar

Joined: Sat Sep 22, 2012 6:25 pm
Posts: 4374
Apparently in some systems with both python2 and python3 installed, find_package(PythonInterp) will give 2.7, but find_package(PythonLibs) will find 3.x
See, for example, https://public.kitware.com/Bug/view.php?id=13794

As noted in the above link, this is apparently fixed cmake 3.1, but it may still need attention from us: as described in
https://bugs.debian.org/cgi-bin/bugrepo ... bug=677598 it sounds like the search for PythonLibs can still be a little finicky.

it sounds like probably we should be using
Code:
find_package(PythonInterp 2.7 EXACT)
find_package(PythonLibs ${PYTHON_VERSION_STRING} EXACT)

_________________
If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0


Top
 Profile  
 
PostPosted: Tue May 26, 2015 9:58 pm 
Offline
Dyson Forest

Joined: Sun May 11, 2008 10:50 am
Posts: 231
adrian_broher wrote:
Chriss
  • What's the output of `python -V`?
  • The boost python library needs to be compiled against a specific version of python. FO requires 2.7. I don't know what Arch provides. Fedora provides both library variants as separate and parallel installable packages, The Debian package allows to link against either python2 or python3.

Code:
[chris@desk ~]$ python -V
Python 3.4.3
[chris@desk ~]$ python2 -V
Python 2.7.9
[chris@desk ~]$ cmake --version
cmake version 3.2.2

I don't know any commands to check, but I have seen both of those python versions in cmake output messages, so I suppose that arch's boost:python is available for both.

Regarding EXACT, it seems to be enough to specify 2 to get version 2 and not 3 in my install. 2.7 with or without EXACT yields the same result.

_________________
Attached patches are released under GPL 2.0 or later.


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 22 posts ]  Go to page Previous  1, 2

All times are UTC


Who is online

Users browsing this forum: No registered users and 2 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
cron
Powered by phpBB® Forum Software © phpBB Group