FreeOrion

Forums for the FreeOrion project
It is currently Sat Dec 16, 2017 1:21 am

All times are UTC




Post new topic Reply to topic  [ 3 posts ] 
Author Message
PostPosted: Tue Aug 16, 2016 2:31 am 
Offline
Creative Contributor
User avatar

Joined: Fri Jun 28, 2013 11:45 pm
Posts: 3295
Several examples make me think whether or not to generate a sitrep is being decided at the wrong time in the effects processing resolution.

1) A damaged ship travelling through a stargate from a system with a drydock will get a sitrep saying it's been repaired, but will only actually be repaired if the arrival system has a sitrep (this is an old one we've discussed before)
2) The Drydock 'partial repair' sitrep will trigger for ships that are fully repaired by other effects (eg nanorobotic hull, logistics coordinator, damage control techs), even though the partial repair effect is, deliberately, given a the lowest priority of all repair types
3) Dampening Cloud sitreps will regularly inform you that a different ship than the one actually affected has lost its fuel. In the attached, my scout ship has not lost its fuel, the enemy cruiser has:
Attachment:
sitrep-error.png
sitrep-error.png [ 379.96 KiB | Viewed 373 times ]


I get the impression that sitreps are being generated in an earlier pass than the actual effects, and definitely aren't taking proper account of priority.

_________________
Mat Bowles

Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.


Top
 Profile  
 
PostPosted: Tue Aug 16, 2016 3:01 am 
Offline
Programmer

Joined: Sun Feb 14, 2016 12:08 am
Posts: 359
MatGB wrote:
2) The Drydock 'partial repair' sitrep will trigger for ships that are fully repaired by other effects (eg nanorobotic hull, logistics coordinator, damage control techs), even though the partial repair effect is, deliberately, given a the lowest priority of all repair types

None of these currently share the same stacking group SHIP REPAIR (only logistics coordinator actually has one, FLAGSHIP_EFFECTS_LOGISTICS).
IIRC it was suggested to sync/balance them with drydock once they are reworked.

Could #1 be a priority issue (since the repairs are before default) ?

Edit: Going to need a priority matrix/chart :/


Top
 Profile  
 
PostPosted: Tue Aug 16, 2016 11:45 pm 
Offline
Creative Contributor
User avatar

Joined: Fri Jun 28, 2013 11:45 pm
Posts: 3295
1 could be (it's been awhile since it I tested for it), but 3 not, I changed that to Very Late Priority when I was doing other things, partially to stop the sitrep triggering almost constantly and partially so it would try to take into account some other repair effects.

_________________
Mat Bowles

Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 3 posts ] 

All times are UTC


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
cron
Powered by phpBB® Forum Software © phpBB Group