FreeOrion

Forums for the FreeOrion project
It is currently Fri May 25, 2018 1:01 pm

All times are UTC




Post new topic Reply to topic  [ 8 posts ] 
Author Message
PostPosted: Thu Jan 11, 2018 6:36 pm 
Offline
Vacuum Dragon
User avatar

Joined: Mon Apr 10, 2017 4:25 pm
Posts: 523
Playing 2018-01-09.4b45d52

It has happened to me in several games playing with Laenfa that the sitrep for the spatial flux bubble hull becoming available appears every turn, despite me not researching that tech. In the last game it began the turn after I got Fusion Generation.

When I was going to open an issue in github, when going to describe how to reproduce the bug, it happens that if I load a previous save of the same game the glitch stops (so the workaround also means it's not reproducible). So I didn't open the issue.

Edit: now loading a game made it happen again, and this time I made myself sure that the Spatial flux Bubble tech wasn't getting any RP. Plus it happened two turns earlies (61 intead of 63, in the same turn I was getting Adaptive Automation and before Fusion Generation was getting any RP). So I don't see any pattern on the occurrence of this glitch. Can you try to reproduce it by yourselves?


Top
 Profile  
 
PostPosted: Thu Jan 11, 2018 11:50 pm 
Offline
Programming, Design, Admin
User avatar

Joined: Wed Oct 08, 2003 1:33 am
Posts: 12194
Location: Munich
Possibly related...

https://github.com/freeorion/freeorion/ ... 68f813b95c


Top
 Profile  
 
PostPosted: Fri Jan 12, 2018 10:42 am 
Offline
Vacuum Dragon
User avatar

Joined: Mon Apr 10, 2017 4:25 pm
Posts: 523
Yeah, looks like it.

The glitch happens on every game I've played with this version, regardless of researching or not the spatial flux bubble tech. It's weirdly annoying.

If the commit wasn't fixing anything, can you revert it for next test version?


Top
 Profile  
 
PostPosted: Fri Jan 12, 2018 11:05 am 
Offline
Programming, Design, Admin
User avatar

Joined: Wed Oct 08, 2003 1:33 am
Posts: 12194
Location: Munich
Oberlus wrote:
If the commit wasn't fixing anything, can you revert it for next test version?
I think that commit was possibly intended to fix this issue. It was committed 13 hours ago.


Top
 Profile  
 
PostPosted: Sat Jan 13, 2018 12:30 am 
Offline
Programmer

Joined: Sun Feb 14, 2016 12:08 am
Posts: 389
Yes, the change/commit in question was to resolve this same issue.
With the tech granted in the effect, each time it activated it granted the tech (sometimes multiple sitreps per turn).

It seemed odd to gate a tech grant by some focus toggle (and probably another headache for AI), so I assumed it was intended to be granted with the tech.
I'll happily put together a PR if there was another intent in mind.


Top
 Profile  
 
PostPosted: Sun Jan 21, 2018 4:36 am 
Offline
AI Lead, Programmer
User avatar

Joined: Sat Sep 22, 2012 6:25 pm
Posts: 4609
You know, I suspect that tech grant slipped into there entirely by accident, or was meant to be temporarily in for convenient testing and got left behind by accident.

From the PR Discussion:
agrrr3 wrote:
Added an easily researchable flux-drive like hull with a single internal slot for hidden expansion.


As it stands right now, although the tech does theoretically have "easily researched" pre-reqs, it is effectively free since it is given away as part of the rather unrelated and free basic stockpiling tech. I think that unlock should just be taken out entirely. Or else the prereqs should be done away with, as they are currently pointless.

_________________
If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0


Top
 Profile  
 
PostPosted: Mon Jan 22, 2018 8:46 pm 
Offline
Space Dragon

Joined: Tue Sep 30, 2014 10:01 am
Posts: 431
Dilvish wrote:
You know, I suspect that tech grant slipped into there entirely by accident, .... I think that unlock should just be taken out entirely.

Jip, sorry :oops:

Its not intended to be directly connected to predictive stockpiling. You should be researching the prereqs first.

_________________
Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.


Top
 Profile  
 
PostPosted: Mon Jan 22, 2018 11:24 pm 
Offline
Vacuum Dragon
User avatar

Joined: Mon Apr 10, 2017 4:25 pm
Posts: 523
I guess this is why LGM-Doyle said that of "All empires should replace their basic outpost/colony ships with these new hulls." in the other thread, because if it is better than standard in all senses and available from start...
I agree with you all the unlock can be removed. Stealthy empires can work for the very early turns without the bubble hull, they can wait to research the prerreqs.


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 8 posts ] 

All times are UTC


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group