FreeOrion

Could you play around with that to try to determine what part of it is the problem? That is, whether the Destroy effect, or a particular part of the activation condition, causes the hang or prevents the hang if removed?

I think this is fixed, though am not entirely sure.

The issue with modifications to current meters not being reflected in predicted meter changes still remains, though. Fixing that will be somewhat complicated, as the game is currently making the assumption that current meters usually only change due to internal C++ derived turn-by-turn adjustments.

I believe this has been fixed by my recent changes to how colonize orders work, though there remain some UI issues to be fixed related to the changes.

This is really strange, but it seems that when "BLD_PLANET_BEACON" is in the same system as Source, the hang doesn't occur, and when it's one starlane jump away, it does occur. I thought at first that this was related to the fact that the planet was being moved by a different effect, but it seems that this isn't the case, since when I removed the effects group that moved the planet, the hang occurred just as before.

_________________
Warning: Antarans in dimensional portal are closer than they appear.

This should be fixed.

I've fixed a crash I got with that effects group, though the specifics weren't quite the same as what you described, so if you could re-test and report back, that'd be helpful.

I'm still getting the same problem.

Also, in the new encyclopedia panel, there's no apparent way to get back to the index after clicking on a link. Also, it doesn't appear to go away between turns. This may be related to a different bug (I assume) I experience, where moving the mouse off the right side or bottom of the screen and click-dragging will cause the galaxy map to appear while the splash screen is still up between turns.

_________________
Warning: Antarans in dimensional portal are closer than they appear.

I'll need a save file that works with the latest version to test with then.


The encyclopedia additions are incomplete.


Why should it?


I don't follow... If fullscreen, how are you moving the mouse cursor "off" the screen? If windowed, moving the cursor off the screen should mean any clicks aren't on the FreeOrion window.

Here:

If the planet isn't destroyed, and is moved successfully to it's destination, then you may need to remove the Random activation condition from species.txt to ensure that the effects group is activated.

If the planet is successfully destroyed, then this hang apparently can't be reproduced on your system.

Perhaps I wasn't clear:

In windowed mode, the mouse can't be moved out of the FreeOrion window. Moving it to the top or the left will stop the mouse before it goes out of the window, and moving it to the right or down will allow it to disappear off the side of the window (much like moving the mouse around your desktop). It is when the mouse has disappeared off the right or the bottom that click-dragging will cause the galaxy map to appear:

_________________
Warning: Antarans in dimensional portal are closer than they appear.

This seems to be an issue with OSX specifically, due to limitations / problems with the OIS plugin that handles mouse input. In Win32, windowed mode lets the mouse move outside the window and there function normally, when the appropriate DirectX flag is set in the initialization. There's no equivalent support for OSX, though (see: viewtopic.php?p=41339#p41339 ).

...

In an unrelated issue, do you have any problems getting the mining meter of your homeworld to grow? I'm finding that if I set the homeworld to mining focus, the mining meter never increases above 7.5, though the farming keeps falling each turn as it should with the focus changed away from farming. Species is Trith, in case it maters.

You might be able to reproduce this in fullscreen mode, since the behaviour of the mouse with regards to the edges of the screen should be the same as what I experience.

Since I compiled the latest revision, I haven't experienced any meter growth at all. Farming, mining, industry, research, population and construction do not grow, and I suspect that this is the case for defense, shields, health and structure as well.

_________________
Warning: Antarans in dimensional portal are closer than they appear.

I can switch the Windows mouse handling to force the cursor to stay in the window as well. But I'm not especially concerned about it as I'd like to get rid of the turn processing screen anyway, and just leave the map for the player to view and interact with while waiting for updates (and later, while combat is resolving).

Once Xenoarcheological Restoration has been researched, the game will hang on Production and Growth whenever a planet with Ancient Ruins is colonized, due to this effects group:The last thing in the freeoriond log was '2010-08-28 07:31:01,143 ERROR Server : Planet::EnvironmentForSpecies couldn't get own species with name ""'

Perhaps the effects group is being passed before the planet is populated, and it can't get the planet's species for the ship that's being created, or something like that?

_________________
Warning: Antarans in dimensional portal are closer than they appear.

This test effects group creates a ship with full fuel and structure on the first turn, and 0 fuel and structure on every following turn:

Also, this might already be known, but ships aren't destroyed when structure reaches 0.

_________________
Warning: Antarans in dimensional portal are closer than they appear.

The effects group has a problem with "Source.Planet.Species". If a special is attached to a planet, then the planet IS the source object, and you shouldn't be using Source.Planet, which probably returns no object, leading to problems. Changing to Source.Species avoids the hang, for me.

Edit: I've added some safety checks in the reference evaluation code that should prevent the crashes and output an error message to the server log when an invalid reference is evaluated. /Edit

The ERROR message you quote is likely unrelated to this effect (there's no need to get the planet environment for a species when creating a ship... and it doesn't) but I've made some changes to get rid of them and some similar error messages that weren't really errors (eg. can't find a species with name "" for planets with no species on them...).

I've also fixed some unrelated problems with CreateShip when using predefined ship designs in loaded games.


Other than combat, effects-related bugs, and effects, there isn't supposed to be any way for ships' structures to fall to zero. So likely the only place there is a check for structure being 0 is at the end of combat.