More fleetmerge crashing

[MatGB]

RC2
freeoriond.log

Code: Select all

2014-08-25 14:36:14,288 DEBUG Server : Server received message from player id: 1 of type Request New Object ID and size 8
2014-08-25 14:36:35,570 DEBUG Server : Server received message from player id: 1 of type Request New Object ID and size 8
2014-08-25 14:37:11,267 DEBUG Server : ServerNetworking::DisconnectImpl : disconnecting player 1
2014-08-25 14:37:11,268 DEBUG Server : ServerFSM::HandleNonLobbyDisconnection : Lost connection to player #1, named "Human_Player"; server terminating.
2014-08-25 14:37:11,274 DEBUG Server : ServerFSM::HandleNonLobbyDisconnection : All human players disconnected; server terminating.
2014-08-25 14:37:13,275 DEBUG Server : Initiating Exit (code 1 - error termination)
2014-08-25 14:37:13,276 DEBUG Server : ServerApp::CleanupAIs() telling AIs game is ending
2014-08-25 14:37:13,276 ERROR Server : ServerApp::CleanupAIs() exception while sending end game messages
2014-08-25 14:37:13,276 DEBUG Server : ServerApp::CleanupAIs() killing 8 AI clients.
2014-08-25 14:37:13,277 ERROR Server : Process::Impl::Kill : Error terminating process: Access is denied.
2014-08-25 14:37:13,277 ERROR Server : Process::Impl::Kill : Error terminating process: Access is denied.
2014-08-25 14:37:13,278 ERROR Server : Process::Impl::Kill : Error terminating process: Access is denied.
2014-08-25 14:37:13,278 ERROR Server : Process::Impl::Kill : Error terminating process: Access is denied.
2014-08-25 14:37:13,278 ERROR Server : Process::Impl::Kill : Error terminating process: Access is denied.
2014-08-25 14:37:13,278 ERROR Server : Process::Impl::Kill : Error terminating process: Access is denied.
2014-08-25 14:37:13,278 ERROR Server : Process::Impl::Kill : Error terminating process: Access is denied.
2014-08-25 14:37:13,278 ERROR Server : Process::Impl::Kill : Error terminating process: Access is denied.

freeorion.log:

Code: Select all

2014-08-25 14:36:49,630 DEBUG Client : MapWnd::SelectedShipsChanged time: 67
2014-08-25 14:36:51,531 DEBUG Client : MapWnd::SelectedShipsChanged time: 62
2014-08-25 14:36:56,390 DEBUG Client : FleetWnd::AcceptDrops with 6 wnds at pt: (173, 581)
2014-08-25 14:36:56,391 DEBUG Client : FleetWnd::AcceptDrops found 6 ship ids: 4041 4327 4323 4185 4182 4183 

Had used the system merge function, then split off all damaged ships, then selected the damaged-but-only-slightly ships with intent to merge them back into the main fleet and send them back into the fray.

Accidentally dropped them into the fleet they were already in, and the game did the oh-so-familiar hang then crash. Couldn't find a recent(ish) support thread on the fleetmerge crash issue so just started a new one, but am aware it's an ongoing issue so not reporting this as an RC2 bug specifically.

[MatGB]

I had hoped this was solved

The logs look remarkably similar to the above, in this case I knocked the mouse as I let go the button and it went out of the fleetwnd as I let go, if that helps.

Idea, perhaps with all the other right click options could we get a "merge selected into top fleet" option? 9 times out of 10 I'm simply moving the "not actually that badly damaged" ships back into the combat fleet before sending the rest off for repairs.

[Dilvish]

ok well it looks to me like the next step for us would be to augment some of the logging for this that Geoff had added at the start of the year. What we have here is

Code: Select all

2015-06-24 01:46:22.631721 [debug] Client : FleetWnd::AcceptDrops with 5 wnds at pt: (331, 639)
2015-06-24 01:46:22.631801 [debug] Client : FleetWnd::AcceptDrops found 5 ship ids: 4155 4154 4157 4153 4152 

I think what I would look to add to this would be output for the UL & LR pts of the FleetWnd itself, and of the FleetDataPanel which is accepting the drops, and also the fleetID of the FleetDataPanel accepting the drops and the fleetIDs of each of the ships being dropped into it. Then next time this happens, please copy the log and then right after that reload the game, checking the listed FleetDataPanel fleetID, identifying which fleetPanel it was in teh UI, and also check and the fleetIDs for the ships, to see what can be gleaned from that.

That right click option is probably decent (convenient and probably more reliable), but if it's ok I'd like to work harder at fixing this bug first, then we can add the convenience function.

[Geoff the Medio]

ok well it looks to me like the next step for us would be to augment some of the logging for this...

Started to do so...

[gendalf]

0.4.5(2015.09.01) select all fleets in area, click merge all, sometimes it merges sometimes it crashes :p

[coCoKNIght]

This has always been and continues to be the nr.1 crash situation for me. here are the logs of the last such crash. Draged two ships to another fleet but missed (since it's hard not to). Can I do something so that more info is logged, or can you guys make use of this log info?

v 0.4.5 f203162
----------
freeorion.log:
----------
2015-09-24 10:05:54.069079 [debug] Client : MapWnd::SelectedShipsChanged time: 36.531
2015-09-24 10:05:57.977886 [debug] Client : MapWnd::SelectedShipsChanged time: 28.173
2015-09-24 10:06:00.536089 [debug] Client : FleetWnd::AcceptDrops with 8 wnds at pt: (142, 538)
2015-09-24 10:06:00.536290 [debug] Client : FleetWnd::AcceptDrops found 8 ship ids: 39604 39603 39601 39606 39600 39605 39599 39602
2015-09-24 10:06:00.536350 [debug] Client : FleetWnd::CreateNewFleetFromDrops with 8 ship ids
2015-09-24 10:06:00.565344 [debug] Client : MapWnd::SelectedShipsChanged time: 29.779
2015-09-24 10:06:00.565390 [debug] Client : CreateNewFleetFromShips with 8
2015-09-24 10:06:00.565701 [debug] Client : Inserting object with id 39911
2015-09-24 10:06:00.807679 [debug] Client : MapWnd::SelectedShipsChanged time: 24.852
2015-09-24 10:06:03.819969 [debug] Client : MapWnd::SelectedShipsChanged time: 27.056
2015-09-24 10:06:04.962266 [debug] Client : MapWnd::SelectedShipsChanged time: 36.872
2015-09-24 10:06:07.806482 [debug] Client : FleetWnd::AcceptDrops with 2 wnds at pt: (139, 170)
2015-09-24 10:06:07.806699 [debug] Client : FleetWnd::AcceptDrops found 2 ship ids: 39608 39607
----------
freeoriond.log:
----------
2015-09-24 10:07:27.396797 [debug] Server : ServerNetworking::DisconnectImpl : disconnecting player 1
2015-09-24 10:07:27.396951 [debug] Server : ServerFSM::HandleNonLobbyDisconnection : Lost connection to player #1, named "coCoKNIght"; server terminating.
2015-09-24 10:07:27.397301 [debug] Server : ServerFSM::HandleNonLobbyDisconnection : All human players disconnected; server terminating.
2015-09-24 10:07:29.397471 [debug] Server : Initiating Exit (code 1 - error termination)
2015-09-24 10:07:29.397521 [debug] Server : ServerApp::CleanupAIs() telling AIs game is ending
2015-09-24 10:07:29.397866 [debug] Server : ServerApp::CleanupAIs() waiting 1 second for AI processes to clean up...
2015-09-24 10:07:30.397987 [debug] Server : ServerApp::CleanupAIs() killing 18 AI clients.

...and then the log further states that the AIs are killed one by one...

When I reload the game and check in the fleet window, the initial fleet id is 39619, from this fleet I first took 8 ships to create a new fleet. If I recreate that, then I end up with fleet ids 39619 and 40105. Then I took another two from 39619 and tried to drop them into 40105 but missed. If I recreate that the game doesn't crash anymore...

What else can I look up?

Here's the log from after reloading and trying to recreate:
----------
freeorion.log:
----------
2015-09-24 10:34:28.176196 [debug] Client : MapWnd::SelectedShipsChanged time: 25.733
2015-09-24 10:34:34.140153 [debug] Client : MapWnd::SelectedShipsChanged time: 25.947
2015-09-24 10:34:37.113941 [debug] Client : FleetWnd::AcceptDrops with 8 wnds at pt: (152, 510)
2015-09-24 10:34:37.114087 [debug] Client : FleetWnd::AcceptDrops found 8 ship ids: 39600 39601 39602 39603 39604 39599 39605 39606
2015-09-24 10:34:37.114132 [debug] Client : FleetWnd::CreateNewFleetFromDrops with 8 ship ids
2015-09-24 10:34:37.114163 [debug] Client : CreateNewFleetFromShips with 8
2015-09-24 10:34:37.114954 [debug] Client : Inserting object with id 40105
2015-09-24 10:34:37.261869 [debug] Client : MapWnd::SelectedShipsChanged time: 13.616
2015-09-24 10:34:42.691547 [debug] Client : HumanClientApp::HandleFocusChange()
2015-09-24 10:34:44.442612 [debug] Client : HumanClientApp::HandleFocusChange()
2015-09-24 10:34:46.305838 [debug] Client : HumanClientApp::HandleFocusChange()
2015-09-24 10:35:03.614624 [debug] Client : HumanClientApp::HandleFocusChange()
2015-09-24 10:35:05.988055 [debug] Client : HumanClientApp::HandleFocusChange()
2015-09-24 10:35:09.673683 [debug] Client : HumanClientApp::HandleFocusChange()
2015-09-24 10:35:11.445136 [debug] Client : HumanClientApp::HandleFocusChange()
2015-09-24 10:35:12.870753 [debug] Client : HumanClientApp::HandleFocusChange()
2015-09-24 10:35:14.050492 [debug] Client : PlotFleetMovement
2015-09-24 10:35:14.088889 [debug] Client : PlotFleetMovement
2015-09-24 10:35:14.596080 [debug] Client : PlotFleetMovement
2015-09-24 10:35:14.634388 [debug] Client : PlotFleetMovement
2015-09-24 10:35:14.634724 [debug] Client : PlotFleetMovement
2015-09-24 10:35:14.666902 [debug] Client : PlotFleetMovement
2015-09-24 10:35:16.855079 [debug] Client : MapWnd::SelectedShipsChanged time: 22.517
2015-09-24 10:35:23.058405 [debug] Client : MapWnd::SelectedShipsChanged time: 23.931
2015-09-24 10:35:37.862889 [debug] Client : FleetWnd::AcceptDrops with 2 wnds at pt: (125, 171)
2015-09-24 10:35:37.863034 [debug] Client : FleetWnd::AcceptDrops found 2 ship ids: 39607 39608
2015-09-24 10:35:41.518461 [debug] Client : MapWnd::SelectedShipsChanged time: 23.532
2015-09-24 10:35:43.708570 [debug] Client : MapWnd::SelectedShipsChanged time: 26.828
2015-09-24 10:35:47.748352 [debug] Client : FleetsListBox::AcceptDrops
2015-09-24 10:35:47.748514 [debug] Client : ... drop pt: (132, 178)
2015-09-24 10:35:47.748552 [debug] Client : ... drop row is in position: 1
2015-09-24 10:35:47.748588 [debug] Client : ... getting/sorting dropped fleets or ships...
2015-09-24 10:35:47.748613 [debug] Client : ... processing dropped 2 ships
2015-09-24 10:35:47.774742 [debug] Client : MapWnd::SelectedShipsChanged time: 25.451
2015-09-24 10:35:47.891373 [debug] Client : FleetsListBox::AcceptDrops finished
2015-09-24 10:35:50.589599 [debug] Client : HumanClientApp::HandleFocusChange()
2015-09-24 10:37:47.416858 [debug] Client : HumanClientApp::HandleFocusChange()
2015-09-24 10:37:48.209162 [debug] Client : HumanClientApp::HandleFocusChange()
2015-09-24 10:38:14.394227 [debug] Client : HumanClientApp::HandleFocusChange()
2015-09-24 10:38:22.899240 [debug] Client : HumanClientApp::HandleFocusChange()

[Geoff the Medio]

Draged two ships to another fleet but missed...

Missed?

Can I do something so that more info is logged, or can you guys make use of this log info?

Editing the .cpp files would be needed.

[coCoKNIght]

Missed?

Yes, it's quite annoying actually. It's like the release area is only on the title bar of the fleet and on the 1px border, so when I drag ships to a fleet - since the movement comes from the bottom - the target fleet gets highlighted when I pass the 1px border at the bottom, but then immediately reverts again, usually at the same time I release, since I got visual feedback that it was okay to release...

Editing the .cpp files would be needed.

Sounds like it requires compiling but currently I'm unable to compile, the linux instructions are not working for me anymore, I'm running the binaries from the Apoleon PPA.

[Geoff the Medio]

I think you're dropping on the stat icons. It's not just the border or title bar that are valid drop targets.

[coCoKNIght]

Visual explanation:
I'm dragging 2 ships from fleet 39619 and want to merge them with fleet 40067:
Screenshot1: When dragging ships into a fleet it becomes briefly possible to drop the ships on the fleet...(fleet 40067 becomes highlighted)
Screenshot2: ...but when the mouse cursor moves a little bit more to the top, it's not possible anymore... (no highlight, border and title bar become dark gray again)
Screenshot3: ...only when reaching the title bar area, it becomes possible to release to merge again. (fleet 40067 becomes highlighted again)

Note that the game may crash regardless of whether the ships were released while the fleet was highlighted or not. It can also happen when releasing on the 'New fleet' box.

[AndrewW]

[Sounds like it requires compiling but currently I'm unable to compile, the linux instructions are not working for me anymore, I'm running the binaries from the Apoleon PPA.

The instructions you are trying might be out of date, some things have changed.

Try posting the problem over in the Compile section of the forum.

[MatGB]

For what it's worth, I dislike the current merging drag/drop interface, I find getting the mouse in the right place fiddly and annoying. I would love it if we have a 'merge selected into fleet X' option or similar, given that the crashes seem to be drag/drop related as well, reducing or eliminating the need for that interface might be a good plan.

[defaultuser]

For what it's worth, I dislike the current merging drag/drop interface, I find getting the mouse in the right place fiddly and annoying.

Especially if it's laggy and you have a lot of ships you're trying to move.

[Geoff the Medio]

Screenshot2: ...but when the mouse cursor moves a little bit more to the top, it's not possible anymore... (no highlight, border and title bar become dark gray again)

Looks like you're dropping on a stat icon, as I suspected. Try dropping in the dark area to the right of the last stat icon, which is neither border nor title bar.

[coCoKNIght]

Looks like you're dropping on a stat icon, as I suspected.

As I've said, I 'missed', and this happens because when I drag ships onto the fleet box I get visual feedback from the fleet box that it's okay to release, but when I do release the cursor has already traveled a little bit further up where dropping is not possible anymore. I want to stress again that this is not the cause of the crashes, and I wouldn't have mentioned it further, after all the game's still at version 0.4.5.

Anyway, since it's been brought up so much, here are my thoughts:
The stat icons can't be dragged around and they're not used as drop area for something else. They are part of the fleet box, and the fleet box is the object that is interacted with when doing drag and drop.
Even if the stat icons would require individual drag and drop capabilities, it's not good practice to have tiny mouse over areas as it is the case at the bottom border of the fleet box (Screenshot1).
I guess the reason why you can't drop on the stat icons is that they're required to listen for mouse over events in order to display the information tip box. But it already doesn't do that when dragging, so might as well disable the stat icon area or the listeners entirely for the duration of the drag and drop action.