FreeOrion

Forums for the FreeOrion project
It is currently Sat Nov 18, 2017 9:16 pm

All times are UTC




Post new topic Reply to topic  [ 104 posts ]  Go to page Previous  1 ... 3, 4, 5, 6, 7
Author Message
 Post subject: Re: English stringtable
PostPosted: Fri Jul 29, 2016 11:09 am 
Offline
Programming, Design, Admin
User avatar

Joined: Wed Oct 08, 2003 1:33 am
Posts: 12013
Location: Munich
Say something like "... further increases ..." instead of "... increases the size of increased ..."?


Top
 Profile  
 
 Post subject: Re: English stringtable
PostPosted: Fri Jul 29, 2016 5:13 pm 
Offline
Creative Contributor
User avatar

Joined: Fri Jun 28, 2013 11:45 pm
Posts: 3259
One of the increases needs to be improves, or similar, yeah, good catch, as written it's both clunky and unclear, I don't mind clunky if it's the only way to be clear but but together is bad.

_________________
Mat Bowles

Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.


Top
 Profile  
 
 Post subject: Re: English stringtable
PostPosted: Sat Jul 30, 2016 7:51 am 
Offline
Programmer
User avatar

Joined: Fri Mar 01, 2013 9:52 am
Posts: 1040
Location: Germany
Quote:
Improved centralized management of dispersed industrial activities further increases industrial output provided.


Yeah, I'm okay with that.

_________________
Resident code gremlin
Attached patches are released under GPL 2.0 or later.
Git author: Marcel Metz


Top
 Profile  
 
 Post subject: Re: English stringtable
PostPosted: Mon Aug 01, 2016 11:22 am 
Offline
Programmer
User avatar

Joined: Fri Mar 01, 2013 9:52 am
Posts: 1040
Location: Germany
I'm brushing up the documentation of the english string table and have not even the remotest idea what the author of theNEW_ASTEROIDS_NAME comment is trying to say to me. So Geoff, speak up. What substitution values of the %1% and %2% placeholders? And why should I care about internals on how an asteroid belt is generated as a translator?

_________________
Resident code gremlin
Attached patches are released under GPL 2.0 or later.
Git author: Marcel Metz


Top
 Profile  
 
 Post subject: Re: English stringtable
PostPosted: Mon Aug 01, 2016 2:04 pm 
Offline
Programming, Design, Admin
User avatar

Joined: Wed Oct 08, 2003 1:33 am
Posts: 12013
Location: Munich
adrian_broher wrote:
I'm brushing up the documentation of the english string table and have not even the remotest idea what the author of theNEW_ASTEROIDS_NAME comment is trying to say to me. So Geoff, speak up. What substitution values of the %1% and %2% placeholders? And why should I care about internals on how an asteroid belt is generated as a translator?
I assume you're asking about:
Code:
# new asteroids or new planet names...
# used to generate name for effect-created planets, when no name = (string) is specified.
# When specifying an object name for these effects, if the specified string matches a
# stringtable key, it will be looked up and used directly. Alternatively, the
# UserString("STRING_KEY") function can be used. In this case, the % operator can be used
# to specify substitutions using string gamestate references, such as Source.Name
# these are applied to the %1% style placeholders according the order in which the
# parameters are specified in the effect
NEW_ASTEROIDS_NAME
%1% %2% remnants

I don't know why this comment in the stringtable is telling you about syntax for effect scripting, and I don't know what the author of that comment did in scripts in general... But I think I've seen in relevant test games something like "Systemname II remnants[/quote], so I guess %1% would be the system name, and %2% would be a numeral for the planet number. Not sure though.


Top
 Profile  
 
 Post subject: Re: English stringtable
PostPosted: Mon Aug 01, 2016 2:53 pm 
Offline
Programmer
User avatar

Joined: Fri Mar 01, 2013 9:52 am
Posts: 1040
Location: Germany
Geoff the Medio wrote:
I assume you're asking about:


Yes, that's the comment in question.

Quote:
I don't know why this comment in the stringtable is telling you about syntax for effect scripting, and I don't know what the author of that comment did in scripts in general... But I think I've seen in relevant test games something like "Systemname II remnants, so I guess %1% would be the system name, and %2% would be a numeral for the planet number. Not sure though.


Well, I asked you because you added this comment in the first place (git blame says so) with the commits c2fcafa5, and a4d24919. No intermediate predecessor of the those commit for those lines was of any help either so I'm just asking here. The commit itself is complete irrelevant for translators and more helpful for people, who want wo use UserString inside the FOCS script.

_________________
Resident code gremlin
Attached patches are released under GPL 2.0 or later.
Git author: Marcel Metz


Top
 Profile  
 
 Post subject: Re: English stringtable
PostPosted: Mon Aug 01, 2016 3:25 pm 
Offline
Creative Contributor
User avatar

Joined: Fri Jun 28, 2013 11:45 pm
Posts: 3259
I can't find those commits my git client fu is failing but I'm fairly certain that comment was put in at the same time Geoff fixed the planet creation effects ages ago when Sloth and I were messing around making nebulas work properly and the planet naming just wasn't working right.

It's also in the process of being revised in some way by either Dbenage-CX or LGM-Doyle as part of the asteroid renaming thing but I can't find that PR either, I think I need more coffee.

We are a bit bad when it comes to documenting things in the right place, but I like having an explanation for a weird key with parameters with that key myself, especially given it can be used in multiple different effects.

_________________
Mat Bowles

Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.


Top
 Profile  
 
 Post subject: Re: English stringtable
PostPosted: Mon Aug 01, 2016 8:16 pm 
Offline
Release Manager, Design
User avatar

Joined: Wed Nov 16, 2011 12:56 pm
Posts: 4241
Location: Sol III
MatGB wrote:
I think I need more coffee.
That, or you need to take a nap (more healthy! ;)).


Top
 Profile  
 
 Post subject: Re: English stringtable
PostPosted: Wed Aug 03, 2016 7:26 pm 
Offline
Dyson Forest
User avatar

Joined: Wed Aug 13, 2014 7:21 pm
Posts: 208
Location: France
I plan to add the # StarTypes, # PlanetTypes, and # PlanetSizes keys in the stringtables (# PlanetEnvironments already done in a previous commit), but in the same time, to reorganize/rewrite each article that contains "Increases value on planets per population, by planet size/star type/planetary environment or habitability" description stuff, in order to be more easy/convenient to read.

But prior to that, I want to know if you think it's a good idea or not, and if it's yes, if the rewrite is clear enough (or if it could be better), and if the english syntax is OK^^.

Thanks.

Ex:

Attachment:
tomo.png
tomo.png [ 29.2 KiB | Viewed 1121 times ]

Attachment:
xeno.png
xeno.png [ 31.82 KiB | Viewed 1119 times ]

_________________
I release every updated file under the CC-BY-SA 3.0 license.


Last edited by Ouaz on Wed Aug 03, 2016 8:07 pm, edited 4 times in total.

Top
 Profile  
 
 Post subject: Re: English stringtable
PostPosted: Wed Aug 03, 2016 8:00 pm 
Offline
Release Manager, Design
User avatar

Joined: Wed Nov 16, 2011 12:56 pm
Posts: 4241
Location: Sol III
IMO definitely an improvement.


Top
 Profile  
 
 Post subject: Re: English stringtable
PostPosted: Wed Aug 03, 2016 11:28 pm 
Offline
Creative Contributor
User avatar

Joined: Fri Jun 28, 2013 11:45 pm
Posts: 3259
Agreed.

I've been toying with the idea of a very clearly worded 'planet size' page and then using that in all those places where the bonus is based on planet size, I think "hostile planets get a bonus equal to twice planet size" is clearer than what we have but also having the summary would help.

From my end it's partially inspired by thinking of increasing the number of costs that are partially determined by size, I already did artificial planet, terraform and gaia, I'm thinking that Space Elevator might benefit from that as well.

But improved clarity in the way population growth and the various tech interactions definitely needs to be a documentation priority.

_________________
Mat Bowles

Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.


Top
 Profile  
 
 Post subject: Re: English stringtable
PostPosted: Thu Aug 04, 2016 8:24 pm 
Offline
Programmer
User avatar

Joined: Fri Mar 01, 2013 9:52 am
Posts: 1040
Location: Germany
I'm still updating the comments.

What is the functional difference between a 'bout' and a 'round' in combat events? Reading the code didn't gave me any insight.

_________________
Resident code gremlin
Attached patches are released under GPL 2.0 or later.
Git author: Marcel Metz


Top
 Profile  
 
 Post subject: Re: English stringtable
PostPosted: Thu Aug 04, 2016 8:55 pm 
Offline
Programmer

Joined: Mon Feb 29, 2016 8:37 pm
Posts: 198
adrian_broher, the description in the code and the description in game are not consistent. Bouts in the code are the same as rounds in the game descriptions.

In the code/programmer perspective:
[*] round: 1 ship/planet fires all its weapons. There are as many rounds as there are attacking ships/planets.
[*] bout: all ships/planets fire all their weapons once. The number of bouts is fixed at 3.

In the game/player perspective:
[*] round: all ships/planets fire all their weapons once. There are 3 rounds.


Top
 Profile  
 
 Post subject: Re: English stringtable
PostPosted: Thu Aug 04, 2016 11:14 pm 
Offline
Creative Contributor
User avatar

Joined: Fri Jun 28, 2013 11:45 pm
Posts: 3259
Aye, until now I'd not encountered 'bout' as a term, and wouldn't want to introduce it, if it's in en.txt it needs removing, consistency in terms—especially terms that confuse new players, is important.

_________________
Mat Bowles

Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 104 posts ]  Go to page Previous  1 ... 3, 4, 5, 6, 7

All times are UTC


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group