English stringtable

[Ouaz]

For the english stringtable maintainers:

Spelling errors on line 4701 (Etty's description, 'sent' instead of 'scent')

Code: Select all

4701 Etty have very strong sent which they can vary at will, this evolutionary adoption allowed them to protect themselves from plant eaters by mimicking the sent of greater predators [...]

[MatGB]

How have I missed that up until now? Ok, thanks, annoying.

As I'm sure you're noticing, reading through the entire thing looking for minor issues is a very weird job, I can't imagine trying to do it for two different languages.

[Ouaz]

As I'm sure you're noticing, reading through the entire thing looking for minor issues is a very weird job, I can't imagine trying to do it for two different languages.

Oh yeah!

It was easy for the first 3000 lines but coming to the description stuff, ouch! Requires a lot more work and time!

I'm not strictly checking the english file, I just noticed this minor typo, by translating the species descriptions, as I use the latest en.txt as reference.

[BendingBender]

Hi,

For the english stringtable maintainers:

Spelling errors on line 4701 (Etty's description, 'sent' instead of 'scent')

I've just noticed that the incorrecty spelled word 'sent' appears twice in the string from above post. However, in revision #7578, only the first appearance of this word was fixed, not the second.

Regards,
BendingBender

[Vezzra]

I've just noticed that the incorrecty spelled word 'sent' appears twice in the string from above post. However, in revision #7578, only the first appearance of this word was fixed, not the second.

Thanks, fix committed.

[Ouaz]

For english stringtable maintainers:

A big typo on line 7139 (en.txt r7629)

Code: Select all

PRO_NDIM_ASSMB
N-Dimensional Assembly

PRO_NDIM_ASSMB_DESC
''' Unlocks the Hyperspatial Dam

Once the greatest fear of N-dimensional physicists, now the noblest goal. To deliberately create a hyperspatial rift between our universe and the next, but inside a dimensional bubble, safely separate from known space-time. Once this is accomplished, it would be a relatively simple matter to tap into the enormous flow of energy that would travel across the rift.

Unlocks the Hyperspatial Dam is not needed.

typo_ndimens_assembly.PNG (31.29 KiB) Viewed 2163 times

[Vezzra]

Unlocks the Hyperspatial Dam is not needed

Fixed. Committed to trunk, merged to release branch.

[Cjkjvfnby]

My old patch with ORCER is not applyed
viewtopic.php?f=27&t=8554#p71900

Design screen have wrong error message:

Code: Select all

 DESIGN_INV_NO_NAME
-Each ship design must have a unique name.
+Design name cannot be empty.

[Dilvish]

Fix typo ORCER to ORDER

Comitted.

Code: Select all

r7770 | dilvish-fo | 2014-11-20 14:16:37 -0800 (Thu, 20 Nov 2014) | 1 line
patch by Cjkjvfnby fixing spelling of ORCER_CANCEL_GIVE_FLEET and ORCER_CANCEL_GIVE_PLANET stringtable tags to ORDER....

[Dilvish]

My old patch with ORCER is not applyed
viewtopic.php?f=27&t=8554#p71900

That patch had a faulty structure (some filenames starting with "FreeOrion/" and some not, may have been why it didn't get acted on. But it's done now.

Design screen have wrong error message:

Code: Select all

r7771 | dilvish-fo | 2014-11-20 14:25:32 -0800 (Thu, 20 Nov 2014) | 1 line
correction by Cjkjvfnby to a Design Wnd warning message re empty name

[Cjkjvfnby]

But it's done now.

Thank you.

Is it correct that chars '\n', space, and ":" at the start or end of text should be in code, and not in stringtables?

And this is should be changed (and add space after ':')

Code: Select all

# EncyclopediaDetailPanel.cpp
detailed_description += UserString("EMPIRE_CAPITAL") +
                LinkTaggedIDText(VarText::PLANET_ID_TAG, capital->ID(), capital->Name());

# en.txt
EMPIRE_CAPITAL
Capital: 

[Dilvish]

Is it correct that chars '\n', space, and ":" at the start or end of text should be in code, and not in stringtables?

We don't normally expect newlines, spaces, nor colons to be translated differently for different languages (though I suppose it might be at least imaginable for the colon) and so sometimes those things get hardcoded and other times they get put into stringtables. Seems reasonable to leave that to the discretion of the person doing the initial coding.

And this is should be changed (and add space after ':')

Code: Select all

# EncyclopediaDetailPanel.cpp
detailed_description += UserString("EMPIRE_CAPITAL") +
                LinkTaggedIDText(VarText::PLANET_ID_TAG, capital->ID(), capital->Name());

# en.txt
EMPIRE_CAPITAL
Capital: 

Are you proposing that a second space be added after the colon? Different style guides have different rules on that for usage ina sentence I think, and regardless, I don't think it need be followed in tables and such.

[Cjkjvfnby]

Are you proposing that a second space be added after the colon? Different style guides have different rules on that for usage ina sentence I think, and regardless, I don't think it need be followed in tables and such.

Sorry, can you repeat in other words.

Russian translation looks bad, English for me looks bad too. "Capital:Moscow"

I want to see "Capital: Moscow". How should I fix this?
1) c++ ": " space and colon
2) c++ " " space only
3) c++ nothing, add space to string tables.

[Dilvish]

Sorry, can you repeat in other words.

There is already one space there.

Russian translation looks bad, English for me looks bad too. "Capital:Moscow"

Are you sure that in english it displays for you as "Capital:Moscow"? For me it (the empire pedia page, yes?) displays in the form "Capital: Moscow". The russian stringtable entry is missing a space after the colon ("Столица:"), but the english stringtable entry already has one ("Capital: "). Add the space to the russian entry.

[Cjkjvfnby]

upd.
patches removed, will add them later.