FreeOrion

Forums for the FreeOrion project
It is currently Tue Dec 12, 2017 9:51 pm

All times are UTC




Post new topic Reply to topic  [ 104 posts ]  Go to page Previous  1 ... 3, 4, 5, 6, 7  Next
Author Message
 Post subject: Re: English stringtable
PostPosted: Tue Jan 19, 2016 9:26 pm 
Offline
Creative Contributor
User avatar

Joined: Fri Jun 28, 2013 11:45 pm
Posts: 3291
Not sure someone's working on it directly, but it's one of those things someone'll do eventually.

Yes, was actually working on this last week (I have Issue #329 open in a different tab) but what I tried didn't work and I ran out of time so switched to testing something instead. There's no need for the Starlane Speed inclusion as, since I wrote those bits of text the pedia display was updated to show that instead of what was there. The same needs to be done with Stealth but when I tried doing that myself it didn't work so I assume a backend change is needed.

I was planning on moving the text to the end of the entry and having it appear directly above and in the same style as the pregenerated list until such time as we can have them all pregenerated.

Actually, just reread your suggestion, there's no need to complicate things, having the actual stat is and should be fine, the text was a shortcut back when I was very new to things (it was part of my first big patch), so no need for star ratings or similar.

_________________
Mat Bowles

Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.


Top
 Profile  
 
 Post subject: Re: English stringtable
PostPosted: Tue Jan 19, 2016 9:49 pm 
Offline
Programming, Design, Admin
User avatar

Joined: Wed Oct 08, 2003 1:33 am
Posts: 12041
Location: Munich
Ouaz wrote:
...with rating icons...¤...¤¤¤...¤¤¤¤¤
I would avoid a star-based rating such as that because it's not clear whether ¤ and ¤¤¤ are bad and average, bad and great, average and great, or what...


Top
 Profile  
 
 Post subject: Re: English stringtable
PostPosted: Tue Jan 19, 2016 10:46 pm 
Offline
Dyson Forest
User avatar

Joined: Wed Aug 13, 2014 7:21 pm
Posts: 213
Location: France
MatGB wrote:
Yes, was actually working on this last week (I have Issue #329 open in a different tab)


Actually, I precisely had this in mind when I posted (not the Git Issue, the rough level estimation in full words, which can be fuzzy/unclear when comparing ship hulls)

Quote:
I was planning on moving the text to the end of the entry and having it appear directly above and in the same style as the pregenerated list until such time as we can have them all pregenerated.

Actually, just reread your suggestion, there's no need to complicate things, having the actual stat is and should be fine, the text was a shortcut back when I was very new to things (it was part of my first big patch), so no need for star ratings or similar.


OK, makes sense now. Fine for me. :)

Geoff the Medio wrote:
I would avoid a star-based rating such as that because it's not clear whether ¤ and ¤¤¤ are bad and average, bad and great, average and great, or what...


At first, I wanted to use the same ratings than the species traits (--, -, +, ++, etc.). But it was a mess once displayed in the game.

What's good with a star rating is that 1 means a weak value, 5 the strongest one. 3 is somewhere in the middle. ^^

_________________
I release every updated file under the CC-BY-SA 3.0 license.


Top
 Profile  
 
 Post subject: Re: English stringtable
PostPosted: Mon Jun 20, 2016 6:05 pm 
Offline
Dyson Forest
User avatar

Joined: Wed Aug 13, 2014 7:21 pm
Posts: 213
Location: France
Just a quick suggestion:

In pedia, *Game Concepts" and *Interface* should move into **Guides**.

Currently, opening the Pedia, we have:

Code:
**Guides**
*Game Concepts*
*Interface*
Building Type
Field Type
Etc.

then

**Guides**
      *Greetings*
      *Quick Start*
      Beginner Hints


Should be:

Code:
**Guides**
Building Type
Field Type
Etc.

then

**Guides**
      **Greetings**
      **Quick Start**
      *Game Concepts*
      *Interface*
      Beginner Hints


Seems a better sorting.

Moreover, [Greetings] article has a pedia link to [Quick Start] article, and [Quick Start] article has pedia links to [Game Concepts] and [Interface].

_________________
I release every updated file under the CC-BY-SA 3.0 license.


Top
 Profile  
 
 Post subject: Re: English stringtable
PostPosted: Tue Jun 21, 2016 4:04 pm 
Offline
Creative Contributor
User avatar

Joined: Fri Jun 28, 2013 11:45 pm
Posts: 3291
I think I'm inclined to agree, it's what happens when a new part is added, existing parts probably ought to be part of the new thing but until someone notices, etc. You want to do it?

_________________
Mat Bowles

Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.


Top
 Profile  
 
 Post subject: Re: English stringtable
PostPosted: Tue Jun 21, 2016 5:24 pm 
Offline
Dyson Forest
User avatar

Joined: Wed Aug 13, 2014 7:21 pm
Posts: 213
Location: France
MatGB wrote:
You want to do it?


Well... I didn't find which file needs to be modified. :mrgreen:

As it requires to move a whole category [CATEGORY_GAME_CONCEPTS] into another one [CATEGORY_GUIDES]. Same thing for [CATEGORY_USER_INTERFACE].

That's why I posted a request. :p

_________________
I release every updated file under the CC-BY-SA 3.0 license.


Top
 Profile  
 
 Post subject: Re: English stringtable
PostPosted: Tue Jun 21, 2016 6:12 pm 
Offline
Creative Contributor
User avatar

Joined: Fri Jun 28, 2013 11:45 pm
Posts: 3291
I, um, don't know either, I've never got my head around how the Pedia is structured, there's always something new and shiny to test...

Anyone?

(I think we need a guide on how the Pedia now works and how to add stuff to it, because it needs work and it should be an easy thing to do, no coding. Should be)

_________________
Mat Bowles

Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.


Top
 Profile  
 
 Post subject: Re: English stringtable
PostPosted: Tue Jun 21, 2016 6:45 pm 
Offline
Dyson Forest
User avatar

Joined: Wed Aug 13, 2014 7:21 pm
Posts: 213
Location: France
MatGB wrote:
I, um, don't know either, I've never got my head around how the Pedia is structured, there's always something new and shiny to test...


Well, as far as I understand the Pedia structure:

- The first level is always a category, created directly in the stringtable.

Code:
CATEGORY_GUIDES
**Guides**


- The seconde level is always a link (or a list of links) to unique articles. For each article, the settings are stored in a focs.txt file and point to the keys in the stringtables.

Code:
GREETINGS.focs.txt

Article
    name = "GREETINGS_GUIDE_TITLE"                (= article title in the stringtable)
    category = "CATEGORY_GUIDES"                   (= category name in the stringtable)
    short_description = "GREETINGS_GUIDE_TITLE"
    description = "GREETINGS_GUIDE_TEXT"         (= article text in the stringtable)
    icon = "icons/FO_Icon_64x64.png"


To be displayed in the first level of the pedia, a category must have at least one article set to this category. More articles can be added to the list by specify the same category key.

The attribute "name" seems to be coded to create automatically a clickable pedia link (which displays the article itself).


- In the whole pedia, there's no third level, i.e. a category inside a category.

Quote:
because it needs work and it should be an easy thing to do, no coding. Should be


Yeah, should be... :mrgreen:

In fact, I think it would require to add a new attribute "sub_category" or something like that.

Ex:

Code:
ENVIRONMENT.focs.txt

Article
    name = "ENVIRONMENT_TITLE"
    category = "CATEGORY_GUIDES"
    sub_category = "CATEGORY_GAME_CONCEPTS"    (-> would create the category *Game Concepts" inside the category **Guides**)
    short_description = "ENVIRONMENT_TITLE"
    description = "ENVIRONMENT_TEXT"
    icon = "icons/tech/terraform.png"


_________________
I release every updated file under the CC-BY-SA 3.0 license.


Top
 Profile  
 
 Post subject: Re: English stringtable
PostPosted: Thu Jul 28, 2016 8:16 pm 
Offline
Programmer
User avatar

Joined: Fri Mar 01, 2013 9:52 am
Posts: 1040
Location: Germany
Hey there,

currently I'm trying to update the german translation. I stumbled over the following translation in the english string table, which sounds a bit off to me and maybe needs to be changed. Can some native speaker confirm this? The key of the translation in question is 'PRO_INDUSTRY_CENTER_II_DESC'.

Quote:
Improved centralized management of dispersed industrial activities increases the size of increased industrial output provided.


What do you mean with 'increases the size of increased industrial output provided'?

_________________
Resident code gremlin
Attached patches are released under GPL 2.0 or later.
Git author: Marcel Metz


Top
 Profile  
 
 Post subject: Re: English stringtable
PostPosted: Fri Jul 29, 2016 7:34 am 
Offline
Release Manager, Design
User avatar

Joined: Wed Nov 16, 2011 12:56 pm
Posts: 4288
Location: Sol III
I'm not a native speaker, but that sentence does sound weird...


Top
 Profile  
 
 Post subject: Re: English stringtable
PostPosted: Fri Jul 29, 2016 7:38 am 
Offline
Programming, Design, Admin
User avatar

Joined: Wed Oct 08, 2003 1:33 am
Posts: 12041
Location: Munich
adrian_broher wrote:
Quote:
Improved centralized management of dispersed industrial activities increases the size of increased industrial output provided.
What do you mean with 'increases the size of increased industrial output provided'?
My interpretation: The industrial centre increases the industry meter of some planets. The refinement makes the amount of that increase bigger. eg. +5 normally, +10 after the refinement.


Top
 Profile  
 
 Post subject: Re: English stringtable
PostPosted: Fri Jul 29, 2016 7:53 am 
Offline
Release Manager, Design
User avatar

Joined: Wed Nov 16, 2011 12:56 pm
Posts: 4288
Location: Sol III
Geoff the Medio wrote:
My interpretation: The industrial centre increases the industry meter of some planets. The refinement makes the amount of that increase bigger. eg. +5 normally, +10 after the refinement.
Well, wouldn't that be better phrased like that: "Improved centralized management of dispersed industrial activities which further boosts the size of increased industrial output provided."?


Top
 Profile  
 
 Post subject: Re: English stringtable
PostPosted: Fri Jul 29, 2016 8:15 am 
Offline
Programming, Design, Admin
User avatar

Joined: Wed Oct 08, 2003 1:33 am
Posts: 12041
Location: Munich
Vezzra wrote:
Geoff the Medio wrote:
My interpretation: The industrial centre increases the industry meter of some planets. The refinement makes the amount of that increase bigger. eg. +5 normally, +10 after the refinement.
Well, wouldn't that be better phrased like that: "Improved centralized management of dispersed industrial activities which further boosts the size of increased industrial output provided."?
I'd split it into two simpler sentences, like: "This makes it work better. This effect gets bigger."


Top
 Profile  
 
 Post subject: Re: English stringtable
PostPosted: Fri Jul 29, 2016 9:12 am 
Offline
Space Floater

Joined: Mon Jul 04, 2016 9:33 am
Posts: 30
Geoff the Medio wrote:
I'd split it into two simpler sentences, like: "This makes it work better. This effect gets bigger."


:lol:


Top
 Profile  
 
 Post subject: Re: English stringtable
PostPosted: Fri Jul 29, 2016 10:06 am 
Offline
Programmer
User avatar

Joined: Fri Mar 01, 2013 9:52 am
Posts: 1040
Location: Germany
Geoff the Medio wrote:
My interpretation: The industrial centre increases the industry meter of some planets. The refinement makes the amount of that increase bigger. eg. +5 normally, +10 after the refinement.


Well, you're right. Looking into the script the formula is like

Code:
planet.industry = planet.industry + (planet.population * 2 * industry_per_pop)


But I also failed to post the whole text:

Quote:
Improved centralized management of dispersed industrial activities increases the size of increased industrial output provided. The bonus to [[encyclopedia INDUSTRY_TITLE]] will be double that provided by basic [[buildingtype BLD_INDUSTRY_CENTER]]s.



Quote:
I'd split it into two simpler sentences, like: "This makes it work better. This effect gets bigger."


So the effect is already described. However the "This makes it work better" parts is still off. I like Vezzras suggestion as it removes the 'increases the increase' repetition. But I would also think that the 'the size of increased' fragment should be replaced with a 'the' like:

Quote:
Improved centralized management of dispersed industrial activities which further boosts the industrial output provided


or should should this fragment be read as a condition? Because the effect only applies on planets with industrial focus?

_________________
Resident code gremlin
Attached patches are released under GPL 2.0 or later.
Git author: Marcel Metz


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 104 posts ]  Go to page Previous  1 ... 3, 4, 5, 6, 7  Next

All times are UTC


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group