FreeOrion

Forums for the FreeOrion project
It is currently Sun Dec 17, 2017 4:20 am

All times are UTC


Forum rules


Always mention the exact version of FreeOrion you are testing.

When reporting an issue regarding the AI, if possible provide the relevant AI log file and a save game file that demonstrates the issue.



Post new topic Reply to topic  [ 15 posts ] 
Author Message
 Post subject: Issues with Latest Build
PostPosted: Mon Jan 30, 2017 5:06 pm 
Offline
Dyson Forest
User avatar

Joined: Mon Mar 02, 2015 5:57 pm
Posts: 204
I've been playing with the test builds lately. I have a windows 8 system on a Toshiba laptop. Build 2017-01-23.d3d9204 has issues with the uninstaller running after the game is installed uninstalling the new game. I've tried modding and had to re-install a few times and noticed this issue. Last night the game crashed my laptop.

_________________
All of my contributions should be considered released under creative commons attribution share-alike license, CC-BY-SA 3.0 for use in, by and with the Free Orion project.


Last edited by labgnome on Mon Jan 30, 2017 6:17 pm, edited 1 time in total.

Top
 Profile  
 
PostPosted: Mon Jan 30, 2017 5:13 pm 
Offline
Programming, Design, Admin
User avatar

Joined: Wed Oct 08, 2003 1:33 am
Posts: 12045
Location: Munich
labgnome wrote:
Last night the game crashed my laptop.
This is useless without details of when it happens/happened, steps to reproduce, or saves, log files, etc.


Top
 Profile  
 
PostPosted: Mon Jan 30, 2017 6:17 pm 
Offline
Dyson Forest
User avatar

Joined: Mon Mar 02, 2015 5:57 pm
Posts: 204
Here is what I can manage here. It keeps telling me everything else is too big.


Attachments:
File comment: here is the config file.
config.xml [25.81 KiB]
Downloaded 11 times

_________________
All of my contributions should be considered released under creative commons attribution share-alike license, CC-BY-SA 3.0 for use in, by and with the Free Orion project.
Top
 Profile  
 
PostPosted: Mon Jan 30, 2017 6:37 pm 
Offline
Programming, Design, Admin
User avatar

Joined: Wed Oct 08, 2003 1:33 am
Posts: 12045
Location: Munich
config.xml alone is not helpful. Try zipping the logs, or posting them at pastebin or a similar site. Or link to a dropbox document. Or cut out part of the log (the start probably) so just the end is left. Or describe in a post what you did to get a crash.


Top
 Profile  
 
PostPosted: Mon Jan 30, 2017 6:43 pm 
Offline
Programmer

Joined: Sun Feb 14, 2016 12:08 am
Posts: 359
Quote:
issues with the uninstaller running after the game is installed

Please clarify this, it almost sounds like the uninstaller starts up and completes on its own.
If that is not the case, knowing the issues you have with the windows installer/uninstaller would be very helpful.

_________________
Any content posted should be considered licensed GNU GPL 2.0 and/or CC-BY-SA 3.0 as appropriate.


Top
 Profile  
 
PostPosted: Mon Jan 30, 2017 7:11 pm 
Offline
Dyson Forest
User avatar

Joined: Mon Mar 02, 2015 5:57 pm
Posts: 204
dbenage-cx wrote:
Quote:
issues with the uninstaller running after the game is installed

Please clarify this, it almost sounds like the uninstaller starts up and completes on its own.
If that is not the case, knowing the issues you have with the windows installer/uninstaller would be very helpful.
I'll try to give more details. Full disclosure: this is also an "I should have payed closer attention" kind of thing.

Here is the sequence of events:
  1. I try to install the file
  2. It recommends I uninstall previous versions & I click "yes"
  3. The uninstall program begins
  4. The installation program window pops up & I start installation
  5. Installation completes.
  6. Uninstall completes, uninstalling the new build I had just tried to install.
I hadn't noticed this kind of issue before so I wanted to say something in case it's the result of something new. This even happened one time while I had the game up and running, and I thought I had correctly waited for the uninstall to complete. When my computer crashed last night I decided I should probably say something.

_________________
All of my contributions should be considered released under creative commons attribution share-alike license, CC-BY-SA 3.0 for use in, by and with the Free Orion project.


Top
 Profile  
 
PostPosted: Tue Jan 31, 2017 12:41 pm 
Offline
Release Manager, Design
User avatar

Joined: Wed Nov 16, 2011 12:56 pm
Posts: 4303
Location: Sol III
labgnome wrote:
Here is the sequence of events:
  1. I try to install the file
  2. It recommends I uninstall previous versions & I click "yes"
  3. The uninstall program begins
  4. The installation program window pops up & I start installation
  5. Installation completes.
  6. Uninstall completes, uninstalling the new build I had just tried to install.
Um, you must not start the installation (step 4) before the uninstall process has completed. Otherwise you might end up with a botched installation. So, when installing a new version: start the installer; when it detects an old version and asks if you want to uninstall that old version click "Yes", then wait until the uninstall process has completed. Only then continue with the installation of the new version.
Quote:
This even happened one time while I had the game up and running
I don't understand, what happened while you had a game up and running? I assume you didn't try to do an install/uninstall with the game up and running, did you...?


Top
 Profile  
 
PostPosted: Tue Jan 31, 2017 3:21 pm 
Offline
Dyson Forest
User avatar

Joined: Mon Mar 02, 2015 5:57 pm
Posts: 204
Vezzra wrote:
Um, you must not start the installation (step 4) before the uninstall process has completed. Otherwise you might end up with a botched installation. So, when installing a new version: start the installer; when it detects an old version and asks if you want to uninstall that old version click "Yes", then wait until the uninstall process has completed. Only then continue with the installation of the new version.
I've just never had it prompt me/pop-up to install the new version before the uninstall was complete before. It wasn't something I had to look out for until now. So I thought the issues might be connected.
Vezzra wrote:
Quote:
This even happened one time while I had the game up and running
I don't understand, what happened while you had a game up and running? I assume you didn't try to do an install/uninstall with the game up and running, did you...?
uninstalling the game. The uninstall completed while the game was running.

_________________
All of my contributions should be considered released under creative commons attribution share-alike license, CC-BY-SA 3.0 for use in, by and with the Free Orion project.


Top
 Profile  
 
PostPosted: Wed Feb 08, 2017 3:53 pm 
Offline
Release Manager, Design
User avatar

Joined: Wed Nov 16, 2011 12:56 pm
Posts: 4303
Location: Sol III
labgnome wrote:
The uninstall completed while the game was running.
Oh... ok, that means, you started the install, then confirmed the message box that asked if you wanted to uninstall the previous version, continued with the installation, which completed, then started a game, and the uninstall completed only after you had already been playing for a while...?


Top
 Profile  
 
PostPosted: Wed Feb 08, 2017 5:02 pm 
Offline
Programmer
User avatar

Joined: Fri Mar 01, 2013 9:52 am
Posts: 1040
Location: Germany
It is certainly not optimal to run both branches (uninstaller + installer) at the same time. We should prevent this by blocking the installer until the uninstaller is finished.

http://nsis.sourceforge.net/When_I_use_ ... ninstaller

Should help here.

_________________
Resident code gremlin
Attached patches are released under GPL 2.0 or later.
Git author: Marcel Metz


Top
 Profile  
 
PostPosted: Wed Feb 08, 2017 5:31 pm 
Offline
Release Manager, Design
User avatar

Joined: Wed Nov 16, 2011 12:56 pm
Posts: 4303
Location: Sol III
Yep, definitely agree.


Top
 Profile  
 
PostPosted: Wed Feb 08, 2017 8:37 pm 
Offline
Programmer

Joined: Sun Feb 14, 2016 12:08 am
Posts: 359
Thanks to https://nsis-dev.github.io/NSIS-Forums/ ... 79035.html this works:

Code:
uninst_onInit:
ClearErrors
InitPluginsDir
CopyFiles "$R0" "$pluginsdir"
ExecWait '$pluginsdir\Uninstall.exe _?=$pluginsdir'
fin_onInit:


Anyone know a way to separate the filename from a registry string($R0) in this context?
Using the filename from registry would help in case of later changes (e.g. using a batch file)

_________________
Any content posted should be considered licensed GNU GPL 2.0 and/or CC-BY-SA 3.0 as appropriate.


Top
 Profile  
 
PostPosted: Thu Feb 09, 2017 12:03 pm 
Offline
Release Manager, Design
User avatar

Joined: Wed Nov 16, 2011 12:56 pm
Posts: 4303
Location: Sol III
dbenage-cx wrote:
Code:
uninst_onInit:
ClearErrors
InitPluginsDir
CopyFiles "$R0" "$pluginsdir"
ExecWait '$pluginsdir\Uninstall.exe _?=$pluginsdir'
fin_onInit:
That does not work at all... when I change the NSIS installer script as suggested here, the installer indeed paused until the uninstaller completes, however, apparently other than removing the uninstaller registry key the uninstaller doesn't do anything, it exits practically immediately, and the FO installation remains apparently untouched.

The solution suggestion Marcel linked to works far better, but still not entirely satisfactorily. The old FO installation is almost completely removed - the FreeOrion folder itself in the Windows programs directory and the uninstall.exe within don't get deleted. Which shouldn't be a big issue since usually the new installation should overwrite these leftovers immediately afterwards, but still, it's not perfect (e.g. when a user decides put the new installation into a different location).

So I put up a PR with a fix that more or less follows that solution with request for reviews/opinions/objections:

https://github.com/freeorion/freeorion/pull/1299


Top
 Profile  
 
PostPosted: Thu Feb 09, 2017 12:22 pm 
Offline
Programmer

Joined: Sun Feb 14, 2016 12:08 am
Posts: 359
Doh :/
"_?=" Is an argument to the uninstaller and should be the installation directory, not $pluginsdir.

The issue with this approach is separating the filename from the directory name, as the previous versions stored the one value.


Top
 Profile  
 
PostPosted: Thu Feb 09, 2017 4:53 pm 
Offline
Release Manager, Design
User avatar

Joined: Wed Nov 16, 2011 12:56 pm
Posts: 4303
Location: Sol III
dbenage-cx wrote:
The issue with this approach is separating the filename from the directory name, as the previous versions stored the one value.
As the filename of the uninstaller executable hasn't been changed since the dawn of time, I consider this issue a very minor one. Certainly less serious than the problem with the installer continuing before the uninstaller completes.

So I updated my PR with the approach you suggested here, rebased and merged it. Once someone comes up with a proper solution for separating filename from directory name, we can commit that fix then.

@labgnome, things should work smoothly for you now. :)


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 15 posts ] 

All times are UTC


Who is online

Users browsing this forum: AhrefsBot and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
cron
Powered by phpBB® Forum Software © phpBB Group