FreeOrion

It seems I am now unable to run a multiplayer game with myself set as either moderator or as observer (plus 1 or 2 AIs)-- the game just sits there with the multiplayer setup screen still showing, and does nothing. I am not seeing anything helpful in the logs (just some seemingly fairly typical lines about invalid TurnProgress event for current state of FSM). I tried a number of different commits, going back about a month in the code, to commit 622177367912b9dd982119511d0110815fd8126c, but still the same problem. Starting a single player game or a multiplayer game with me as a regular player works fine.

Before putting more time into looking into this or opening an issue I wanted to see if anyone else has the same trouble.

Looks like part of the code in NewGameInitVerifyJoiners

https://github.com/freeorion/freeorion/ ... p.cpp#L732

assumes no non-empire-controlling player types, or at least that the host controls an empire?
Maybe related to https://github.com/freeorion/freeorion/ ... daa98660d1

Edit: https://github.com/freeorion/freeorion/ ... d7a3d681f2 hopefully resolves it, at least temporarily. A more careful reconsideration of the relevant checks might be good.

That is my bug.

I never tested the case of a non-empire controlling host.

Thanks for fixing it.