FreeOrion
http://www.freeorion.org/forum/

[Nov. 20 test build (e6848d8)] Missing info on tech hover
http://www.freeorion.org/forum/viewtopic.php?f=28&t=10794
Page 1 of 2

Author:  alleryn [ Fri Nov 24, 2017 8:32 pm ]
Post subject:  [Nov. 20 test build (e6848d8)] Missing info on tech hover

Am i imagining things? When you hover the mouse pointer over a tech, a box pops up with the tech's icon.

I believe that in the latest official release (0.4.7.1) this box displayed info like "Theoretical Prerequisite", "Unlocks Building", etc. Has this info disappeared from those boxes? When i hover i now just get the icon on the left and an empty box.

Author:  Geoff the Medio [ Fri Nov 24, 2017 8:58 pm ]
Post subject:  Re: [Nov. 20 test build (e6848d8)] Missing info on tech hove

I see the same issue. Don't see the problem in the code though...

The BrowseWnd is being constructed with the appropriate text passed in, but it's just not being rendered for some reason.

Author:  alleryn [ Fri Nov 24, 2017 10:03 pm ]
Post subject:  Re: [Nov. 20 test build (e6848d8)] Missing info on tech hove

Would it have anything to do with GG/src/ListBox.cpp ? I'm not sure if this is a relevant file, but i'm seeing a number of changes to it since the official release version (139ffd9). (I remember it working in 139ffd9, haven't played any versions between these two). This is where my nose is pointing me right now.

Here's a link to the comparison between e6848d8 and 139ffd9 if that's helpful to anyone:
https://github.com/freeorion/freeorion/ ... ...139ffd9


Oh.. i had the numbers or codes or whatever backwards... there's way more changes than i thought, haha.
https://github.com/freeorion/freeorion/ ... ...e6848d8

Author:  Dilvish [ Sat Nov 25, 2017 12:21 am ]
Post subject:  Re: [Nov. 20 test build (e6848d8)] Missing info on tech hove

The tech tooltips are still working fine for me on Linux, as of just a few commits ago at least.

Author:  alleryn [ Sat Nov 25, 2017 6:59 am ]
Post subject:  Re: [Nov. 20 test build (e6848d8)] Missing info on tech hove

Just reporting in that i compiled a more recent build [build 2017-11-24.f5304af] and the tech hover box still appears empty on my (windows 10) machine.

Author:  Geoff the Medio [ Sat Nov 25, 2017 10:30 am ]
Post subject:  Re: [Nov. 20 test build (e6848d8)] Missing info on tech hove

It would be helpful if you can narrow down or determine the build or revision that broke them for you.

Edit: does not work for me in d21aa97

Author:  alleryn [ Sat Nov 25, 2017 3:52 pm ]
Post subject:  Re: [Nov. 20 test build (e6848d8)] Missing info on tech hove

Geoff the Medio wrote:
It would be helpful if you can narrow down or determine the build or revision that broke them for you.

Edit: does not work for me in d21aa97

On it.

Author:  alleryn [ Sat Nov 25, 2017 4:59 pm ]
Post subject:  Re: [Nov. 20 test build (e6848d8)] Missing info on tech hove

I narrowed it down using the sourceforge installers.

Working: 139ffd9 (Sept. 3 -- this is the 0.4.7.1 release build). Also works in an earlier test build (the last one before the release candidates) 4e12b03 (Aug. 24)
Not working: 8ee7fb7 (Sept. 4)

For me to narrow it down to a more precise commit, i think i'm going to first need to figure out how to use git.

Author:  dbenage-cx [ Sat Nov 25, 2017 8:51 pm ]
Post subject:  Re: [Nov. 20 test build (e6848d8)] Missing info on tech hove

Same as Dilvish here, I do not see any issue.

If you are up to narrowing it further, git bisect would be the tool/feature to use.

Could someone affected open an issue? Preferably with a screen shot if possible.

Author:  alleryn [ Sun Nov 26, 2017 12:34 am ]
Post subject:  Re: [Nov. 20 test build (e6848d8)] Missing info on tech hove

dbenage-cx wrote:
Could someone affected open an issue? Preferably with a screen shot if possible.

Done. https://github.com/freeorion/freeorion/issues/1878

Author:  dbenage-cx [ Sun Nov 26, 2017 2:30 am ]
Post subject:  Re: [Nov. 20 test build (e6848d8)] Missing info on tech hove

Appreciate the detailed report alleryn, thankfully it was the first guess.
Fixed in cbf1e48

Author:  alleryn [ Sun Nov 26, 2017 2:38 am ]
Post subject:  Re: [Nov. 20 test build (e6848d8)] Missing info on tech hove

dbenage-cx wrote:
Appreciate the detailed report alleryn, thankfully it was the first guess.
Fixed in cbf1e48

Thanks!

Author:  alleryn [ Sun Nov 26, 2017 3:15 am ]
Post subject:  Re: [Nov. 20 test build (e6848d8)] Missing info on tech hove

Out of curiosity, any explanation for why windows can't handle the unicode properly while linux can? (If that's the difference between where it was working and where it wasn't).

Author:  dbenage-cx [ Sun Nov 26, 2017 5:34 pm ]
Post subject:  Re: [Nov. 20 test build (e6848d8)] Missing info on tech hove

I can not test to be certain, I believe MSVC is encoding it in CP1252, the equivalent would have been 0x96.
The answer on this SO question has a more detailed explanation, if that is the case.
En dash is probably the "proper" character to use for the separation (or em dash, depending on interpretation), but did not feel it warranted compiler specific handling when the difference with hyphen-minus is not likely to be noticed.

Author:  Geoff the Medio [ Sun Nov 26, 2017 6:13 pm ]
Post subject:  Re: [Nov. 20 test build (e6848d8)] Missing info on tech hove

dbenage-cx wrote:
...did not feel it warranted compiler specific handling when the difference with hyphen-minus is not likely to be noticed.
What's wrong with
Code:
u8" \u2013 "

Page 1 of 2 All times are UTC
Powered by phpBB® Forum Software © phpBB Group
https://www.phpbb.com/