SVN 6411 - self-compiled

Describe your experience with the latest version of FreeOrion to help us improve it.

Moderator: Oberlus

Forum rules
Always mention the exact version of FreeOrion you are testing.

When reporting an issue regarding the AI, if possible provide the relevant AI log file and a save game file that demonstrates the issue.
Message
Author
User avatar
adrian_broher
Programmer
Posts: 1156
Joined: Fri Mar 01, 2013 9:52 am
Location: Germany

Re: SVN 6411 - self-compiled

#31 Post by adrian_broher »

Geoff the Medio wrote:Apparently it spends a disturbingly large amount of time in Condition::PlanetType::TargetInvariant?
Where did you get that from?

From the amount of function calls, the call tree summary and the caller callee summary the 'FleetFromObject(class TemporaryPtr<class UniverseObject const >)' with a whooping sample percentage of 96.5% seems to be the far worst offender.
Resident code gremlin
Attached patches are released under GPL 2.0 or later.
Git author: Marcel Metz

User avatar
Geoff the Medio
Programming, Design, Admin
Posts: 13587
Joined: Wed Oct 08, 2003 1:33 am
Location: Munich

Re: SVN 6411 - self-compiled

#32 Post by Geoff the Medio »

Both the "Function Summary" and "CallTreeSummary" files, sorted by Inclusive Samples, have Function Name "Condition::PlanetType::TargetInvariant(void)const" at the top.

What the difference is between inclusive and exclusive samples, I don't know.

User avatar
adrian_broher
Programmer
Posts: 1156
Joined: Fri Mar 01, 2013 9:52 am
Location: Germany

Re: SVN 6411 - self-compiled

#33 Post by adrian_broher »

Geoff the Medio wrote:What the difference is between inclusive and exclusive samples, I don't know.
http://msdn.microsoft.com/en-us/library/ms242753.aspx

Inclusive is thet target function itself + recursively all functions called by the target function.
Exclusive is the target function itself.
Resident code gremlin
Attached patches are released under GPL 2.0 or later.
Git author: Marcel Metz

User avatar
Geoff the Medio
Programming, Design, Admin
Posts: 13587
Joined: Wed Oct 08, 2003 1:33 am
Location: Munich

Re: SVN 6411 - self-compiled

#34 Post by Geoff the Medio »

Then it's probably a symbol lookup error. I doubt it's actually spending about 92% of its time within functions called from within PlanetType::TargetInvariant. Although if it is, it's a strong case for result caching.

Post Reply