FreeOrion

Forums for the FreeOrion project
It is currently Tue Apr 24, 2018 3:03 am

All times are UTC




Post new topic Reply to topic  [ 28 posts ]  Go to page Previous  1, 2
Author Message
 Post subject: Re: 0.4.8 roadmap
PostPosted: Sat Dec 23, 2017 6:03 pm 
Offline
AI Lead, Programmer
User avatar

Joined: Sat Sep 22, 2012 6:25 pm
Posts: 4562
Hi, guys, I am freed up a bit more for the next week, will try to catch up on things and make some progress on the issues I was working on.

Quote:
Move everything left in "postponed" back to "optional".
Wouldn't that reset the timestamps, and actually make all those previously postponed (presumably because of being lower priority) items appear newer (and therefore relatively higher priority) than the items that had been labeled "optional" all along?

If I am understanding that correctly, it seems to me that it is best to stick with a pair of labels (for the non version-mandatory items) that essentially connote "high-priority optional" and "low-priority optional", and that it would be pretty typical that those labels would not change over the life of the item (though of course promotions/demotions between those two or to/from version-mandatory could be possible). Using the previously proposed "optional" and "wishlist" labels for that purpose sounds fine to me.

_________________
If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0


Top
 Profile  
 
 Post subject: Re: 0.4.8 roadmap
PostPosted: Mon Mar 12, 2018 5:56 pm 
Offline
Dyson Forest

Joined: Tue Mar 24, 2015 12:58 am
Posts: 231
I made a suggestion, was told it was trivial (it was) but that taking trivial time for all trivial suggestions would put off the good stuff too long.
Cool.
It was further suggested to me that if I wanted to have that feature (in this case a slider on the bottom for the planets-race-owner screen) that I should program it myself.
I have not professionally programmed since 2002. But I could, programming cookbook in hand, make this change, I bet.
If I went to the trouble, would you accept such? Non of the stuff I would like would be anything but likely small stuff, not on your agenda.

I found this, thanks.
It seems you all will accept contributions from beginners to your language sets.
viewtopic.php?f=4&t=10259


Top
 Profile  
 
 Post subject: Re: 0.4.8 roadmap
PostPosted: Mon Mar 12, 2018 7:15 pm 
Offline
Release Manager, Design
User avatar

Joined: Wed Nov 16, 2011 12:56 pm
Posts: 4457
Location: Sol III
Slightly off-topic here, but anyway:
godel wrote:
If I went to the trouble, would you accept such? Non of the stuff I would like would be anything but likely small stuff, not on your agenda.
If you're working on stuff that's already on the todo list, but just low priority, and/or have a confirmation from the devs that we plan to do the stuff in question eventually, you can probably just start working (depending what it is).

For stuff that you came up with because you think it would be a good addition/enhancement to the game, or stuff that has been floating around only as vague ideas, you should open a thread describing your idea, so we can discuss it first. Some things might seem good/reasonable to you, but there is always a chance that not everyone shares that view. ;) Or you might get suggestions for changes to your idea, that you didn't think of. Better to clear all that up in a discussion before you start implementing and potentially waste time and effort.


Top
 Profile  
 
 Post subject: Re: 0.4.8 roadmap
PostPosted: Wed Mar 14, 2018 4:42 am 
Offline
Dyson Forest

Joined: Tue Mar 24, 2015 12:58 am
Posts: 231
Thanks.
Much on my mind but few that I feel confident that I could actually accomplish.
Back on this soon.


Top
 Profile  
 
 Post subject: Re: 0.4.8 roadmap
PostPosted: Wed Mar 14, 2018 9:55 am 
Offline
Programming, Design, Admin
User avatar

Joined: Wed Oct 08, 2003 1:33 am
Posts: 12171
Location: Munich
Given the recent issues with a refactoring change, is it perhaps worth making a v0.4.8 branch soon, and limiting it to release-blocking or at least reasonably well-tested non-blocking issues? I think the release is being delayed by such distractions...


Top
 Profile  
 
 Post subject: Re: 0.4.8 roadmap
PostPosted: Sun Mar 18, 2018 2:31 pm 
Offline
Space Dragon

Joined: Tue Sep 30, 2014 10:01 am
Posts: 409
Geoff the Medio wrote:
Given the recent issues with a refactoring change, is it perhaps worth making a v0.4.8 branch soon, and limiting it to release-blocking or at least reasonably well-tested non-blocking issues? I think the release is being delayed by such distractions...

+1

Does somebody lead the release process? I would certainly want to go at least into "feature freeze" now. If that means locking master or setting up a 0.4.8 branch I do not really care. Both would be fine.

_________________
Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.


Top
 Profile  
 
 Post subject: Re: 0.4.8 roadmap
PostPosted: Sun Mar 18, 2018 6:21 pm 
Offline
Release Manager, Design
User avatar

Joined: Wed Nov 16, 2011 12:56 pm
Posts: 4457
Location: Sol III
Geoff the Medio wrote:
Given the recent issues with a refactoring change, is it perhaps worth making a v0.4.8 branch soon, and limiting it to release-blocking or at least reasonably well-tested non-blocking issues?
It doesn't make much sense to me to create the release branch as long as the main feature of this release is still being worked on. For one there is still one release blocking PR related to said main feature, and then my impression is that there should be a bit more playtesting of the new feature, or at least playtesting by more people. Although Oberlus has been very diligent in that area, and a couple of others seem to have done a fair share of playtesting too, I'm a bit unsure if it has been sufficient for a completely new mechanic that introduced a significant change to another core mechanic, obviously caused significant balance issues that had to be ironed out, etc.

Unfortunately I didn't get around to do some decent playtesting myself, I always hoped I'd find the time, and never managed to. So I need to rely on the assessment of those involved with developing, playtesting, balancing and polishing the IS so far: do you guys think the feature is ready for release?

The other thing is, usually I wait until all release blocking issues are dealt with, for the simple reason to minimize the cherry picking ordeal that always commences the moment I create the release branch. If there is still stuff that needs to be done, that means the release branch needs to be maintained that much longer, which is particularly annoying with all the bugfixing that happens all the time. The longer it takes from the time the release branch is created until the release is finally out, the longer people already work on new stuff in master. Which introduces new bugs, which get fixed, and every time that happens someone has to pay attention if a bugfix fixes something that has been introduced after the creation of the release branch (and therefore must not get cherry picked into the release branch) or an older bug that has already been present before (and there must get cherry picked into the release branch).

Often enough the cherry picking is also left to me, which gets particularly tricky if there are conflicts to resolve. Difficult for me who hasn't written the code, and isn't the most competent coder around here to begin with.
Quote:
I think the release is being delayed by such distractions...
Compared to the hassle maintaining the release branch for longer than absolutely necessary these issues you refer to look rather minor to me. Those bugs have been dealt with quickly enough, and haven't actually caused any delays (yet).

Of course, that said, I completely agree people should refrain from working on optional or new stuff for now and concentrate their efforts on cleaning up the remaining release blocking issues. Some items on the "0.4.8 (mandatory)" list have been sitting there for months, with no sign of anyone intending to touch them. If I create the release branch now, who knows how long it will take until those get solved?


Top
 Profile  
 
 Post subject: Re: 0.4.8 roadmap
PostPosted: Sun Mar 18, 2018 6:39 pm 
Offline
Release Manager, Design
User avatar

Joined: Wed Nov 16, 2011 12:56 pm
Posts: 4457
Location: Sol III
Ophiuchus wrote:
Does somebody lead the release process?
That would be me. Hence my forum title "Release Manager". ;)
Quote:
I would certainly want to go at least into "feature freeze" now.
Well, we don't have something like that, at least not as strictly as other projects do. "Feature freeze" more or less happens when the release branch gets created, as usually only bugfixes get cherry picked into the release branch, not new features (of course, there can be the odd exceptions to that rule, but we try to avoid that for obvious reasons).

See my post above why that hasn't happened yet (besides me having been busy and not having much time for FO lately).

Another thing about something akin to a "feature freeze", let me quote myself (from a former post in this thread):
Vezzra wrote:
Second, there are the issues and PRs mandatory for 0.4.8. I urge all our (active) devs to give those priority now, so we can clear that list. We can't proceed with the release until every item on that list has been finished.
Of course, once it became clear that the IS feature would take more time than originally planned, people probably started on other stuff in the meantime. But it looks like the IS is getting closer to release ready finally, so I want to reinforce that statement:

Please, everyone, start prioritizing the release again, that is, concentrate your efforts on the remaining release blocking issues/PRs! And on giving the IS feature some final polishing! So we can get on with 0.4.8. :D


Top
 Profile  
 
 Post subject: Re: 0.4.8 roadmap
PostPosted: Mon Mar 19, 2018 2:19 pm 
Offline
Space Dragon

Joined: Tue Sep 30, 2014 10:01 am
Posts: 409
Vezzra wrote:
Ophiuchus wrote:
Does somebody lead the release process?
That would be me. Hence my forum title "Release Manager". ;)
:)

Vezzra wrote:
"Feature freeze" more or less happens when the release branch gets created, as usually only bugfixes get cherry picked into the release branch, not new features (of course, there can be the odd exceptions to that rule, but we try to avoid that for obvious reasons).

Thanks for the clarifications. I totally get we should minimize unnecessary merging. What I meant with locking the master for feature freeze is (announcing that you are) not accepting any pull requests with new features. So only 0.4.8 mandatory (and maybe 0.4.8 optionals) and bugfixes. Is that an option?

Vezzra wrote:
Please, everyone, start prioritizing the release again, that is, concentrate your efforts on the remaining release blocking issues/PRs! And on giving the IS feature some final polishing! So we can get on with 0.4.8. :D

I'm in ;)

_________________
Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.


Top
 Profile  
 
 Post subject: Re: 0.4.8 roadmap
PostPosted: Mon Mar 19, 2018 5:54 pm 
Offline
Programmer
User avatar

Joined: Fri Mar 01, 2013 9:52 am
Posts: 1058
Location: Germany
Ophiuchus wrote:
I totally get we should minimize unnecessary merging. What I meant with locking the master for feature freeze is (announcing that you are) not accepting any pull requests with new features. So only 0.4.8 mandatory (and maybe 0.4.8 optionals) and bugfixes. Is that an option?


No, do your release feature freeze thingies on a release branch and leave master alone.

_________________
Resident code gremlin
Attached patches are released under GPL 2.0 or later.
Git author: Marcel Metz


Top
 Profile  
 
 Post subject: Re: 0.4.8 roadmap
PostPosted: Tue Mar 20, 2018 3:07 pm 
Offline
Space Dragon

Joined: Tue Sep 30, 2014 10:01 am
Posts: 409
adrian_broher wrote:
Ophiuchus wrote:
I totally get we should minimize unnecessary merging. What I meant with locking the master for feature freeze is (announcing that you are) not accepting any pull requests with new features. So only 0.4.8 mandatory (and maybe 0.4.8 optionals) and bugfixes. Is that an option?


No, do your release feature freeze thingies on a release branch and leave master alone.

Meh :(

_________________
Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.


Top
 Profile  
 
 Post subject: Re: 0.4.8 roadmap
PostPosted: Thu Mar 22, 2018 1:04 pm 
Offline
Release Manager, Design
User avatar

Joined: Wed Nov 16, 2011 12:56 pm
Posts: 4457
Location: Sol III
Ophiuchus wrote:
What I meant with locking the master for feature freeze is (announcing that you are) not accepting any pull requests with new features. So only 0.4.8 mandatory (and maybe 0.4.8 optionals) and bugfixes. Is that an option?
Not really. I do understand the sentiment, and while I have to admit that I'm tempted myself at times to do something drastic like this (when I see people happily working on features and optional stuff while release blocking things hang for months), the very idea to work with release branches is to avoid exactly that: block ongoing development in master.

Creating the release branch is actually the "feature freeze" you're asking for, but it doesn't make much sense to do that "feature freeze" as long as the main feature of the release is still worked on. While it looks like we might be able to wrap that up soon, we aren't there yet. Getting the last PRs for the IS merged would be a big step, and then some more playtesting feedback.

Which brings me to the the question I already made a few posts above: Do you guys think the IS feature is ready for release? The responses haven't exactly been overwhelming so far, which isn't very encouraging... ;)


Top
 Profile  
 
 Post subject: Re: 0.4.8 roadmap
PostPosted: Thu Mar 22, 2018 1:12 pm 
Offline
Release Manager, Design
User avatar

Joined: Wed Nov 16, 2011 12:56 pm
Posts: 4457
Location: Sol III
Ophiuchus wrote:
Meh :(
Now, don't be discouraged :D The stuff happening in master hasn't caused any delays so far, it's the IS feature still being worked on that's the big roadblock right now. Once that's done, clear the last release blocking issues, and we are good to go.


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 28 posts ]  Go to page Previous  1, 2

All times are UTC


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
cron
Powered by phpBB® Forum Software © phpBB Group