FreeOrion

Forums for the FreeOrion project
It is currently Mon Jul 23, 2018 5:06 pm

All times are UTC




Post new topic Reply to topic  [ 88 posts ]  Go to page Previous  1, 2, 3, 4, 5, 6  Next
Author Message
 Post subject: Re: 0.4.8 roadmap
PostPosted: Thu May 10, 2018 4:29 pm 
Offline
Space Kraken

Joined: Sat Dec 10, 2011 5:46 am
Posts: 135
Vezzra wrote:
Any of the issues/PRs on the mandatory list we can reassign to optional? Or maybe the other way round: which of these issues/PRs do you consider absolutely necessary for the release? Please, everyone, give your feedback!


I suppose any backward or forward compatibility breakers should be considered as a mandatory, other server-only (AI) or client-only (UI) issues could be postponed to bugfix release within 0.4.8 branch.

_________________
Gentoo Linux x64, gcc-7.3, boost-1.65.0
Ubuntu Server 18.04 x64, gcc-7.3, boost-1.65.1
Welcome to multiplayer server at freeorion-test.dedyn.io.Version 2018-07-13.9a06376 0.4.8 RC2
Donates are welcome: BTC:14XLekD9ifwqLtZX4iteepvbLQNYVG87zK


Top
 Profile  
 
 Post subject: Re: 0.4.8 roadmap
PostPosted: Thu May 10, 2018 10:23 pm 
Offline
AI Lead, Programmer
User avatar

Joined: Sat Sep 22, 2012 6:25 pm
Posts: 4683
I've revised #2009 (about sanitizing and better commenting the AI uses of currentMeter vs initialMeter) to be optional, since I am pretty sure that the most important changes identified there have already been done.

I am also putting some more time into #1794 (about an AI error message that sometimes pops up on savegame load) The AI already recovers fairly cleanly from that error situation, but we have it still visibly flagging the error because we're still puzzled about just how the error situation comes about (and whether the underlying cause is also leading to other problems which haven't made themselves apparent), and we want to avoid out-of-sight-out-of-mind. If I don't get it resolved fairly soon, then we could change the logging to be warn level rather than error level, so that it does not trigger an in-game message about the problem, and then downgrade the Issue to optional rather than mandatory.

While working on #1794 today I came across another issue that was triggering an in-game AI error message about ShipDesign cache corruption after game load. There was already some related cleanup being done with logging just at the warn level, but the cleanup had not been quite thorough enough to always prevent the problem later triggering an error message. I'm about to submit a PR that adds some more cleanup and resolves the error message, but I'm also going to submit an optional-grade Issue for the underlying cache corruption issue the warning is for, because just like with #1794 if we wind up with a lingering underlying error that we simply recover smoothly from but don't really fully resolve then I think we should keep an outstanding Issue open for it.

_________________
If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0


Top
 Profile  
 
 Post subject: Re: 0.4.8 roadmap
PostPosted: Mon May 14, 2018 7:25 pm 
Offline
Release Manager, Design
User avatar

Joined: Wed Nov 16, 2011 12:56 pm
Posts: 4594
Location: Sol III
Ok, we are down to 2 release-blocking issues, one of which (#1794) can be reassigned to optional after applying some stop-gap fixes to the release branch (as suggested by Dilvish), and the other one, while it needs to be addressed, isn't so serious that it should block the creation of the release branch.

Which means, unless something unexpected turns up or someone objects, I think we can finally proceed with that.

Deadline is coming Sunday, May 20th, 6pm UTC.

That should give everyone a few days time to think things over, if there is anything we might have overlooked that should/needs to be done before, or to raise any objections. If nothing comes up, and no one objects until then, I will proceed with the creation of the release branch.


Top
 Profile  
 
 Post subject: Re: 0.4.8 roadmap
PostPosted: Fri May 18, 2018 3:47 pm 
Offline
Release Manager, Design
User avatar

Joined: Wed Nov 16, 2011 12:56 pm
Posts: 4594
Location: Sol III
I've opened the "management issue" for the 0.4.8 release.

Despite the issues/PRs that have been added to the mandatory milestone in the meantime, I'm still aiming for the May 20th deadline for the creation of the release branch, as those don't seem serious enough for me to postpone that. If anyone objects, please do so in time, otherwise I'll proceed as planned.


Top
 Profile  
 
 Post subject: Re: 0.4.8 roadmap
PostPosted: Sat May 19, 2018 7:21 pm 
Offline
Release Manager, Design
User avatar

Joined: Wed Nov 16, 2011 12:56 pm
Posts: 4594
Location: Sol III
Just a heads-up: I have to be at an unplanned appointment tomorrow evening, meaning, creation of the release branch might/will be delayed until probably very late into the evening. Worst case I'll only be able to get around to it on Monday.

However, the deadline will be left as it is, so please, don't count on the delay. :wink:


Top
 Profile  
 
 Post subject: Re: 0.4.8 roadmap
PostPosted: Sun May 20, 2018 7:58 pm 
Offline
Release Manager, Design
User avatar

Joined: Wed Nov 16, 2011 12:56 pm
Posts: 4594
Location: Sol III
The release branch for 0.4.8 has been created.

Attention: from this point on, the commits of PRs that are assigned to the mandatory milestone need to be cherry picked to the release branch once they have been merged. To help manage this, please tag those PRs accordingly with the "status:cherry pick for release" label. The same applies to PRs assigned to the optional milestone which fix bugs that have been present in master prior to the creation of the release branch.

All other PRs (those that are neither assigned to the mandatory milestone nor fix bugs that have been present in master prior to the creation of the release branch) should not be cherry picked to the release branch. The only things happening on the release branch are incorporating changes/features which are required for the release, bugfixes, and prep work for the release (like updating the changelog). No new (optional) features, to avoid introducing bugs which then need to be fixed.

If someone thinks there is something for wich we should make an exception to these rules, please post a proposal here in this thread and explain why you think it should be incorporated into the release.

Another thing I ran into when I created the release branch: we used to remove the Super Testers from the release branch. However, as they can be controlled by a game rule now, this raises the question if that's still necessary. IMO it would be sufficient to switch the default for the game rule from On to Off. That would give players who only use stable releases the possibility to enable the Super Testers, if they are so inclined.

Opinions, objections?


Top
 Profile  
 
 Post subject: Re: 0.4.8 roadmap
PostPosted: Sun May 20, 2018 8:42 pm 
Offline
Programming, Design, Admin
User avatar

Joined: Wed Oct 08, 2003 1:33 am
Posts: 12237
Location: Munich
Vezzra wrote:
IMO it would be sufficient to switch the default for the game rule [for Super Testers] from On to Off.
Sounds reasonable.


Top
 Profile  
 
 Post subject: Re: 0.4.8 roadmap
PostPosted: Mon May 21, 2018 3:12 pm 
Offline
Release Manager, Design
User avatar

Joined: Wed Nov 16, 2011 12:56 pm
Posts: 4594
Location: Sol III
As some things (applies primarily to some bugfixes) are committed directly to master without being provided as PR first, I've created a github project to manage the commits which need to/shall be cherry picked to the release branch. Both PRs and commits that went directly into master shall be managed there.

The "Proposed" column contains entries for all PRs/commits which have been suggested for cherry picking (or need to be cherry picked), but haven't been so far. The "Accepted" column contains the entries of PRs/commits that already have been cherry picked, and the "Rejected" column is for the unlikely case of PRs/commits that have been rejected for inclusion into the release (can only happen for things that have been proposed for cherry picking although they are neither considered mandatory for the release nor fixes for bugs present in master prior to the creation of the release branch).

Proceed as follows:

  • If you have a PR that shall be cherry picked to the release branch, add it to the "Proposed" column (in addition to tagging it as "cherry pick for release" as already explained in a prior post above). If the PR is one of those that need discussion and approval first (because neither mandatory nor bugfix), check the "Rejected" column first if it has already been proposed and rejected before. If not, go ahead and add it, and also post the proposal here in this thread with an explanation why you think it should be included in the release (this too has already been covered by an earlier post above).
  • If you have something that has been committed directly to master which shall be cherry picked to the release branch, you need to create a respective entry in the "Proposed" column manually, which should contain a link/links to the commit/commits in question. If it is something that needs discussion first, see the above point about PRs.
  • Unless the PR/commit(s) gets rejected, someone will get around to cherry pick the respective commit(s) to the release branch (which will be me in most cases, I guess, but anyway). That person also needs to move the respective entry from the "Proposed" column to the "Accepted" column. In case of a PR, the "cherry pick for release" label needs to be removed (to indicate that the cherry picking has already been done).
  • If (a) proposed PR/commit(s) is/are rejected from inclusion into the release, the corresponding entry needs to be moved to the "Rejected" column. In case of a PR, the "cherry pick for release" label needs to be removed (to indicate that no cherry picking should be done). Keeping track of rejected entries for cherry picking is just a means to make sure some things don't get suggested multiple times. Probably overkill, as this case should be so rare that we won't loose track of what has already been proposed and what hasn't, but still. Better safe than sorry. ;)


Top
 Profile  
 
 Post subject: Re: 0.4.8 roadmap
PostPosted: Thu May 24, 2018 3:08 am 
Offline
AI Lead, Programmer
User avatar

Joined: Sat Sep 22, 2012 6:25 pm
Posts: 4683
I think we should cherry pick PR #2102 (by default prevents AI from redoing orders for a turn right after savegame load) for 0.4.8. Although we've downgraded #1794 (about the AI key error after savegame load) to optional after changing the related logging to warn level for the 0.4.8 branch, there is still some underlying bugginess going on, and the changes of this PR should make it so that by default those are at least reduced (and perhaps avoided entirely).

_________________
If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0


Top
 Profile  
 
 Post subject: Re: 0.4.8 roadmap
PostPosted: Sun May 27, 2018 3:21 pm 
Offline
Release Manager, Design
User avatar

Joined: Wed Nov 16, 2011 12:56 pm
Posts: 4594
Location: Sol III
Something I forgot to mention: all stuff that has been on hold because it shouldn't go in for 0.4.8 can be merged/comitted to master now that the release branch has been created. Which means, "post 0.4.8" PRs can be merged if they are ready.


Top
 Profile  
 
 Post subject: Re: 0.4.8 roadmap
PostPosted: Tue Jun 05, 2018 7:39 pm 
Offline
Programmer
User avatar

Joined: Fri Mar 01, 2013 9:52 am
Posts: 1072
Location: Germany
Vezzra, what about issues labeled with 'category:feature' or 'category:tweak' within the 'v0.4.8 (optional)' milestone? Can we mass reassign those to the 'post v0.4.8' milestone? Maybe there are some relevant and simple bugs in the optional milestone that can be fixed without much of a hassle, but I don't want to sift through the vast amount of issues just to pick the nice and easy ones.

_________________
Resident code gremlin
Attached patches are released under GPL 2.0 or later.
Git author: Marcel Metz


Top
 Profile  
 
 Post subject: Re: 0.4.8 roadmap
PostPosted: Wed Jun 06, 2018 8:31 am 
Offline
Vacuum Dragon

Joined: Tue Sep 30, 2014 10:01 am
Posts: 505
I also have a question about the Fulver species which should facilitate an aggressive non-distributed strategy using the stockpile (GOOD _stockpile _weapons).

I can see some options for them
  • go into 0.4.8 and master - because hey, its the stockpile release and they are stockpile users
  • go into 0.4.8 only - special feature for the 0.4.8 release
  • go into master ASAP - so they are in the test builds and can mature there
if they go to into master and they are not good for the species mix or turn out to be game breaking or boring - we could kick them out or make them native before the next release.

In hindsight i should have added something like the Fulver in the stockpile design phase. As we probably will tweak stockpile growth and tech in the coming iteration, i would definitly like to have them for that purpose. (and i hope i'll be able to add sth to AI)

i personally would prefer them to be in the 0.4.8 release also, but maybe they are not ready for prime time.

p.s: for influence we should probably also have good, bad, great _influence playable species avaliable from the start to get a feeling for the effects.

_________________
Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.


Top
 Profile  
 
 Post subject: Re: 0.4.8 roadmap
PostPosted: Wed Jun 06, 2018 9:57 am 
Offline
Programming, Design, Admin
User avatar

Joined: Wed Oct 08, 2003 1:33 am
Posts: 12237
Location: Munich
Given lack of testing / novelty, I'd put new species into master for now.


Top
 Profile  
 
 Post subject: Re: 0.4.8 roadmap
PostPosted: Wed Jun 06, 2018 11:09 am 
Offline
Release Manager, Design
User avatar

Joined: Wed Nov 16, 2011 12:56 pm
Posts: 4594
Location: Sol III
adrian_broher wrote:
Vezzra, what about issues labeled with 'category:feature' or 'category:tweak' within the 'v0.4.8 (optional)' milestone? Can we mass reassign those to the 'post v0.4.8' milestone? Maybe there are some relevant and simple bugs in the optional milestone that can be fixed without much of a hassle, but I don't want to sift through the vast amount of issues just to pick the nice and easy ones.
Yep, sounds reasonable. Just went ahead and did the reassigning. I also included "category:refactoring", or, to me more precise, everything that doesn't have the "category:bug" label.


Top
 Profile  
 
 Post subject: Re: 0.4.8 roadmap
PostPosted: Wed Jun 06, 2018 11:14 am 
Offline
Release Manager, Design
User avatar

Joined: Wed Nov 16, 2011 12:56 pm
Posts: 4594
Location: Sol III
Ophiuchus wrote:
I also have a question about the Fulver species which should facilitate an aggressive non-distributed strategy using the stockpile (GOOD _stockpile _weapons).

[...]

i personally would prefer them to be in the 0.4.8 release also, but maybe they are not ready for prime time.
Geoff the Medio wrote:
Given lack of testing / novelty, I'd put new species into master for now.
What Geoff said. This release is already so much delayed, I really don't want to add anything that isn't a bugfix and has even a remote chance of delaying things further.


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 88 posts ]  Go to page Previous  1, 2, 3, 4, 5, 6  Next

All times are UTC


Who is online

Users browsing this forum: No registered users and 2 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group