FreeOrion

Forums for the FreeOrion project
It is currently Thu Nov 23, 2017 5:26 am

All times are UTC




Post new topic Reply to topic  [ 89 posts ]  Go to page Previous  1, 2, 3, 4, 5, 6  Next
Author Message
PostPosted: Tue Aug 25, 2015 11:19 pm 
Offline
Programming, Design, Admin
User avatar

Joined: Wed Oct 08, 2003 1:33 am
Posts: 12016
Location: Munich
Cjkjvfnby wrote:
I expect to have RC1 in release name
You shouldn't. It's a candidate to be the release, meaning if it is the release, the file is renamed. If "RC#" was in the version string, there would need to be a new build with a different string for the actual release. That new build would need to be tested before being the actual release... meaning it would just be a release candidate... meaning it should have "RC" in the version string... etc.


Top
 Profile  
 
PostPosted: Wed Aug 26, 2015 7:08 am 
Offline
Release Manager, Design
User avatar

Joined: Wed Nov 16, 2011 12:56 pm
Posts: 4243
Location: Sol III
Vezzra wrote:
One thing I almost forgot: I think we should now delete the pre-release tags/entries on github - or can anyone think of a reason why we should keep them?
Um, if no one objects, I'm going to do that this week or the next...


Top
 Profile  
 
PostPosted: Wed Aug 26, 2015 7:56 am 
Offline
AI Contributor
User avatar

Joined: Tue Jun 24, 2014 9:55 pm
Posts: 444
Geoff the Medio wrote:
Cjkjvfnby wrote:
I expect to have RC1 in release name
You shouldn't. It's a candidate to be the release, meaning if it is the release, the file is renamed. If "RC#" was in the version string, there would need to be a new build with a different string for the actual release. That new build would need to be tested before being the actual release... meaning it would just be a release candidate... meaning it should have "RC" in the version string... etc.
It is common practice to have RC in build name. I dont know how they deal with such recursion in names.

_________________
If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0


Top
 Profile  
 
PostPosted: Wed Aug 26, 2015 12:44 pm 
Offline
Creative Contributor
User avatar

Joined: Fri Jun 28, 2013 11:45 pm
Posts: 3264
Cjkjvfnby wrote:
It is common practice to have RC in build name. I dont know how they deal with such recursion in names.

Common, but not absolute, and it's not the way FO has ever done it (I asked similar last time and the explanations make sense to me.

Basically, if we don't find any bugs, the Release Candidate is the release, recompiling it just to change the titlebar seems a bit pointless to me, and Vezzra does more than enough work as it is.

_________________
Mat Bowles

Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.


Top
 Profile  
 
PostPosted: Thu Aug 27, 2015 3:14 pm 
Offline
Release Manager, Design
User avatar

Joined: Wed Nov 16, 2011 12:56 pm
Posts: 4243
Location: Sol III
An issue has turned up that needed to be fixed, so there will be RC2. The only question is when. I can do it already tomorrow (in that case the deadline for submitting changes would be tomorrow 12am UTC), or I can make next Mondays builds RC2.

I'd prefer tomorrow, comments?


Top
 Profile  
 
PostPosted: Thu Aug 27, 2015 3:29 pm 
Offline
Creative Contributor
User avatar

Joined: Fri Jun 28, 2013 11:45 pm
Posts: 3264
Tomorrow is good for me, the only other issues I have are minor stringtable quibbles that, frankly, don't matter massively, I'll see if I can work them up but if I don't it matters not at all.

_________________
Mat Bowles

Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.


Top
 Profile  
 
PostPosted: Fri Aug 28, 2015 10:50 am 
Offline
Release Manager, Design
User avatar

Joined: Wed Nov 16, 2011 12:56 pm
Posts: 4243
Location: Sol III
Update on the RC2 schedule

Mat, as the request for a cherry pick you put up on github refers to a commit with changes to the stringtable which I want to give Ouaz some time to provide the French translation, I decided to give us a bit more time to get in fixes and therefore will produce RC2 on Monday. I've also some small things I want to try to fix (e.g. the Planetary Starlane Drive has some quirks it seems, most notably a complete lack of sitreps, which make it very annoying to use).

So, coming Monday builds will be RC2. Everyone who wants to get in some fixes, please do so until Sunday, especially if those fixes contain changes to the English stringtable that should be translated (@Ouaz, can you update the French stringtable on Sunday evening?). Commits that don't touch the stringtable can also go in on Monday.

Deadline for commits that introduce changes to the English stringtable: Sunday Aug 30th, 4PM UTC (so Ouaz has enough time to do translation work)

Deadline for commits that don't change the English stringtable: Monday Aug 31st, 12AM UTC (to give me some time to cherry pick things, update the changelog, etc.)


Top
 Profile  
 
PostPosted: Fri Aug 28, 2015 5:34 pm 
Offline
Dyson Forest
User avatar

Joined: Wed Aug 13, 2014 7:21 pm
Posts: 208
Location: France
Yep, no problem for Sunday 30th 4PM UTC (6PM CEST, so it's perfect).

_________________
I release every updated file under the CC-BY-SA 3.0 license.


Top
 Profile  
 
PostPosted: Mon Aug 31, 2015 6:34 pm 
Offline
Release Manager, Design
User avatar

Joined: Wed Nov 16, 2011 12:56 pm
Posts: 4243
Location: Sol III
0.4.5 RC2 is out and has been uploaded to sourceforge and github.

Geoff, I think we've a good chance that we got everything major this time, so it might be sufficient to give it just a couple of days until declaring the final release. Your call.


Top
 Profile  
 
PostPosted: Tue Sep 01, 2015 9:02 am 
Offline
Release Manager, Design
User avatar

Joined: Wed Nov 16, 2011 12:56 pm
Posts: 4243
Location: Sol III
Vezzra wrote:
Geoff, I think we've a good chance that we got everything major this time
Maybe I should do less guessing and more actual thinking... :oops:

Well, anyway, a small fix for the AI that should get cherry picked and a small mess-up on my part when adjusting the slot positions of the heavy asteroid hull to the new graphic caused me to contemplate another RC build, and I decided that I'm going to do one. As I won't have time tomorrow, still cherish the hope that these might be the last little nasties and don't want to loose time I'm going to produce RC3 today afternoon/evening.

This way it only means I've caused myself more work ;)


Top
 Profile  
 
PostPosted: Tue Sep 01, 2015 9:05 am 
Offline
Programming, Design, Admin
User avatar

Joined: Wed Oct 08, 2003 1:33 am
Posts: 12016
Location: Munich
Vezzra wrote:
...adjusting the slot positions of the heavy asteroid hull to the new graphic...
Please stop making changes like this in release candidate builds. They should be for bug fixing, not content / graphics additions and changes, specifically because of problems like this that could hold up the subsequent release.


Top
 Profile  
 
PostPosted: Tue Sep 01, 2015 11:45 am 
Offline
Creative Contributor
User avatar

Joined: Fri Jun 28, 2013 11:45 pm
Posts: 3264
Ah, I missed that.

Probably need to put a comment at the top of shiphulls.txt for this but in general, you can change the coordinates of slot locations as much as you like without it messing anything else up.

But if you change the order they're listed on the hull then it can mess up the AI, the premade ship designs and saved hulls, but doesn't always do so depending on how that slot is being used. Basically, don't change the order the slots are listed and you're good.

_________________
Mat Bowles

Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.


Top
 Profile  
 
PostPosted: Tue Sep 01, 2015 3:06 pm 
Offline
Release Manager, Design
User avatar

Joined: Wed Nov 16, 2011 12:56 pm
Posts: 4243
Location: Sol III
Geoff the Medio wrote:
Please stop making changes like this in release candidate builds.
Yep, sorry. I know, after all those years I should know better than to think: "Oh, what could possibly go wrong?" :oops:


Top
 Profile  
 
PostPosted: Tue Sep 01, 2015 6:11 pm 
Offline
Release Manager, Design
User avatar

Joined: Wed Nov 16, 2011 12:56 pm
Posts: 4243
Location: Sol III
0.4.5 RC3 has been uploaded to sourceforge and github.


Top
 Profile  
 
PostPosted: Tue Sep 01, 2015 7:25 pm 
Offline
AI Lead, Programmer
User avatar

Joined: Sat Sep 22, 2012 6:25 pm
Posts: 4377
MatGB wrote:
But if you change the order they're listed on the hull then it can mess up the AI,
FYI, I'm pretty sure that Morlic's ShipDesigner has entirely cleared up that particular sensitivity.

_________________
If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 89 posts ]  Go to page Previous  1, 2, 3, 4, 5, 6  Next

All times are UTC


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
cron
Powered by phpBB® Forum Software © phpBB Group