FreeOrion

Forums for the FreeOrion project
It is currently Tue Dec 12, 2017 7:59 pm

All times are UTC




Post new topic Reply to topic  [ 4 posts ] 
Author Message
PostPosted: Wed Aug 24, 2016 6:56 pm 
Offline
Programmer
User avatar

Joined: Fri Mar 01, 2013 9:52 am
Posts: 1040
Location: Germany
If there are no objections to it I would like to remove the 'Auto-generated effect descriptions'. To my knowledge the output always was subpar and by adding the optional 'description' parameter to an EffectsGroup a year ago (8359b308) content writers now can provide much better description texts. Removing this option would simplify some of the ValueRef code greatly and remove a good chunk of hard to extract translation keys.

_________________
Resident code gremlin
Attached patches are released under GPL 2.0 or later.
Git author: Marcel Metz


Top
 Profile  
 
PostPosted: Wed Aug 24, 2016 7:56 pm 
Offline
Release Manager, Design
User avatar

Joined: Wed Nov 16, 2011 12:56 pm
Posts: 4288
Location: Sol III
Never really used that feature, so no opinion/preference on that one. Can go as far as I'm concerned.


Top
 Profile  
 
PostPosted: Wed Aug 24, 2016 7:57 pm 
Offline
Programming, Design, Admin
User avatar

Joined: Wed Oct 08, 2003 1:33 am
Posts: 12041
Location: Munich
I don't think the optional hand-written description text for effectsgroups is a replacement for the autogenerated descriptions, but I don't think that matters. Switching AutoGeneratedDescription to call ->Dump() instead of ->AutoGeneratedDescription() works at least as well for debugging purposes, which was one of the main reasons to keep the autogenerated descriptions last time it was discussed.

All the autogenerated descriptions for conditions and valuerefs needs to remain though, until all location and enqueue conditions have hand-written descriptions.


Top
 Profile  
 
PostPosted: Wed Aug 24, 2016 8:25 pm 
Offline
Programmer
User avatar

Joined: Fri Mar 01, 2013 9:52 am
Posts: 1040
Location: Germany
Geoff the Medio wrote:
I don't think the optional hand-written description text for effectsgroups is a replacement for the autogenerated descriptions, but I don't think that matters. Switching AutoGeneratedDescription to call ->Dump() instead of ->AutoGeneratedDescription() works at least as well for debugging purposes, which was one of the main reasons to keep the autogenerated descriptions last time it was discussed.


I already forgot that PR. I will replace it with obj->Dump() calls then and adapt the related code and settings then.

Geoff the Medio wrote:
All the autogenerated descriptions for conditions and valuerefs needs to remain though, until all location and enqueue conditions have hand-written descriptions.


I didn't see that. Well, have to start somewhere.

_________________
Resident code gremlin
Attached patches are released under GPL 2.0 or later.
Git author: Marcel Metz


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 4 posts ] 

All times are UTC


Who is online

Users browsing this forum: No registered users and 2 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group