Remove 'Auto-generated effect descriptions'
Moderator: Committer
- adrian_broher
- Programmer
- Posts: 1156
- Joined: Fri Mar 01, 2013 9:52 am
- Location: Germany
Remove 'Auto-generated effect descriptions'
If there are no objections to it I would like to remove the 'Auto-generated effect descriptions'. To my knowledge the output always was subpar and by adding the optional 'description' parameter to an EffectsGroup a year ago (8359b308) content writers now can provide much better description texts. Removing this option would simplify some of the ValueRef code greatly and remove a good chunk of hard to extract translation keys.
Resident code gremlin
Attached patches are released under GPL 2.0 or later.
Git author: Marcel Metz
Attached patches are released under GPL 2.0 or later.
Git author: Marcel Metz
Re: Remove 'Auto-generated effect descriptions'
Never really used that feature, so no opinion/preference on that one. Can go as far as I'm concerned.
- Geoff the Medio
- Programming, Design, Admin
- Posts: 13603
- Joined: Wed Oct 08, 2003 1:33 am
- Location: Munich
Re: Remove 'Auto-generated effect descriptions'
I don't think the optional hand-written description text for effectsgroups is a replacement for the autogenerated descriptions, but I don't think that matters. Switching AutoGeneratedDescription to call ->Dump() instead of ->AutoGeneratedDescription() works at least as well for debugging purposes, which was one of the main reasons to keep the autogenerated descriptions last time it was discussed.
All the autogenerated descriptions for conditions and valuerefs needs to remain though, until all location and enqueue conditions have hand-written descriptions.
All the autogenerated descriptions for conditions and valuerefs needs to remain though, until all location and enqueue conditions have hand-written descriptions.
- adrian_broher
- Programmer
- Posts: 1156
- Joined: Fri Mar 01, 2013 9:52 am
- Location: Germany
Re: Remove 'Auto-generated effect descriptions'
I already forgot that PR. I will replace it with obj->Dump() calls then and adapt the related code and settings then.Geoff the Medio wrote:I don't think the optional hand-written description text for effectsgroups is a replacement for the autogenerated descriptions, but I don't think that matters. Switching AutoGeneratedDescription to call ->Dump() instead of ->AutoGeneratedDescription() works at least as well for debugging purposes, which was one of the main reasons to keep the autogenerated descriptions last time it was discussed.
I didn't see that. Well, have to start somewhere.Geoff the Medio wrote:All the autogenerated descriptions for conditions and valuerefs needs to remain though, until all location and enqueue conditions have hand-written descriptions.
Resident code gremlin
Attached patches are released under GPL 2.0 or later.
Git author: Marcel Metz
Attached patches are released under GPL 2.0 or later.
Git author: Marcel Metz