FreeOrion

Forums for the FreeOrion project
It is currently Mon Jun 25, 2018 7:06 pm

All times are UTC




Post new topic Reply to topic  [ 4 posts ] 
Author Message
PostPosted: Fri Mar 09, 2018 6:39 pm 
Offline
AI Lead, Programmer
User avatar

Joined: Sat Sep 22, 2012 6:25 pm
Posts: 4658
We are adding a stage of python code style checking into our GitHub Travis CI build process; PR's should not be merged if they are failing this stage. If a PR of yours fails this stage, please review the associated report (found via the respective "Details" link in the CI section of your PR page), make the required changes and check locally, then update your PR.

There are a variety of ways to check for such things locally; in general we recommend doing your python coding with PyCharm, which supports such checking in a few ways.

If you have questions about this general process, or about particular error reporting you get from this, feel free to post those questions here. Once resolved I may curate (edit or delete) any such posts here in order to keep this thread concise/clean.

(Related to the above, I invite comment on this initial message, I'll then edit and curate the thread).

_________________
If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0


Top
 Profile  
 
PostPosted: Sat Mar 10, 2018 8:07 am 
Offline
Space Floater

Joined: Sat Jul 01, 2017 4:54 am
Posts: 40
Could you please add links/info as to what is the style you are checking for?

pep8? pep8 with exceptions? Do you have a pylintrc for pylint?


Top
 Profile  
 
PostPosted: Sat Mar 10, 2018 9:17 am 
Offline
AI Contributor
User avatar

Joined: Tue Jun 24, 2014 9:55 pm
Posts: 447
Quote:
Could you please add links/info as to what is the style you are checking for?


https://github.com/freeorion/freeorion/ ... tyle-check

_________________
If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0


Top
 Profile  
 
PostPosted: Sat Mar 10, 2018 5:37 pm 
Offline
Space Floater

Joined: Sat Jul 01, 2017 4:54 am
Posts: 40
Cjkjvfnby wrote:
Quote:
Could you please add links/info as to what is the style you are checking for?


https://github.com/freeorion/freeorion/ ... tyle-check

Divlish could you please include something along the lines of:
"Our info page for the current style checking tool and the project configuration for the tool."

TIA.

Cjkjvfnby. Thank you. That is the information I was wanting to know.


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 4 posts ] 

All times are UTC


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group