FreeOrion

Well, I got it to compile (though not run properly yet).

First question I have - Is there any way to find out who 'owns' a piece of code? I assume you work with at least some degree of code ownership. I found some things that I have questions about but I do not want to pollute the forum (even more than I am currently doing) with tiny code questions.

Second - This is quite small but it was annoying when I had to update the makefiles for my system: Why are library header files that are 'supposed' to be in their own subdirectory included without naming the subdirectory, requiring people to put a zillion include paths in their build environment? For example the code (at least in a few places) includes the sdl headers as <SDL.h>, while the sensible way would be <SDL/SDL.h>, since the SDL headers are always (as far as I know) in their own directory, and that directory is usually in some include dir that is already in the include path.

Third - How exactly is the committing of code done? I send my modifications/additions to someone (Zach?) who then tells me how wonderful they are, and then I just commit them myself? Does CVS *really* make sure I do not overwrite other people's modifications? Won't code modified by more people at a time behave strangely?

Fourth - Why do the server and AI client app use SDL and GiGi while they do not use any graphics/GUI stuff at all?

And last - I'd like to be added to the coding team. I'm quite enthousiastic about this project and I think I could be of use. My specialties are smartass code reviewing, graphics programming and AI programming.

One more thing - can I download libGiGi.a and libGiGiNet.a for mingw32 anywhere? I synthesized them from the DLL's but had to do some messy things. They compile fine so far but I am not sure they work properly.

I think there is no real code ownership. I see two ways to ask questions. First use this thread, second post to programmer mailing list.


While writing this from memory, i believe <SDL/SDL.h> is only possible when using precompiled sdl.dll. I for instance rebuild the SDL codebase. So my include path for SDL is somewhat like "../SDL.1.6.7/include" .



It's a part of Concurrent Versions System that several developer can merge their changes (see sourceforge for details). I think you will checkin code changes yourself.


I do not know.

Ronald.

No ownership... so can everyone mess with everyone's code? Doesn't this lead to conflicts? ("How dare you touch my code!? Why you little...")


Well, a header is a header, I personally put them into my common include dir even when I compile something myself. I think a lot of make install scripts do this too.

No. All code contributed must be under the GPL, or where appropriate (eg, contributions to GG) the LGPL. Therefore, anyone is permitted to touch anyone else's code. We don't really worry here about someone touching a portion someone else wrote - it's all towards the goal of making the game better.
However, if you change something from being good code to bad code, undoubtedly there will be annoyed responses
If coders are not contributing helpfully, then they will have their permissions removed.

As for backtracking, CVS does keep track of all code, so if a rogue coder makes a bungle, it is simple to revert to before they made bad changes.



I think that we should change references to <SDL/SDL.h> where possible, as this is the standard. I'm not sure that there is a good reason not to.

As a side note - I (we) would also appreciate if you could learn how to write doxygen style comments and do this. The GG sources are written in such a format, so will provide you with an excellent example of how. Not everyone has been, but it would be in our best interests if we could have new coders stick to this habit.

I see no need to do so. Please let it as it is. (Reason is for instance my case, with such a change i HAVE TO copy the headers)

Ronald.