Naglium, was that just from the main menu, or did you also try quitting after a game is started?Nagilum wrote:Confirmed. With svn6891 I don't see the assertion any more.
FSM Assertions
Moderator: Committer
Re: FSM Assertions
I no longer get the error if I just close out the main menu screen, but if I start up a game and close it out without going back to the main menu, then I still get the error message.
If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0
Re: FSM Assertions
Still happens for me when I close the client directly from the game. I think we only fixed it when exiting from the intro menu. Here's the patch I used to catch the cast error in gdb.
- Attachments
-
[The extension patch has been deactivated and can no longer be displayed.]
Yesterday, we were still on the brink. Fortunately, today we have come one step further.
Re: FSM Assertions
Just quitting from the main menu.Dilvish wrote:I no longer get the error if I just close out the main menu screen, but if I start up a game and close it out without going back to the main menu, then I still get the error message.
Naglium, was that just from the main menu, or did you also try quitting after a game is started?Nagilum wrote:Confirmed. With svn6891 I don't see the assertion any more.
- Geoff the Medio
- Programming, Design, Admin
- Posts: 13603
- Joined: Wed Oct 08, 2003 1:33 am
- Location: Munich
Re: FSM Assertions
Attached is a patch that moves more / all Client() accessing out of human client FSM state destructors. Does this help with the assertion when closing while playing a game, and does it cause any other apparent problems, like various windows not appearing / hiding when they should when moving between screens / games / menus / etc?
- Attachments
-
[The extension patch has been deactivated and can no longer be displayed.]
- Geoff the Medio
- Programming, Design, Admin
- Posts: 13603
- Joined: Wed Oct 08, 2003 1:33 am
- Location: Munich
Re: FSM Assertions
bump?
Re: FSM Assertions
I haven't seen any assertion failures with recent versions so I can't test this patch.
- Geoff the Medio
- Programming, Design, Admin
- Posts: 13603
- Joined: Wed Oct 08, 2003 1:33 am
- Location: Munich
Re: FSM Assertions
Have you tried closing the window from within a game / on the map, and not just from the intro screen menu?Nagilum wrote:I haven't seen any assertion failures with recent versions...
Re: FSM Assertions
hmm, I dunno what's up, but I can no longer replicate the assertion problem with the main svn build, trying both release and debug builds, and whether quitting from initial menu, at first into a game at the map, or after having played a turn.
The patch did not appear to cause me any problems anyway, though I did not test it extensively.
Cami, would you please double check your status on this, since it seemed you were the other person besides me still getting the assertion errors.
The patch did not appear to cause me any problems anyway, though I did not test it extensively.
Cami, would you please double check your status on this, since it seemed you were the other person besides me still getting the assertion errors.
If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0