MapWnd save/restore popup visibility consistently

Message

vincele · #16 Post by **vincele** » Wed Jul 16, 2014 7:04 pm

Dilvish wrote:Just to check, Matt, do you ever observe any real problems with dragging the sitrep scrollbar; is there a particular reason you dislike dragging it to the top?

I think the brain choose the quickest way to achieve the goal, not even being conscious that it's a side-effect and not the designed way.

MatGB · #17 Post by **MatGB** » Wed Jul 16, 2014 8:25 pm

TBH, I've never liked grabbing and dragging scrollbars, I think it comes from very early PC use when it would go horribly wrong and be unreliable (on the machines at college I was using).

I'm not even sure I'd tried it until now, so used to being able to hit a key to do something. Plus, y'know, general lagginess in the game later on, trying to do anything with the mouse can get frustrating, I forget to make sure the game pointer has caught up with the system pointer, etc (which I'm sure isn't uncommon or just me, others have complained about lag & game pointer a few times, but turning it to just game pointer allowed in options messes up other things the way I'm setup).

vincele · #18 Post by **vincele** » Wed Jul 16, 2014 9:12 pm

MatGB wrote:TBH, I've never liked grabbing and dragging scrollbars, I think it comes from very early PC use when it would go horribly wrong and be unreliable (on the machines at college I was using).

I don't like it myself, but the mouse scroll button mitigated that a lot

MatGB wrote:general lagginess in the game later on, trying to do anything with the mouse can get frustrating, I forget to make sure the game pointer has caught up with the system pointer, etc (which I'm sure isn't uncommon or just me, others have complained about lag & game pointer a few times, but turning it to just game pointer allowed in options messes up other things the way I'm setup).

FO is not really playable on my laptop, even in the early game turns : mouse pointer laggines, low FPS, CPU maxed out, etc... So I know what you mean. And I fully understand the (mis)use of the toggle as a quick way to scroll back to top. Perhaps we should find another good way to allow for that. Maybe the scrollbar buttons...

vincele · #19 Post by **vincele** » Fri Jul 18, 2014 4:14 pm

vincele wrote:
Geoff the Medio wrote:I think the purpose of HideAppPopups and ShowAllPopups was to accomplish what you want, but most of the "popup" windows aren't derived from MapWndPopup, so don't work with this feature.
Would that be the best route for action ? I can give this a try...

Hello, here is a patchset that try that.

* ObjectList, Messages, Empires and SitRep are converted to being subclasses of MapWndPopup
* HideAllPopups() is used to consistently do the Show/Hide dance when toggling the design, production and research windows
* Adds the missing ShowAllPopups()

Looks simple enough and works for me in my (somewhat limited) testing...