Hello,
Looking at patch in [r7402] I was wondering:
Since we are getting rid of ctor parameters, why wouldn't we go one step further and give str a default value, f.e. an empty string ?
[r7402] CUIButton patch
Moderator: Committer
[r7402] CUIButton patch
All the patches I'll provide for freeorion will be released under the GPL v2 or later license.
Let's unleash the dyson forest powa!
Let's unleash the dyson forest powa!
- adrian_broher
- Programmer
- Posts: 1156
- Joined: Fri Mar 01, 2013 9:52 am
- Location: Germany
Re: [r7402] CUIButton patch
One step at a time.vincele wrote:Hello,
Looking at patch in [r7402] I was wondering:
Since we are getting rid of ctor parameters, why wouldn't we go one step further and give str a default value, f.e. an empty string ?
Resident code gremlin
Attached patches are released under GPL 2.0 or later.
Git author: Marcel Metz
Attached patches are released under GPL 2.0 or later.
Git author: Marcel Metz
Re: [r7402] CUIButton patch
To make things clear, I wasn't advocating to do it in the same patch, but just asking if that should be planned as further cleanup...
I already expressed my love for small / self contained / single purpose patches here
I already expressed my love for small / self contained / single purpose patches here
All the patches I'll provide for freeorion will be released under the GPL v2 or later license.
Let's unleash the dyson forest powa!
Let's unleash the dyson forest powa!