[r7402] CUIButton patch

Programmers discuss here anything related to FreeOrion programming. Primarily for the developers to discuss.

Moderator: Committer

Post Reply
Message
Author
User avatar
vincele
Space Dragon
Posts: 341
Joined: Sun Mar 23, 2014 6:10 pm

[r7402] CUIButton patch

#1 Post by vincele »

Hello,

Looking at patch in [r7402] I was wondering:

Since we are getting rid of ctor parameters, why wouldn't we go one step further and give str a default value, f.e. an empty string ?
All the patches I'll provide for freeorion will be released under the GPL v2 or later license.
Let's unleash the dyson forest powa!

User avatar
adrian_broher
Programmer
Posts: 1156
Joined: Fri Mar 01, 2013 9:52 am
Location: Germany

Re: [r7402] CUIButton patch

#2 Post by adrian_broher »

vincele wrote:Hello,

Looking at patch in [r7402] I was wondering:

Since we are getting rid of ctor parameters, why wouldn't we go one step further and give str a default value, f.e. an empty string ?
One step at a time.
Resident code gremlin
Attached patches are released under GPL 2.0 or later.
Git author: Marcel Metz

User avatar
vincele
Space Dragon
Posts: 341
Joined: Sun Mar 23, 2014 6:10 pm

Re: [r7402] CUIButton patch

#3 Post by vincele »

To make things clear, I wasn't advocating to do it in the same patch, but just asking if that should be planned as further cleanup...

I already expressed my love for small / self contained / single purpose patches here
All the patches I'll provide for freeorion will be released under the GPL v2 or later license.
Let's unleash the dyson forest powa!

Post Reply