While plowing through the UI code I realized that the MarkupBox class isn't used. The MarkupBox is some RichText widget utilizing some HTML-ish document language to embed hyperlinks and images into text. I would assume this should be used for the Pedia. Aside from some API changes between 2010 to 2014 tzlain seems to be only one seriously working on this.
Do we still have plans for it? Can it be removed? Should it be fixed?
MarkupBox
Moderator: Committer
- adrian_broher
- Programmer
- Posts: 1156
- Joined: Fri Mar 01, 2013 9:52 am
- Location: Germany
MarkupBox
Resident code gremlin
Attached patches are released under GPL 2.0 or later.
Git author: Marcel Metz
Attached patches are released under GPL 2.0 or later.
Git author: Marcel Metz
- Geoff the Medio
- Programming, Design, Admin
- Posts: 13587
- Joined: Wed Oct 08, 2003 1:33 am
- Location: Munich
Re: MarkupBox
That was the idea... Ideally, it would allow getting rid of the custom top bar of the pedia, to instead have text and graphics laid out with basic HTML-like markup of text.adrian_broher wrote:The MarkupBox is some RichText widget utilizing some HTML-ish document language to embed hyperlinks and images into text. I would assume this should be used for the Pedia.
tzlaine never worked on it as far as I remember... Just me.Aside from some API changes between 2010 to 2014 tzlain seems to be only one seriously working on this.
I'd still like to have the functionality, but there were limits to how GG's text formatting worked that made it difficult to use for implementing the MarkupBox functionality I wanted, so I abandoned it. I think the issues mainly had to do with breaking text into smaller chunks so it could be put into adjacent rectangular Edit controls that combined to make the text to wrap/fit into non-rectangular regions, such as occurs for text near images in web page layout. Using the existing text layout code in GG for this wasn't working well.Do we still have plans for it? Can it be removed? Should it be fixed?
- adrian_broher
- Programmer
- Posts: 1156
- Joined: Fri Mar 01, 2013 9:52 am
- Location: Germany
Re: MarkupBox
My bad, i didn't look properly at the log.Geoff the Medio wrote:tzlaine never worked on it as far as I remember... Just me.
Well, then I keep it as it is for now.
Resident code gremlin
Attached patches are released under GPL 2.0 or later.
Git author: Marcel Metz
Attached patches are released under GPL 2.0 or later.
Git author: Marcel Metz
Re: MarkupBox
You can add summary of this topic as comment to code to save someone else time.adrian_broher wrote:My bad, i didn't look properly at the log.Geoff the Medio wrote:tzlaine never worked on it as far as I remember... Just me.
Well, then I keep it as it is for now.
IMHO Code what has no usages should no be present in main branch. In git workflow it lives in separate branch before it is ready. Such code may confuse other users, it may be not tested at all, it may need time to support due other code changes.
If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0