FreeOrion

Forums for the FreeOrion project
It is currently Tue Oct 17, 2017 11:36 am

All times are UTC




Post new topic Reply to topic  [ 10 posts ] 
Author Message
 Post subject: small tech screen change
PostPosted: Fri Oct 02, 2015 6:15 pm 
Offline
Graphics
User avatar

Joined: Tue Jul 01, 2003 8:27 pm
Posts: 698
Currently when zooming far out, the tech name will be hidden. I'd like to commit a patch that instead of hiding the text will remove the text's shadow, which makes it easier to read.

Ok to commit, formatting ok?

Code:
    // small text: remove shadow
    if (font_pts < 10)
        m_name_label->SetText(m_name_text);
    else
        m_name_label->SetText("<s>" + m_name_text + "</s>");

    GG::Pt text_ul(text_left + 4, text_top);
    GG::Pt text_size(text_width + PAD, text_height);
    m_name_label->SizeMove(text_ul, text_ul + text_size);
    /// Need to render children too
    GG::GUI::GetGUI()->RenderWindow(m_name_label);

_________________
If I provided any images, code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0.


Top
 Profile  
 
PostPosted: Fri Oct 02, 2015 6:20 pm 
Offline
Programming, Design, Admin
User avatar

Joined: Wed Oct 08, 2003 1:33 am
Posts: 11999
Location: Munich
Post a diff, if you don't want to / can't make a pull request...


Top
 Profile  
 
PostPosted: Sat Oct 03, 2015 6:52 am 
Offline
Graphics
User avatar

Joined: Tue Jul 01, 2003 8:27 pm
Posts: 698
Sure, I can make a pull request. What I meant: are you ok with the change? If yes, is the formatting ok? And, would you mind if I directly commit (in the future) if I have changed just a few lines of code?

Anyway, PR is here:
https://github.com/freeorion/freeorion/pull/369

_________________
If I provided any images, code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0.


Top
 Profile  
 
PostPosted: Sat Oct 03, 2015 7:44 am 
Offline
Programming, Design, Admin
User avatar

Joined: Wed Oct 08, 2003 1:33 am
Posts: 11999
Location: Munich
The Silent One wrote:
Sure, I can make a pull request. What I meant: are you ok with the change?
I can't tell from a code snippet what was changed... pull requests or diff make this clear.


Top
 Profile  
 
PostPosted: Sun Oct 04, 2015 6:39 am 
Offline
Release Manager, Design
User avatar

Joined: Wed Nov 16, 2011 12:56 pm
Posts: 4221
Location: Sol III
The Silent One wrote:
And, would you mind if I directly commit (in the future) if I have changed just a few lines of code?
That's not so much a matter of the quantity of changes, than what kind of changes you want to introduce. If you want/need feedback/input, like in this case, make a PR.


Top
 Profile  
 
PostPosted: Mon Oct 05, 2015 12:13 pm 
Offline
Graphics
User avatar

Joined: Tue Jul 01, 2003 8:27 pm
Posts: 698
Since the text of the tech panels is illegible if the tech screen is zoomed far out, I suggest to remove the text panel altogether in that case; see below. Opinions?


Attachments:
techtree zoomed out.jpg
techtree zoomed out.jpg [ 61.25 KiB | Viewed 1073 times ]

_________________
If I provided any images, code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0.
Top
 Profile  
 
PostPosted: Mon Oct 05, 2015 12:39 pm 
Offline
Creative Contributor
User avatar

Joined: Fri Jun 28, 2013 11:45 pm
Posts: 3243
Looks like a good plan to me, if we (well, you and the other art people) can get a unique icon for all the extant tech then it'll work even better, and we're getting there now.

_________________
Mat Bowles

Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.


Top
 Profile  
 
PostPosted: Mon Oct 05, 2015 6:09 pm 
Offline
Graphics
User avatar

Joined: Tue Jul 01, 2003 8:27 pm
Posts: 698
Here's an overview of the zoom levels of the tech screen as I have implemented them now. Looking good I think?


Attachments:
comparison zoom levels.jpg
comparison zoom levels.jpg [ 130.38 KiB | Viewed 1052 times ]

_________________
If I provided any images, code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0.
Top
 Profile  
 
PostPosted: Mon Oct 05, 2015 7:40 pm 
Offline
Release Manager, Design
User avatar

Joined: Wed Nov 16, 2011 12:56 pm
Posts: 4221
Location: Sol III
The Silent One wrote:
Looking good I think?
Yep, that looks quite good. As far as I'm concerned, go ahead and implement it.


Top
 Profile  
 
PostPosted: Mon Oct 05, 2015 8:09 pm 
Offline
Graphics
User avatar

Joined: Tue Jul 01, 2003 8:27 pm
Posts: 698
The images are already from ingame, pull request is here: https://github.com/freeorion/freeorion/pull/369

_________________
If I provided any images, code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0.


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 10 posts ] 

All times are UTC


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
cron
Powered by phpBB® Forum Software © phpBB Group