FreeOrion

Forums for the FreeOrion project
It is currently Sat Dec 16, 2017 1:38 am

All times are UTC




Post new topic Reply to topic  [ 3 posts ] 
Author Message
PostPosted: Fri Jan 29, 2016 11:29 am 
Offline
Space Floater

Joined: Tue Dec 15, 2015 6:20 pm
Posts: 47
Location: Solaria
https://github.com/freeorion/freeorion/pull/456
Quote:
Bugfix 1: with case-sensitive filesystem the planet type environment images in the encyclopedia was never shown (but a big red X) since the file names are all lowercase but the planet_type is uppercase
Bugfix 2: don't create warning message in parse_tokens(tokendict, is_hull=False) of the python AI if AIDependencies.STACKING_RULES appears.

Wrapper: The wrapper creates an easier interface to issueCreateShipDesignOrder and updates the cache on success.


Besides that I think creating a real ShipDesignAI module could be helpful, also I would like to discuss
Cjkjvfnby wrote:
Before we have lazy cache initialization. We need design, we create design in cache.
Now we add design on creation, am I right? May be split get and set in that case?


edit: link to PR on github

_________________
Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project (this includes pullrequest of the useraccount banduri at github)


Top
 Profile  
 
PostPosted: Fri Jan 29, 2016 7:18 pm 
Offline
AI Contributor

Joined: Tue Feb 17, 2015 11:54 am
Posts: 224
banduri wrote:
Besides that I think creating a real ShipDesignAI module could be helpful


It is not clear to me what you mean with "a real ShipDesignAI module"? Could you elaborate that a bit?

_________________
If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0


Top
 Profile  
 
PostPosted: Fri Jan 29, 2016 7:55 pm 
Offline
Space Floater

Joined: Tue Dec 15, 2015 6:20 pm
Posts: 47
Location: Solaria
Morlic wrote:
banduri wrote:
Besides that I think creating a real ShipDesignAI module could be helpful


It is not clear to me what you mean with "a real ShipDesignAI module"? Could you elaborate that a bit?


https://docs.python.org/2/tutorial/modules.html#packages I think it could be easier to read if every class has its own file

_________________
Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project (this includes pullrequest of the useraccount banduri at github)


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 3 posts ] 

All times are UTC


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group