tomboy64 wrote:Another thing is, when running "make install" it actually copies the binaries freeorion/freeoriond/freeorionca to /usr/local/ and all the rest to /usr/local/default/default. By applying the attached patch it's possible to reduce this to 1 default.
I didn't write the CMake install targets with installing into useful places on a Linux machine in mind. The install locations are purely for making Win32 binary installers. If you want to make a change, and I'm all for that, please make it using if (WIN32) [the old stuff] else () [your new stuff] endif ().
The proper way, imho, would be to introduce 2 variables, for example INSTALL_DATA_DIR and INSTALL_BIN_DIR, which are listed on top and easily modifyable and which regulate the install directory.
I'd prefer to see things get installed in a canonical location every time, under ${prefix}:
${prefix}/bin
${prefix}/lib
${prefix}/doc
${prefix}/share
If we need to add /freeorion to one or more of these, that's fine (e.g. ${prefix}/share/freeorion/default). But I don't want users to need to know what the values of INSTALL_DATA_DIR and INSTALL_BIN_DIR were if they want to look at some files we ask the m to look at during a bughunt, or do two installations, changing the values in between, and not knowing which files are being picked up by FO.