FreeOrion

Forums for the FreeOrion project
It is currently Mon Jul 16, 2018 2:24 pm

All times are UTC




Post new topic Reply to topic  [ 7 posts ] 
Author Message
 Post subject: kind of new here
PostPosted: Mon Mar 12, 2018 1:30 pm 
Offline
Space Krill

Joined: Mon Mar 12, 2018 1:08 pm
Posts: 4
Hi. A long time ago (I think at least 3 years) I added that right click context menu for galactic map and nothing else and then disappeared. Now I'm back. First thing I did now was to add a column to the census report with the number of worlds, see attached screenshots. Looking foreward to adding some more little things before eventually getting bigger things done … if I do not disappear again, that is.


Attachments:
File comment: with corrected number formatting, so that the numbers better align
with-better-number-formatting.png
with-better-number-formatting.png [ 162.51 KiB | Viewed 226 times ]
File comment: screenshot with new census column for populated worlds and two new labels at the bottom (and with bad number formatting for big numbers as it was before)
with-bad-number-formatting.png
with-bad-number-formatting.png [ 133.63 KiB | Viewed 226 times ]


Last edited by stpa on Fri Mar 16, 2018 7:41 pm, edited 1 time in total.
Top
 Profile  
 
 Post subject: Re: kind of new here
PostPosted: Mon Mar 12, 2018 4:44 pm 
Offline
Vacuum Dragon
User avatar

Joined: Mon Apr 10, 2017 4:25 pm
Posts: 653
Great, I like it.
Time to get in touch with the @devs, submit PRs and all that stuff.


Top
 Profile  
 
 Post subject: Re: kind of new here
PostPosted: Mon Mar 12, 2018 9:10 pm 
Offline
Space Krill

Joined: Mon Mar 12, 2018 1:08 pm
Posts: 4
Yes, they did with me ^^ and of course I release the screenshots in this thread and all code & other contributions under GPL v2 (or compatible licence, at the discretion of the FreeOrion team), and I promise to use better indentation in my coding and I will comply with branch naming conventions et cetera, and thank you for liking it


Top
 Profile  
 
 Post subject: Re: kind of new here
PostPosted: Wed Mar 14, 2018 6:51 pm 
Offline
Space Krill

Joined: Mon Mar 12, 2018 1:08 pm
Posts: 4
Next thing, I did a little in-game indentation fixing in addition to indentation in the codebase. The Planet suitability report looked broken, when resizing the Pedia-window it seemed like too many tab signs \t, like in the attached screenshot. Which annoyed me, because in the official download 0.4.7.1 (build 2017-09-03.139ffd9) which I was play(test)ing before it was not broken, so I fixed it. At least for me. No idea how that gets rendered on other platforms since I've got only a mac. But I guess the devs will know how to test on multiple platforms …


Attachments:
File comment: broken tabs / columns in planet suitability report
Bildschirmfoto 2018-03-14 um 19.18.01.png
Bildschirmfoto 2018-03-14 um 19.18.01.png [ 178.62 KiB | Viewed 262 times ]
Top
 Profile  
 
 Post subject: Re: kind of new here
PostPosted: Wed Mar 14, 2018 7:57 pm 
Offline
Programming, Design, Admin
User avatar

Joined: Wed Oct 08, 2003 1:33 am
Posts: 12231
Location: Munich
stpa wrote:
First thing I did now was to add a column to the census report with the number of worlds, see attached screenshots.

Headings indicating what the columns display would be helpful...


Top
 Profile  
 
 Post subject: Re: kind of new here
PostPosted: Sun Mar 18, 2018 10:11 am 
Offline
Space Krill

Joined: Mon Mar 12, 2018 1:08 pm
Posts: 4
I have added the name of the planet of origin to the worldtree special's accounting label for the happiness effect on other planets, which was missing before, and I just wanted to know where the effect came from. This also has helped me to get to know how speciels and effects are handled in general.


Attachments:
File comment: before the change
worldtree_accounting_label_before.png
worldtree_accounting_label_before.png [ 106.24 KiB | Viewed 219 times ]
File comment: with the change
worldtree_accounting_label_after.png
worldtree_accounting_label_after.png [ 148.26 KiB | Viewed 220 times ]
Top
 Profile  
 
 Post subject: Re: kind of new here
PostPosted: Sun Mar 18, 2018 3:08 pm 
Offline
AI Lead, Programmer
User avatar

Joined: Sat Sep 22, 2012 6:25 pm
Posts: 4679
stpa wrote:
I have added the name of the planet of origin to the worldtree special's accounting label for the happiness effect on other planets, which was missing before...
Yes, that's a good catch, please put up a PR for it.

_________________
If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 7 posts ] 

All times are UTC


Who is online

Users browsing this forum: No registered users and 0 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group