FreeOrion

Forums for the FreeOrion project
It is currently Tue Jul 17, 2018 4:18 am

All times are UTC


Forum rules


Always mention the exact version of FreeOrion you are testing.

When reporting an issue regarding the AI, if possible provide the relevant AI log file and a save game file that demonstrates the issue.



Post new topic Reply to topic  [ 5 posts ] 
Author Message
PostPosted: Sun Jun 24, 2018 1:29 am 
Offline
Vacuum Dragon
User avatar

Joined: Mon Apr 10, 2017 4:25 pm
Posts: 653
I find confusing the label of the gaseous metabolism population malus:

GASEOUS_LABEL
Bad Environment

Regardless of the environment (for Sly, gas giant: good, asteroids: uninhabitable, anything else: hostile), you get the gaseous malus, so why call it "bad environment"?
I suggest call it "gaseous metabolism".

Edit: or "very bad/awful population", as it is actually a -50% akin as the -25% of the bad population trait.


Top
 Profile  
 
PostPosted: Sun Jun 24, 2018 3:14 am 
Offline
AI Lead, Programmer
User avatar

Joined: Sat Sep 22, 2012 6:25 pm
Posts: 4679
Oberlus wrote:
I find confusing the label of the gaseous metabolism population malus:
GASEOUS_LABEL
Bad Environment

Regardless of the environment (for Sly, gas giant: good, asteroids: uninhabitable, anything else: hostile), you get the gaseous malus, so why call it "bad environment"?
I suggest call it "gaseous metabolism".


I apparently had somehow managed to not notice what that label actually read-- I agree that 'Bad Environment' does seem somewhat peculiar for a species' native environment. Having just checked this as part of the recent corrections to pop calcs and AI, however, I'll note that the malus only applies when actually on a Gas Giant:
Code:
            scope = Source
            activation = And [
                Planet type = GasGiant
                HasTag name = "GASEOUS"
            ]


So, simply "Gaseous Metabolism" is probably not quite right either.

It could be that a suitable label might be something more specific to Gas Giants like "Crushing Gravity".

I'd suggest opening an Issue about it.

_________________
If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0


Top
 Profile  
 
PostPosted: Sun Jun 24, 2018 5:16 pm 
Offline
Vacuum Dragon

Joined: Tue Sep 30, 2014 10:01 am
Posts: 504
Dilvish wrote:
It could be that a suitable label might be something more specific to Gas Giants like "Crushing Gravity".

As there is no explanation component about where that crushing gravity malus is coming from, we should rather call it "Gas Giant Crushing Gravity", "Gas Giant Environment", "Gas Giant Gravity" or similar...

_________________
Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.


Top
 Profile  
 
PostPosted: Sun Jun 24, 2018 5:18 pm 
Offline
AI Lead, Programmer
User avatar

Joined: Sat Sep 22, 2012 6:25 pm
Posts: 4679
Ophiuchus wrote:
...we should rather call it "Gas Giant Crushing Gravity", "Gas Giant Environment", "Gas Giant Gravity" or similar...

Sure, I like "Gas Giant Crushing Gravity" just fine.

_________________
If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0


Top
 Profile  
 
PostPosted: Sun Jun 24, 2018 5:22 pm 
Offline
Vacuum Dragon
User avatar

Joined: Mon Apr 10, 2017 4:25 pm
Posts: 653
Issue opened: #2177


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 5 posts ] 

All times are UTC


Who is online

Users browsing this forum: No registered users and 0 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
cron
Powered by phpBB® Forum Software © phpBB Group