FreeOrion

I'm on a road trip this week, so will be less available then normal.

Could you explicitly state in your post that you release your contribution under the CC-BY-SA 3.0 license?

If there was an image, it looks like the image didn't attach. The forum can be glitchy with multiple attachments and previewing.

Vezzra wrote: ↑

Fri Jul 03, 2020 1:59 pm

Anyone who wants to provide any kind of input for the changelog, please do so now.

Suggestions for Key Changes would be useful.

I suppose adding another invariance flag or getter like these would be reasonable... named something like TopLevelContentIndependent() perhaps. That would return true if the ValueRef tree has no references to "CurrentContent" in it, meaning no ValueRef::Constant<std::string> with m_value == "Current...

LienRag wrote: ↑

Wed Jul 01, 2020 3:34 am

Where are the log files?

see: https://www.freeorion.org/index.php/Config.xml

FOCS parse errors are also output to stdout when launching the client.

If you script something and it doesn't appear in game, first thing to do is check the client log file for relevant errors. If I paste your script into ST_COATING.focs.txt and put it in the scripting/ship_parts/stealth directory, then start the client, the log contains: 17:34:12.876545 {0x00005aa8} [...

each node in the valueref tree gets this set top down, correctly? And this is set once per value ref as opposed to being set dynamically before evaluation? Yes. Each valueref or condition or effect has a SetTopLevelContent function that is called when its containing content is initialized. That cal...

I am not aware of ValueRefs can return the name of that top level content - do you have an example? Not sure exactly what you want to see, but: https://github.com/freeorion/freeorion/blob/master/universe/ValueRefs.cpp#L445 You are concerned of multiple owners, but I want a (deep) copy, so there wou...

Oberlus wrote: ↑

Tue Jun 23, 2020 6:18 pm

... that can be avoided by using LienRag's idea of a countdown when a empire has no population, adjustable via a game rule...

Perhaps, but that's not an option for v0.4.10, as noted above.

some valuerefs get parsed multiple times (e.g. fuel tanks are parsed four times, reinforced hull tech gets parsed only once) - is this by design or wrong? What is a "valueref" in this context? There are no lists of ValueRefs that just get parsed... they're all attached to content like techs or ship...

But I prefer to not implement death flag support in 0.4.10. Yes; for v0.4.10 there should be, as now, a simple loss condition based on the immediate gamestate. That is currently no planets owned and no ships owned. https://github.com/freeorion/freeorion/pull/3068 makes it no population and no ships...

And what if we want an effect for an unowned outpost? Like a native planet bombarded to zero pop. An unowned outpost isn't a thing. If it had an owner, it would be an outpost for that empire. If it had population but was still unowned, it'd be a neutral native-populated planet. Unowned and no popul...

I'm content to go with whatever reasonable elimination condition is the most popular or for which consensus is reached... be that having no populated planets or ships, no populated planets or colony ships, no populated planets, or something slightly more complicated like no populated planets for 3 t...

Voker57 wrote: ↑

Sun Jun 21, 2020 9:18 pm

I propose for an empire to be declared defeated and all its outposts being dropped when it loses all population.

"loses all population" means "has no populated planets and no colony ships", presumably?

Similar effects are attached to hulls, occasionally set up to only use the hull as a source if the ship isn't owned by an empire.