Search found 21 matches

by orbisvicis
Thu Mar 06, 2014 1:09 am
Forum: Programming
Topic: Some Simple Patches [require OSX & Windows input]
Replies: 19
Views: 2030

Re: Some Simple Patches [require OSX & Windows input]

Don't commit this version, the latest (svn diff) patch only seems to contain file modifications, not additions (only affects CMake). I'll upload a new version when I get some time.
by orbisvicis
Tue Mar 04, 2014 11:08 pm
Forum: Programming
Topic: Some Simple Patches [require OSX & Windows input]
Replies: 19
Views: 2030

Re: Some Simple Patches [require OSX & Windows input]

That said, is there a reason to store a path in GetConfDir() instead of just returning GetRootDataDir()? Consistency across the Linux/OSX/Windows versions. I don't expect GetConfDir to change, and in the linux version GetRootDataDir() does quite a bit of work, so it would be more efficient to only ...
by orbisvicis
Tue Mar 04, 2014 10:34 pm
Forum: Programming
Topic: Support Single Image Library
Replies: 16
Views: 2310

Re: Support Single Image Library

Oh, that's probably because you're not using CMake. The external directory has to be prepended to the header search path* in MSVC and XCode (no idea how). In GG/src/CMakeLists.txt I've added: include_directories(BEFORE external) If there are any other problems, just to make sure can you confirm thes...
by orbisvicis
Tue Mar 04, 2014 6:23 pm
Forum: Programming
Topic: Support Single Image Library
Replies: 16
Views: 2310

Re: Support Single Image Library

FreeOrion maintains a patched version of Boost.GIL 1.51 in-tree which is used (instead of system Boost.GIL) during builds. I am suggesting updating (ie, committing to the FreeOrion svn*) FreeOrion's Boost.GIL to the latest upstream Boost version**, which will obviate the effort needed to maintain a ...
by orbisvicis
Tue Mar 04, 2014 6:21 pm
Forum: Programming
Topic: Build Fixes
Replies: 10
Views: 1134

Re: Build Fixes

The patch attempts to fix two of the following warnings, though of course tests are good: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] First (exe_path_size == static_cast<size_t>(-1)) compares the (signed) variable against, on 32-bit systems, 4294967295. Of co...
by orbisvicis
Tue Mar 04, 2014 2:12 am
Forum: Programming
Topic: Support Single Image Library
Replies: 16
Views: 2310

Re: Support Single Image Library

Looks like DevIL/ResIL support is staying, here is a patch to that effect. Identical to the one proposed in the other thread, except not in git-diff format.
by orbisvicis
Tue Mar 04, 2014 2:02 am
Forum: Programming
Topic: Support Single Image Library
Replies: 16
Views: 2310

Re: Support Single Image Library

SVN/regular diff version
by orbisvicis
Tue Mar 04, 2014 1:26 am
Forum: Programming
Topic: Support Single Image Library
Replies: 16
Views: 2310

Re: Support Single Image Library

I've explored updating to upstream GIL, instructions follow. Any thoughts? First update GIL: cd FreeOrion/GG/src #rm -r GIL mkdir external; cd external svn checkout http://svn.boost.org/svn/boost/trunk/boost/gil/ Then apply the attached patch. It compiles fine and though I have yet to test FreeOrion...
by orbisvicis
Tue Mar 04, 2014 1:15 am
Forum: Programming
Topic: Some Simple Patches [require OSX & Windows input]
Replies: 19
Views: 2030

Re: Some Simple Patches [require OSX & Windows input]

Made some large changes. Hopefully the patch is no longer in violation of the stylistic guidelines. When reconfiguring the INSTALL_PREFIX the INSTALL_SYSCONFDIR doesn't update properly. Is this intended? Also when configuring with 'CMAKE_INSTALL_PREFIX:PATH=/usr' set we will have 'CMAKE_INSTALL_SYSC...
by orbisvicis
Tue Mar 04, 2014 12:59 am
Forum: Programming
Topic: Build Fixes
Replies: 10
Views: 1134

Re: Build Fixes

Presto. Merge?
by orbisvicis
Sun Mar 02, 2014 2:42 am
Forum: Programming
Topic: Support Single Image Library
Replies: 16
Views: 2310

Re: Support Single Image Library

There is also the possibility to use gil-contribution (https://code.google.com/p/gil-contributions/), which I believe is used as a "staging" repository by the maintainer of Boost.GIL. There was a push to merge the latest GIL extensions (with PNG gray_alpha support) into Boost trunk in earl...
by orbisvicis
Sat Mar 01, 2014 10:34 pm
Forum: Programming
Topic: Support Single Image Library
Replies: 16
Views: 2310

Re: Support Single Image Library

To use the boost GIL we would need to identify if there are still such grayscale images and convert those to rgb or rgba variants find . -type f -iname '*png' -exec identify -format "%[channels] %A %z %d/%f" '{}' \; | awk '{if($1 == "graya" && ($3 == 8 || $3 == 16)){prin...
by orbisvicis
Sat Mar 01, 2014 10:04 pm
Forum: Programming
Topic: Build Fixes
Replies: 10
Views: 1134

Re: Build Fixes

Only warnings. That's what I get for blindly fixing warnings, no idea it was an external library. It seems quite dead (2 yr. old patch still to be applied) so I won't bother. I know the code is licensed GPL2+, do I have to acknowledge this somewhere? Anyway, here is a freeorion-only svn-style patch.
by orbisvicis
Sat Mar 01, 2014 8:56 pm
Forum: Programming
Topic: Build Fixes
Replies: 10
Views: 1134

Build Fixes

Split into two categories. Might be some CR line-ending issues with the patches.
by orbisvicis
Sat Mar 01, 2014 5:02 pm
Forum: Programming
Topic: Support Single Image Library
Replies: 16
Views: 2310

Support Single Image Library

GG supports both Boost/Adobe GIL and ResIL/DevIL. To consolidate resources the project may be interested in only supporting a single image library. Options Support ResIL/DevIL only ResIL/DevIL is cross-platform but I've only tested on linux. Supports more image formats, but I don't know if the code ...