Search found 214 matches

by mem359
Fri Jun 09, 2017 1:47 pm
Forum: FreeOrion Project
Topic: What to do? Mac, hidden visibility, and Boost
Replies: 13
Views: 739

Re: What to do? Mac, hidden visibility, and Boost

I have a local build where the Logger is working correctly on my Mac. I will be updated the SDK and FO PRs to have the least amount of modifications needed to get things working. This is what I'm planning on doing for the Mac builds: - Build Boost libraries as shared instead of static. Necessary to ...
by mem359
Mon Jun 05, 2017 10:36 pm
Forum: Support
Topic: Problem colonizing a toxic planet for Chato
Replies: 4
Views: 511

Re: Problem colonizing a toxic planet for Chato

Starionx wrote:When I look at the planet suitability, it's Good (-23).
The maximum population number is more important than if the planet is Good, Poor, or Hostile.

You'll want a green positive number for the colonizing species, instead of a red (negative) one.
by mem359
Mon Jun 05, 2017 4:23 pm
Forum: Programming
Topic: SDK refactoring - drop some of the Boost library builds
Replies: 4
Views: 448

Re: SDK refactoring - drop some of the Boost library builds

No, especially if the dependencies are within the headers only. Unless the headers are included during the build into a compilation unit and the compiler can't locate the missing header the SDK build is not able to tell you that it is incomplete. Only building freeorion itself can tell you that. Ah...
by mem359
Mon Jun 05, 2017 2:57 pm
Forum: Programming
Topic: SDK refactoring - drop some of the Boost library builds
Replies: 4
Views: 448

Re: SDK refactoring - drop some of the Boost library builds

Thanks for your reply. I'll look through the code, in case any of those situations have changed. atomic -- must be kept, as it is an implicit dependency of boost::thread and boost::log container -- must be kept, as is an implicit dependency of boost::thread exception -- must be kept, as is an implic...
by mem359
Mon Jun 05, 2017 1:20 pm
Forum: Programming
Topic: SDK refactoring - drop some of the Boost library builds
Replies: 4
Views: 448

SDK refactoring - drop some of the Boost library builds

For the SDK builds, we have a list of Boost library builds. I am proposing making that list smaller. At least for the Mac, these libraries are not being used by FO, or by any of the other Boost libraries that are being used. I wanted to get feedback, in case there are dependencies in the Windows bui...
by mem359
Mon Jun 05, 2017 12:46 pm
Forum: FreeOrion Project
Topic: What to do? Mac, hidden visibility, and Boost
Replies: 13
Views: 739

Re: What to do? Mac, hidden visibility, and Boost

Marcel, please reconsider. I think you jumped to some wrong assumptions. (Some are my fault, so understandable.) I was sick of... When I am complaining about things, that was mostly griping about the learning curve for CMake, and not knowing for FO what was intended and what was temporary. The forme...
by mem359
Mon Jun 05, 2017 3:24 am
Forum: FreeOrion Project
Topic: What to do? Mac, hidden visibility, and Boost
Replies: 13
Views: 739

Re: What to do? Mac, hidden visibility, and Boost

There was some useful information on the 3-year old thread CMake and the Windows FO SDK . For the Xcode build, I want to have the Common dylib target link to the Parse dylib, and to remove the flag "undefined dynamic_lookup". Turns out that was in the plans way back then. That flag was hiding an und...
by mem359
Sat Jun 03, 2017 1:07 pm
Forum: FreeOrion Project
Topic: What to do? Mac, hidden visibility, and Boost
Replies: 13
Views: 739

Re: What to do? Mac, hidden visibility, and Boost

That is 224 fewer warnings, from the last time I checked. Awesome. 224 X :D Well, there are still the "semantic issue" warnings (mostly suggesting to use more parentheses to make the order of operations clearer). The next roadblock are the Boost shared libraries. (The Boost guide says that Log will...
by mem359
Thu Jun 01, 2017 8:48 pm
Forum: FreeOrion Project
Topic: What to do? Mac, hidden visibility, and Boost
Replies: 13
Views: 739

Re: What to do? Mac, hidden visibility, and Boost

I'm down to 5 linker errors, so I'm no longer drowning in red. Turns out that the Boost Locale library also has a Windows-specific setting, which wasn't obvious at first glance. In locale/definitions.hpp, it is required that BOOST_HAS_DECLSPEC is defined before doing the visibility settings. This is...
by mem359
Thu Jun 01, 2017 3:30 pm
Forum: FreeOrion Project
Topic: What to do? Mac, hidden visibility, and Boost
Replies: 13
Views: 739

Re: What to do? Mac, hidden visibility, and Boost

Does linking dynamically (instead of statically) without visibility=hidden fix all of the linker errors? Have you tried the change to the iostreams library? Does it also result in a clean build? What is the difference in shared library size, boost and fo? What is the difference in build times? If w...
by mem359
Thu Jun 01, 2017 2:02 pm
Forum: FreeOrion Project
Topic: What to do? Mac, hidden visibility, and Boost
Replies: 13
Views: 739

Re: What to do? Mac, hidden visibility, and Boost

Do we drop visibility=hidden ... What consequence would that have? The use of visibility=hidden in the main FO code was introduced before my time. :mrgreen: We have FO_COMMON_API and FO_PARSE_API sprinkled throughout the code specifically to handle "hidden". I didn't want to make a fairly big chang...
by mem359
Thu Jun 01, 2017 11:56 am
Forum: FreeOrion Project
Topic: What to do? Mac, hidden visibility, and Boost
Replies: 13
Views: 739

What to do? Mac, hidden visibility, and Boost

I've reached an impasse for the Mac build. I need to hear what steps the FO group want to take next. The FO code is compiled with "-fvisibility=hidden", which really means that the SDK libraries should also be built that way too. (In for a penny, in for a pound.) I've been working on that. I've come...
by mem359
Thu May 25, 2017 9:27 pm
Forum: FreeOrion Project
Topic: Proposal: Switch the MacOSX builds from i386 to x86_64
Replies: 3
Views: 573

Re: Proposal: Switch the MacOSX builds from i386 to x86_64

The PR for the Mac SDK has been submitted. https://github.com/freeorion/freeorion-sdk/pull/29 The PR for the FO has also been submitted, but that will need to be synchronized with the SDK commit. https://github.com/freeorion/freeorion/pull/1585 At least on my home machine, I was able to successfully...
by mem359
Tue May 23, 2017 6:16 pm
Forum: FreeOrion Project
Topic: Proposal: Switch the MacOSX builds from i386 to x86_64
Replies: 3
Views: 573

Re: Proposal: Switch the MacOSX builds from i386 to x86_64

What is holding me up currently is using "-fvisibility=hidden" for the SDK. When I use those built libraries for the FO clients, I get linking errors all over the place from missing Boost symbols. (It might be a problem with how the FO code uses Boost, if it is calling now-hidden functions, but I ne...
by mem359
Tue May 23, 2017 3:20 am
Forum: FreeOrion Project
Topic: Proposal: Switch the MacOSX builds from i386 to x86_64
Replies: 3
Views: 573

Proposal: Switch the MacOSX builds from i386 to x86_64

This is for people (like me) who are running the game on a Mac. I am suggesting that we switch the SDK and FO from the current 32-bit builds (i386) to 64 bits (x86_64). I've been tinkering around with both github repositories (for other reasons), and am willing to make the necessary pull requests fo...