Search found 1062 matches

by tzlaine
Thu Sep 29, 2011 11:02 am
Forum: Programming
Topic: [PATCH] WithinStarlaneJumps implementation
Replies: 78
Views: 4854

Re: [PATCH] WithinStarlaneJumps implementation

A couple of notes about your original patch, Carsten. First, this: @@ -4294,16 +4402,15 @@ ObjectSet& from_set = search_domain == MATCHES ? matches : non_matches; ObjectSet& to_set = search_domain == MATCHES ? non_matches : matches; - ObjectSet::iterator it = from_set.begin(); - ObjectSet::iterator ...
by tzlaine
Thu Sep 29, 2011 10:52 am
Forum: Programming
Topic: [PATCH] WithinStarlaneJumps implementation
Replies: 78
Views: 4854

Re: [PATCH] WithinStarlaneJumps implementation

Super cool tzlaine =) I'm quite happy the boilerplate is gone. At first, I was a little worried storing the distances forever uses lots of memory (compare: I store two numbers per target. you store two numbers per every possible pair of vertices in the graph. That doesnt scale well) and Ω(VE) set-u...
by tzlaine
Thu Sep 29, 2011 3:28 am
Forum: Programming
Topic: [PATCH] WithinStarlaneJumps implementation
Replies: 78
Views: 4854

Re: [PATCH] WithinStarlaneJumps implementation

Ugh. I'll have to tackle this tomorrow. Sorry for the breakage.
by tzlaine
Thu Sep 29, 2011 2:34 am
Forum: Programming
Topic: [PATCH] WithinStarlaneJumps implementation
Replies: 78
Views: 4854

Re: [PATCH] WithinStarlaneJumps implementation

Geoff the Medio wrote:It's probably possible to arrange such a case, by doing something like...
If you could gin up a patch that you've tested and know works, I would really like to test it out.
by tzlaine
Thu Sep 29, 2011 2:32 am
Forum: Programming
Topic: [PATCH] WithinStarlaneJumps implementation
Replies: 78
Views: 4854

Re: [PATCH] WithinStarlaneJumps implementation

These results make me wonder whether SystemsWithinJumps() is actually useful. It should never be much slower than the original implementation, and there are many cases where it's a lot faster, but they may be irrelevant to either the test game or the current FreeOrion at all, and it's a lot of code...
by tzlaine
Thu Sep 29, 2011 2:11 am
Forum: Programming
Topic: [PATCH] WithinStarlaneJumps implementation
Replies: 78
Views: 4854

Re: [PATCH] WithinStarlaneJumps implementation

[*]I'm unsure about the huge discrepancy between real time and CPU time. The ratio makes me suspect that a CPU second means running one second on all the CPU cores, and freeorion is currently unable to fully utilize my 8-way parallel configuration. It might also simply be spending lots of time perf...
by tzlaine
Thu Sep 29, 2011 2:07 am
Forum: Programming
Topic: [PATCH] WithinStarlaneJumps implementation
Replies: 78
Views: 4854

Re: [PATCH] WithinStarlaneJumps implementation

Carsten, as you can see above, I have been unable to reproduce all your results. The optimized version runs in ~5s for me as for you, but I'm getting ~20s for the vanilla FO you first started investigating -- not minutes. I'm really curious what might be happening here, which is why I posted such d...
by tzlaine
Wed Sep 28, 2011 2:28 am
Forum: Programming
Topic: [PATCH] WithinStarlaneJumps implementation
Replies: 78
Views: 4854

Re: [PATCH] WithinStarlaneJumps implementation

But doesn't FO use Boost 1.44 currently? v0.3.17 uses Boost 1.46.1 on Windows. I don't know what's used on OSX. I wouldn't worry too much about this. For platforms with the same type-sizes (sizeof(some_type) is the same for both) and the same endiannesses, the save files should be portable. And the...
by tzlaine
Wed Sep 28, 2011 12:37 am
Forum: Programming
Topic: [PATCH] WithinStarlaneJumps implementation
Replies: 78
Views: 4854

Re: [PATCH] WithinStarlaneJumps implementation

Some timings. This was done on a 4-core machine. Each processor is reported as "Intel(R) Core(TM) i7 CPU Q 740 @ 1.73GHz". I'm running 64-bit Linux. I built using GCC 4.5 with an optimized build. I ran FO like this: time ./freeorion --load ~/.freeorion/save/FreeOrion_Eoerg_Arghjoh_0407.sav --auto-ad...
by tzlaine
Tue Sep 27, 2011 9:35 pm
Forum: Programming
Topic: [PATCH] WithinStarlaneJumps implementation
Replies: 78
Views: 4854

Re: [PATCH] WithinStarlaneJumps implementation

It just says "Error reading save file." I'll rebuild with boost 1.47 and see if that fixes things. Geoff, does this save file work for you with a Boost 1.44 build? I don't have a boost 1.44 build, but I've tried loading it with v0.3.17 and the latest SVN built with 1.46.1 and booth have the same er...
by tzlaine
Tue Sep 27, 2011 4:25 pm
Forum: Programming
Topic: [PATCH] WithinStarlaneJumps implementation
Replies: 78
Views: 4854

Re: [PATCH] WithinStarlaneJumps implementation

I'm building against boost 1.46.1. Note that my changes are relatively small. The patches are ... I understand you changes, I'm sure you'll understand that reproducability is pretty important before we complete an evaluation of a patch. Also, I think that while some parts of your patch are quite cl...
by tzlaine
Tue Sep 27, 2011 4:20 pm
Forum: Programming
Topic: [PATCH] WithinStarlaneJumps implementation
Replies: 78
Views: 4854

Re: [PATCH] WithinStarlaneJumps implementation

It just says "Error reading save file." I'll rebuild with boost 1.47 and see if that fixes things. Geoff, does this save file work for you with a Boost 1.44 build?
by tzlaine
Mon Sep 26, 2011 9:17 pm
Forum: Programming
Topic: [PATCH] WithinStarlaneJumps implementation
Replies: 78
Views: 4854

Re: [PATCH] WithinStarlaneJumps implementation

I have so far been unable to reproduce the several-minutes-per-turn-update in the OP by playing through the game myself. Also, the save attached to the OP does not work for me (I just gunzip'd it -- should I have done something else?). Without an A-B timing comparison, it's hard to evaluate these pa...
by tzlaine
Fri Sep 23, 2011 1:16 pm
Forum: Programming
Topic: [PATCH] WithinStarlaneJumps implementation
Replies: 78
Views: 4854

Re: [PATCH] WithinStarlaneJumps implementation

Nice work, Carsten! Geoff, I did take an in-depth look at the patch, and it looks solid to me. In the process, I was looking at the Boost.Graph docs and noticed that an A* search was added some time ago. We may want to use this instead of Dijkstra in ShortestPathImpl(). Carsten, are you game to inve...
by tzlaine
Thu Sep 01, 2011 5:06 pm
Forum: Compile
Topic: GG documentation not generated
Replies: 2
Views: 647

Re: GG documentation not generated

Could you file a bug on this on the GG SF.net page, so it doesnt get lost? It looks like maybe an in-source vs. out-of-source build.