Search found 212 matches

by Nagilum
Mon Jan 13, 2014 9:49 pm
Forum: Programming
Topic: FSM Assertions
Replies: 37
Views: 2425

Re: FSM Assertions

Just doing some string matching from the message leads me to client/human/HumanClientFSM.cpp and this part: 73 IntroMenu::~IntroMenu() { 74 if (TRACE_EXECUTION) Logger().debugStream() << "(HumanClientFSM) ~IntroMenu"; 75 if (GetOptionsDB().Get<bool>("tech-demo")) 76 Client().Remove(Client().GetClien...
by Nagilum
Mon Jan 13, 2014 9:21 pm
Forum: Programming
Topic: FSM Assertions
Replies: 37
Views: 2425

Re: Up-to-date FreeOrion Mac-SDK and build - Test please!

adrian_broher wrote:FYI: I get these error message since I started developing for FO.
Ah, thanks! Then I'll release the Linux builds when ready.
by Nagilum
Mon Jan 13, 2014 8:57 pm
Forum: Programming
Topic: FSM Assertions
Replies: 37
Views: 2425

FSM Assertions

New test build (SVN 6637) available for Mac OSX 10.6 on sourceforge. I'm just testing the Linux build (asuming they all behave the same) I get these warnings on the console: freeorion: /usr/include/boost/cast.hpp:97: Target boost::polymorphic_downcast(Source*) [with Target = HumanClientFSM*; Source...
by Nagilum
Mon Jan 13, 2014 8:42 pm
Forum: Compile
Topic: cppcheck svn6612
Replies: 17
Views: 3112

Re: cppcheck svn6637

I think the existing code is specifically set up to not have a main function on OSX, as it's provided elsewhere, but the source file is still compiled to get the other functions defined in it. Ah, I see! Thanks! Ok, then how about this: 50 #ifndef FREEORION_MACOSX 51 #ifdef FREEORION_WIN32 52 int w...
by Nagilum
Sun Jan 12, 2014 12:07 pm
Forum: Compile
Topic: cppcheck svn6612
Replies: 17
Views: 3112

Re: cppcheck svn6612

This attached patch would fix it. The result would be: #ifndef FREEORION_WIN32 int main(int argc, char* argv[]) { // copy command line arguments to vector std::vector<std::string> args; for (int i = 0; i < argc; ++i) args.push_back(argv[i]); // set options from command line or config.xml, or generat...
by Nagilum
Sun Jan 12, 2014 8:35 am
Forum: Compile
Topic: cppcheck svn6612
Replies: 17
Views: 3112

Re: cppcheck

Running cppcheck against svn6631 I see something new (in bold): [Empire/Empire.cpp:2189]: (error) Dangerous iterator comparison using operator< on 'std::deque'. [GG/src/GIL/extension/io/io_error.hpp:42]: (error) Resource leak: fp [UI/Sound.cpp:265] -> [UI/Sound.cpp:273]: (error) Iterator 'it' used a...
by Nagilum
Sat Jan 11, 2014 9:26 am
Forum: Compile
Topic: cppcheck svn6612
Replies: 17
Views: 3112

Re: cppcheck svn6612

Done, thanks! :)
by Nagilum
Fri Jan 10, 2014 10:33 pm
Forum: Compile
Topic: cppcheck svn6612
Replies: 17
Views: 3112

Re: cppcheck svn6612

Ok, thanks! As a result I propose this patch: --- log4cpp/src/StringUtil.cpp.orig 2014-01-10 23:27:11.971782845 +0100 +++ log4cpp/src/StringUtil.cpp 2014-01-10 21:49:46.875955548 +0100 @@ -66,6 +66,7 @@ delete [] buffer; buffer = new char[size]; } + delete [] buffer; } std::string StringUtil::trim(c...
by Nagilum
Fri Jan 10, 2014 12:20 pm
Forum: Compile
Topic: cppcheck svn6612
Replies: 17
Views: 3112

Re: cppcheck svn6612

[universe/ObjectMap.h:53]: (portability) The extra qualification 'iterator::' is unnecessary and is considered an error by many compilers. Don't understand that... std::map<int, boost::shared_ptr<T> >::iterator::operator++(); It's calling operator++() of the iterator class, not of the map. How is t...
by Nagilum
Thu Jan 09, 2014 10:58 am
Forum: Compile
Topic: cppcheck svn6612
Replies: 17
Views: 3112

cppcheck svn6612

Since it recently made news I thought it would be interesting to run cppcheck(v1.61) over FO. Overall it looks pretty good: freeorion_0.4.3+svn6612/FreeOrion# find . -name \*.cpp | cppcheck --file-list=- -j 4 --enable=portability -q [universe/ObjectMap.h:53]: (portability) The extra qualification 'i...
by Nagilum
Wed Jan 01, 2014 7:53 pm
Forum: Compile
Topic: svn6592 / no LIBRARY DESTINATION for shared library target
Replies: 5
Views: 1392

Re: svn6592 / no LIBRARY DESTINATION for shared library targ

Just to close the matter.
Everything works and the packages are building again.
I'll probably not upload new builds though since the chances between 6591 and 6594 are minimal.
by Nagilum
Wed Jan 01, 2014 1:03 pm
Forum: Compile
Topic: svn6592 / no LIBRARY DESTINATION for shared library target
Replies: 5
Views: 1392

Re: svn6592 / no LIBRARY DESTINATION for shared library targ

Hmm, actually they are build just land in a different location than before.
Sorry for the confusion.
by Nagilum
Wed Jan 01, 2014 1:00 pm
Forum: Compile
Topic: svn6592 / no LIBRARY DESTINATION for shared library target
Replies: 5
Views: 1392

Re: svn6592 / no LIBRARY DESTINATION for shared library targ

Hmm, the normal build doesn't seem to build the GiGi libs.
So I need to build them separately - no?
by Nagilum
Wed Jan 01, 2014 11:51 am
Forum: Compile
Topic: svn6592 / no LIBRARY DESTINATION for shared library target
Replies: 5
Views: 1392

Re: svn6592 / no LIBRARY DESTINATION for shared library targ

That's just how the Debian package does/did it historically.
Let me try it without..
by Nagilum
Wed Jan 01, 2014 10:18 am
Forum: Compile
Topic: svn6592 / no LIBRARY DESTINATION for shared library target
Replies: 5
Views: 1392

svn6592 / no LIBRARY DESTINATION for shared library target

The changes in svn commit 6592 break the build for me: [email protected]:~/freeorion-0.4.3+svn6594/debian# cmake ../FreeOrion/GG -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_VERBOSE_MAKEFILE=ON -DBUILD_DOCUMENTATION=off -DBUILD_TUTORIALS=off -DBUILD_OGRE_DRIVER=ON -DBUILD_OGRE_OIS_PLUGIN=ON -DLIB_SUFFIX=/freeorio...