Search found 58 matches

by spikethehobbit
Fri Nov 27, 2015 4:30 pm
Forum: Support
Topic: Somemonsters and predesigned AI ships have weapon strength 0
Replies: 5
Views: 1146

Somemonsters and predesigned AI ships have weapon strength 0

Some monsters and predesigned ships have weapons listed with strength 0. Naturally, they do no damage when attacking. Not all monsters or ships are affected, but it seems mostly consistent. built from source on Linux amd64 current master is 34961f990fb07a421dbfe49e16c713213935f081 Changed source fil...
by spikethehobbit
Tue Sep 04, 2012 3:44 am
Forum: Programming
Topic: [FTBFS] [patch] svn 5202 with gcc 4.7
Replies: 2
Views: 113

Re: [FTBFS] [patch] svn 5202 with gcc 4.7

Sorry about that.

Yes, that is a git patch. It looks like SVN uses 'patch -p0' instead of -p1. This should fix it. I'll update my settings for the future.

I'm not familiar with using patch on windows, so I'm not 100% sure. If this patch doesn't apply cleanly, please let me know.
by spikethehobbit
Mon Sep 03, 2012 11:33 pm
Forum: Programming
Topic: [FTBFS] [patch] svn 5202 with gcc 4.7
Replies: 2
Views: 113

[FTBFS] [patch] svn 5202 with gcc 4.7

This patch enabled compilation with gcc 4.7

summary of changes:

GG/GG/adobe/closed_hash.hpp
make member selector explicit

GG/GG/adobe/cmath.hpp
gcc 4 has C99 support in math.h in all versions, both current and planned
by spikethehobbit
Wed Aug 29, 2012 10:15 am
Forum: Programming
Topic: SVN 5179 crash to desktop loading font
Replies: 13
Views: 367

[PATCH] font corruption in GiGi

This patch fixes the buffer overrun and font corruption. It supersedes the Font.cpp.diff patch submitted earlier in thread. Don't use that one. Summary of changes: Modifies Font::Init glyph precaching to take into account glyphs of different heights, including broken fonts that do not honour m_heigh...
by spikethehobbit
Wed Aug 29, 2012 3:54 am
Forum: Programming
Topic: SVN 5179 crash to desktop loading font
Replies: 13
Views: 367

[PATCH-prelim] Re: SVN 5179 crash to desktop loading font

This patch doesn't actually fix the root problem, but it prevents the buffer overflow. Most text still shows as before. zhur's patch seems to work correctly for what it does, but I'm still showing text corruption (dots and lines above and below text) that I believe is caused by this bug, that is gly...
by spikethehobbit
Tue Aug 28, 2012 8:17 pm
Forum: Programming
Topic: SVN 5179 crash to desktop loading font
Replies: 13
Views: 367

Re: SVN 5179 crash to desktop loading font

Test suite errors are the same with vanilla GiGi. It looks like the tests assume MS Windows widgets, but on my system it is using Gtk. At this point I am working on the assumption that the buffer overflow in font glyph generation is causing arbitrary memory corruption. The startup code is largely de...
by spikethehobbit
Tue Aug 28, 2012 9:03 am
Forum: Programming
Topic: SVN 5179 crash to desktop loading font
Replies: 13
Views: 367

Re: SVN 5179 crash to desktop loading font

@zhur that looks suspiciously similar. Heap errors can show up in odd ways.

Fixing whitespace in GG/libltdl had no effect.
It seems GiGi has a test suite, and 24 out of 200 fail. Not sure if related.
I'll try this thing under a debugger next, then start bisecting.
by spikethehobbit
Tue Aug 28, 2012 7:56 am
Forum: Programming
Topic: SVN 5179 crash to desktop loading font
Replies: 13
Views: 367

Re: SVN 5179 crash to desktop loading font

Commenting out line 1312 erases text, but no more crash.

It worked before the GiGi merger. The fixes to building GiGi on Linux may be the culprit, since those scripts are rather hairy, and whitespace sensitive. I will go over those again.
by spikethehobbit
Tue Aug 28, 2012 7:13 am
Forum: Programming
Topic: SVN 5179 crash to desktop loading font
Replies: 13
Views: 367

Re: SVN 5179 crash to desktop loading font

No, reverting that patch does not fix it. Running under valgrind only shows two errors before valgrind itself faults. First is an overlapping memcpy in libasound. At worst this should produce corrupted audio output. It seems unlikely to be the culprit. Second is an out-of-bounds write at GG/src/Font...
by spikethehobbit
Tue Aug 28, 2012 5:02 am
Forum: Programming
Topic: SVN 5179 crash to desktop loading font
Replies: 13
Views: 367

Re: SVN 5179 crash to desktop loading font

MALLOC_CHECK_=3 ./freeorion

segfaults at GG/src/Font.cpp @ 1318
temp_glyph_data[c] =
TempGlyphData(...)

the crash itself is in the heap check done glibc, so this appears to be a corrupted heap
by spikethehobbit
Tue Aug 28, 2012 4:57 am
Forum: Programming
Topic: SVN 5179 crash to desktop loading font
Replies: 13
Views: 367

SVN 5179 crash to desktop loading font

font is default/DejaVuSans-Bold.ttf GG/src/Font.cpp @ 1344 // create opengl texture from buffer(s) and release buffer(s) for (std::size_t i = 0; i < buffer_vec.size(); ++i) { boost::shared_ptr<Texture> temp_texture(new Texture); temp_texture->Init(X0, Y0, buffer_sizes .x, buffer_sizes .y, BUF_WIDTH,...
by spikethehobbit
Tue Aug 28, 2012 3:53 am
Forum: Programming
Topic: [FTBFS] [PATCH] SVN 5179 gcc error
Replies: 0
Views: 545

[FTBFS] [PATCH] SVN 5179 gcc error

gcc does not like 'typename' outside of a template declaration This patch reverts 2nd half of 5179 @@ -201,17 +201,17 @@ UI/ObjectListWnd.cpp: EnumRow(enumT value, GG::Y row_height) : GG::ListBox::Row(GG::X1, row_height, "EnumRow"), m_value(value) { SetChildClippingMode(ClipToClient); - const std::s...
by spikethehobbit
Mon Aug 27, 2012 8:11 pm
Forum: Programming
Topic: [BUG] SVN 5177 gives compile error on OSX
Replies: 3
Views: 186

Re: [BUG] SVN 5177 gives compile error on OSX

It shouldn't compile at all, even under windows. a few more things: universe/Condition.h line 544 const ValueRef::ValueRefBase<int>* High() const { m_since_turn_high; } should be const ValueRef::ValueRefBase<int>* High() const { return m_since_turn_high; } lines 186, 217 const ValueRef::ValueRefBase...