There were quite a number of desired behaviors here; knowing if any of them worked, or none of them, would help focus a review of the script. Although the OP's phrasing does somewhat suggest that nothing happened, it's also possible that the script did something, but just nothing right. Making an assumption about that when the OP could simply tell us doesn't seem like a good practice.em3 wrote:I think that the poster means that the desired behavior is not reached...Geoff the Medio wrote:What does "it just dont work!" mean? You could be more specific without quoting a specific error message...
And Lo! while I was writing this the OP has posted and it sounds like indeed, some portions did work. Ok, and how while I was writing the rest of this the OP posted again and said that nothing worked. hmm. I'll address the rest of this to the OP.
StGW44 -- I'll start with what struck me at first -- I suggest you be more consistent with indentations; that would make reviewing scripts like this easier -- it looks like there are a number of places where you didn't indent, and others where you dedented when you should have indented, or else there is a mixture of tabs and spaces that is not displaying well here. Also please show the entire EffectsGroup, not just the scope. It looks like you have tested part of it since you say one part of the scope worked, it would help if you explained that a little more in the accompanying text.
Looking over it a little more I am wondering if the new OrderedBombardedBy condition applies to buildings, or only planets. Why don't you try the much simpler
Code: Select all
scope = And [
Building
ContainedBy OrderedBombardedBy condition = Source
]