[Nov. 20 test build (e6848d8)] Accretion disc inconsistency

For topics that do not fit in another sub-forum.
Post Reply
Message
Author
User avatar
alleryn
Space Kraken
Posts: 112
Joined: Sun Nov 19, 2017 6:32 pm

[Nov. 20 test build (e6848d8)] Accretion disc inconsistency

#1 Post by alleryn » Thu Nov 23, 2017 8:03 pm

I guess this is a minor thing, but is accretion disc a field or a special? I guess it can be both, but it seems a bit confusing.
  • It's listed twice in the pedia, both in specials and in fields.
  • It doesn't show up as a special in the Obects screen or on the planets themselves.
  • In the supply meter it's referred to as "Special" Accretion Disc
Overall, this is something of an oddball entity (as far as i know... are there other things that are similar that i haven't run into?).

It behaves more like a "system special" than a normal planetary special, and doesn't really behave like any of the other fields afaik.

It's also pretty easy to overlook at the moment, since it doesn't show up as a planetary special, which can be annoying. Thoughts?

Hyperant
Space Krill
Posts: 8
Joined: Sat Nov 11, 2017 1:33 am

Re: [Nov. 20 test build (e6848d8)] Accretion disc inconsiste

#2 Post by Hyperant » Thu Nov 23, 2017 8:15 pm

I would say it is similar to those field types such as the molecular cloud in that it affects all objects within its sphere of influence.

So the accretion disc would be one except it is only large enough to fit one system in it.

User avatar
alleryn
Space Kraken
Posts: 112
Joined: Sun Nov 19, 2017 6:32 pm

Re: [Nov. 20 test build (e6848d8)] Accretion disc inconsiste

#3 Post by alleryn » Thu Nov 23, 2017 8:56 pm

Hyperant wrote:I would say it is similar to those field types such as the molecular cloud in that it affects all objects within its sphere of influence.

So the accretion disc would be one except it is only large enough to fit one system in it.
That's sort of like saying a point is just a very small circle, which i suppose it is, but there's a reason they call it degenerate.

User avatar
MatGB
Creative Contributor
Posts: 3310
Joined: Fri Jun 28, 2013 11:45 pm

Re: [Nov. 20 test build (e6848d8)] Accretion disc inconsiste

#4 Post by MatGB » Fri Nov 24, 2017 12:04 am

The disc is one of three system specials, and will show up in Objects as long as you set the filters to show systems, although I'm going to check tomorrow as I think I can see some on my map that aren't there.
https://github.com/freeorion/freeorion/ ... C.focs.txt

But, it generates a field effect

Code: Select all

    effectsgroups = [
        EffectsGroup
            scope = Source
            activation = Turn high = 0
            effects = CreateField type = "FLD_ACCRETION_DISC" size = 20

        EffectsGroup
            scope = And [
                Planet
                ContainedBy Source
            ]
            effects = SetMaxSupply value = Value - 1
]
not actually sure if it needs to but Sloth is a way better scripter than I'll ever be so there were probably reasons. So it's both a special and a field, so should appear in both.
Mat Bowles

Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.

User avatar
alleryn
Space Kraken
Posts: 112
Joined: Sun Nov 19, 2017 6:32 pm

Re: [Nov. 20 test build (e6848d8)] Accretion disc inconsiste

#5 Post by alleryn » Fri Nov 24, 2017 12:38 am

MatGB wrote: and will show up in Objects as long as you set the filters to show systems
Oh, nice, i hadn't thought to do that, i usually leave mine on planets or occasionally switch it to fleets. Thanks for the response.

User avatar
Dilvish
AI Lead, Programmer
Posts: 4685
Joined: Sat Sep 22, 2012 6:25 pm

Re: [Nov. 20 test build (e6848d8)] Accretion disc inconsiste

#6 Post by Dilvish » Fri Nov 24, 2017 10:15 am

alleryn wrote:It's also pretty easy to overlook at the moment, since it doesn't show up as a planetary special, which can be annoying. Thoughts?
I also have found it easy to overlook. I think I've been burned by it often enough that I now am sufficiently diligent in checking for it, but I still find its limited display compared to its significance to be conceptually annoying. I think I would be far happier with a slightly different approach, which instead had the special, when at the system level, only create the field (if really necessary) and apply planetary-level copies of itself to any planet within the system that didn't already have the planetary level special, and then at the planet level have it create the supply malus. That way it wouldn't be so easy to overlook the malus when outposting a planet.
MatGB wrote:not actually sure if it needs to but Sloth is a way better scripter than I'll ever be so there were probably reasons. So it's both a special and a field, so should appear in both.
I will tentatively guess that he found it necessary to get the graphic to apply properly. It seems to me like the only other thing the field aspect could be accomplishing is simply making the thing locatable by searching for fields, which may have been a conceptual desire for Sloth by I but wouldn't see much point to it myself. (Side note: I encourage all scripters to add explanatory comments to their scripts for any aspect that may not be clear to later readers.)
If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0

User avatar
alleryn
Space Kraken
Posts: 112
Joined: Sun Nov 19, 2017 6:32 pm

Re: [Nov. 20 test build (e6848d8)] Accretion disc inconsiste

#7 Post by alleryn » Sat Nov 25, 2017 2:59 am

Dilvish wrote: I think I would be far happier with a slightly different approach, which instead had the special, when at the system level, only create the field (if really necessary) and apply planetary-level copies of itself to any planet within the system that didn't already have the planetary level special, and then at the planet level have it create the supply malus
This approach has my vote.

User avatar
Vezzra
Release Manager, Design
Posts: 4609
Joined: Wed Nov 16, 2011 12:56 pm
Location: Sol III

Re: [Nov. 20 test build (e6848d8)] Accretion disc inconsiste

#8 Post by Vezzra » Sun Nov 26, 2017 10:24 am

Another approach could be to display an icon for system-wide specials, like we have for planetary specials. That icon could be shown on the bar with the system summaries.

dbenage-cx
Programmer
Posts: 389
Joined: Sun Feb 14, 2016 12:08 am

Re: [Nov. 20 test build (e6848d8)] Accretion disc inconsiste

#9 Post by dbenage-cx » Sun Nov 26, 2017 5:04 pm

Vezzra wrote:Another approach could be to display an icon for system-wide specials, like we have for planetary specials. That icon could be shown on the bar with the system summaries.
Even if changed to add specials to each planet, would still like a way to display specials on objects other than planets.

User avatar
Vezzra
Release Manager, Design
Posts: 4609
Joined: Wed Nov 16, 2011 12:56 pm
Location: Sol III

Re: [Nov. 20 test build (e6848d8)] Accretion disc inconsiste

#10 Post by Vezzra » Sun Nov 26, 2017 5:47 pm

dbenage-cx wrote:Even if changed to add specials to each planet, would still like a way to display specials on objects other than planets.
Seconded.

Post Reply