build error git

Questions, problems and discussion about compiling FreeOrion.
Post Reply
Message
Author
pheldens
Pupating Mass
Posts: 96
Joined: Fri Mar 15, 2013 12:54 pm

build error git

#1 Post by pheldens » Fri Mar 17, 2017 2:18 pm

commit 10ad56917beb852ee604d722d7e8ea88366bbc4b

In file included from /home/user/games/freeorion/parse/BuildingsParser.cpp:10:0:
/home/user/games/freeorion/parse/../universe/Enums.h:12:5: error: ‘INVALID_UNIVERSE_OBJECT_TYPE’ has not been declared

User avatar
Geoff the Medio
Programming, Design, Admin
Posts: 12279
Joined: Wed Oct 08, 2003 1:33 am
Location: Munich

Re: build error git

#2 Post by Geoff the Medio » Fri Mar 17, 2017 2:20 pm

What compiler? If an MSVC older than 2015, get a newer version.

pheldens
Pupating Mass
Posts: 96
Joined: Fri Mar 15, 2013 12:54 pm

Re: build error git

#3 Post by pheldens » Fri Mar 17, 2017 2:27 pm

gcc (GCC) 5.3.0

User avatar
Vezzra
Release Manager, Design
Posts: 4674
Joined: Wed Nov 16, 2011 12:56 pm
Location: Sol III

Re: build error git

#4 Post by Vezzra » Fri Mar 17, 2017 2:40 pm

@pheldens, are you familiar with git bisect? Can you try to narrow down which commit exactly introduced the issue?

User avatar
adrian_broher
Programmer
Posts: 1072
Joined: Fri Mar 01, 2013 9:52 am
Location: Germany

Re: build error git

#5 Post by adrian_broher » Fri Mar 17, 2017 3:21 pm

Not reproducible locally or on any CI system.

https://github.com/freeorion/freeorion/commits/master
Resident code gremlin
Attached patches are released under GPL 2.0 or later.
Git author: Marcel Metz

pheldens
Pupating Mass
Posts: 96
Joined: Fri Mar 15, 2013 12:54 pm

Re: build error git

#6 Post by pheldens » Fri Mar 17, 2017 8:47 pm

bisected to:

0a6f858ad8d10069e3f1d7ef3be9c890bccb80b8 is the first bad commit
commit 0a6f858ad8d10069e3f1d7ef3be9c890bccb80b8
Author: Marcel Metz <mmetz@adrian-broher.net>
Date: Fri Mar 3 23:39:31 2017 +0100

Use CMake target_include_directories for all targets

:100644 100644 d4396dedb3e85467a3c468a0c05db165cc5be151 0abbf106111e6679095d99b51e89a9aaab52e28c M CMakeLists.txt
:040000 040000 36982356630f99b574764be431fc91135841a5e5 0540ecf8d1f8ce1faadc896f9bca375ae70383d5 M client
:040000 040000 3e39fe9bca7e1eb8a275232912e0ecca575247a2 161b39fb9651a944408d34982447a0e95c53d89d M parse
:040000 040000 a300c8f5a2bd588a61835f8dbb5a0326eada33fd 751a8423fc6b069d6e090dba5ac02e839c3f63dc M server

User avatar
Geoff the Medio
Programming, Design, Admin
Posts: 12279
Joined: Wed Oct 08, 2003 1:33 am
Location: Munich

Re: build error git

#7 Post by Geoff the Medio » Fri Mar 17, 2017 9:01 pm

Perhaps you need to re-run cmake before building?

pheldens
Pupating Mass
Posts: 96
Joined: Fri Mar 15, 2013 12:54 pm

Re: build error git

#8 Post by pheldens » Fri Mar 17, 2017 9:36 pm

upgraded cmake from cmake-3.6.1 to cmake-3.7.2 , still get the error

it's a clean build outside of the source tree

pheldens
Pupating Mass
Posts: 96
Joined: Fri Mar 15, 2013 12:54 pm

Re: build error git

#9 Post by pheldens » Fri Mar 17, 2017 9:39 pm

/usr/local/include/boost/signal.hpp:17:4: warning: #warning "Boost.Signals is no longer being maintained and is now deprecated. Please switch to Boost.Signals2. To disable this warning message, define BOOST_SIGNALS_NO_DEPRECATION_WARNING." [-Wcpp]
# warning "Boost.Signals is no longer being maintained and is now depr
^
In file included from /home/user/games/freeorion/combat/CombatEvents.cpp:8:0:
/home/user/games/freeorion/combat/../universe/Enums.h:12:5: error: ‘INVALID_UNIVERSE_OBJECT_TYPE’ has not been declared



boost_1_60_0

User avatar
adrian_broher
Programmer
Posts: 1072
Joined: Fri Mar 01, 2013 9:52 am
Location: Germany

Re: build error git

#10 Post by adrian_broher » Fri Mar 17, 2017 10:01 pm

pheldens wrote: /usr/local/include/boost/signal.hpp:17:4: warning: #warning "Boost.Signals is no longer being maintained and is now deprecated. Please switch to Boost.Signals2. To disable this warning message, define BOOST_SIGNALS_NO_DEPRECATION_WARNING." [-Wcpp]
# warning "Boost.Signals is no longer being maintained and is now depr
No idea what are you doing there, but we replaced boost::signals with boost::signals2 more than 3 years ago.

https://github.com/freeorion/freeorion/ ... 5ef5a153d3

also
pheldens wrote: /usr/local/
I just assume you butchered your build environment beyond recognition.
Resident code gremlin
Attached patches are released under GPL 2.0 or later.
Git author: Marcel Metz

pheldens
Pupating Mass
Posts: 96
Joined: Fri Mar 15, 2013 12:54 pm

Re: build error git

#11 Post by pheldens » Fri Mar 17, 2017 10:16 pm

ok I'll look into it, may be a stale file, though my install logger says it's part of 1.60

/usr/local is my correct prefix

/usr/local/include/boost/signal.hpp
/usr/local/include/boost/signals2/signal.hpp

signals 2 is in its own subdir, your includes and cmake procedure should take this into account

pheldens
Pupating Mass
Posts: 96
Joined: Fri Mar 15, 2013 12:54 pm

Re: build error git

#12 Post by pheldens » Fri Mar 17, 2017 10:44 pm

I Think I found it, it were old GiGi includes from 2013 when this was a seperate project (iirc) up until march3 these were never picked up

Post Reply