Geoff the Medio wrote: ↑Sat Apr 27, 2019 10:35 am
Ignored?
The first of those pull requests, made by you, is still marked work in progress. If it is / was done, or is ready for more testing, then please rebase and indicate this so I / we can do so, or just merge it yourself.
Yes ignored. The feature already worked two years ago as intended and could already have been merged March 2017, except it broke the MSVS solutions. Now, after some thousand commits behind, its rotten and needs to be fixed.
Geoff the Medio wrote: ↑Sat Apr 27, 2019 10:35 am
The second pull request was repeatedly tested and given feedback, until you wrote that it broke more than it fixed. If you now think it is worth merging, please write that or do so. I defer to your judgement for pull requests such as this.
I still consider it the inferior solution as it doesn't allow the build of shared libraries and only
somehow fixes the windows build by copying the behaviour of the VS solution. It doesn't fix the inherit flaws of it.
Geoff the Medio wrote: ↑Sat Apr 27, 2019 10:35 am
I prefer to use the manually maintained VS solution files because I find the extra step of using CMake unnecessary and annoying, but I have no objection to making CMake work as well and will gladly merge or have you merge whatever changes to those scripts you think are good enough and that don't completely break the ability to use an MSVS solution file in parallel.
Repeating again and again:
The VS Solution
- dictates the layout of the source code and the SDK structure, making changes an unnecessary PITA
- enforces the availability of python as a build dependency for no good reason
- duplicates the work required for build documentation
- doesn't provide any of the flexibility to allow multiple build trees or different build configurations
- forces the user to manually manage the SDK
- doesn't provide any build environment capability checking
- doesn't provide the capabilities to build release artifacts, which are a prequisite to do serious automated CI (fully automated weeklies/nightlies)
Counter argument so far:
Seriously? The VS solution files are a hindrance for every advanced feature that could be provided by the build system and you are still in favour of that crutch.
Also:
Geoff the Medio wrote: ↑Sat Apr 27, 2019 10:35 am
[…] I / we can do so, or just merge it yourself.
[…] I defer to your judgement for pull requests such as this.
While I'm still a member of the freeorion group on GitHub, I don't have any more permissions on the repositories than a guest.