Scrap ship cancel command doesn't seem to work

Problems and solutions for installing or running FreeOrion, including discussion of bugs if needed before posting a bug report on GitHub. For problems building from source, post in Compile.

Moderators: Oberlus, Oberlus

Post Reply
Message
Author
unjashfan
Creative Contributor
Posts: 175
Joined: Fri Dec 30, 2011 8:08 am

Scrap ship cancel command doesn't seem to work

#1 Post by unjashfan » Wed Apr 10, 2013 12:58 pm

When I scrap ships by right clicking the fleet, but then change my mind and select cancel scrapping ships, the ships end up getting scrapped anyway.

User avatar
Bigjoe5
Designer and Programmer
Posts: 2058
Joined: Tue Aug 14, 2007 6:33 pm
Location: Orion

Re: Scrap ship cancel command doesn't seem to work

#2 Post by Bigjoe5 » Wed Apr 10, 2013 7:22 pm

I can't reproduce this. Can you provide more information?
Warning: Antarans in dimensional portal are closer than they appear.

User avatar
Dilvish
AI Lead and Programmer Emeritus
Posts: 4768
Joined: Sat Sep 22, 2012 6:25 pm

Re: Scrap ship cancel command doesn't seem to work

#3 Post by Dilvish » Thu Apr 11, 2013 4:30 am

It was the FleetRow right-click popup command not working right; I just comitted a fix
fixed fleet right-click popup command: "Cancel Scrapping Ships" so that it actually rescinds the scrap order (not just resetting the client-side flag with GetShip(ship_id)->SetOrderedScrapped(false) )
If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0

Post Reply