Dilvish wrote:Thanks for putting that together, Cj. I notice though that it doesn't preserve line number matching between the FR and EN entries-- 14035 total lines for the FR version vs. 14112 for EN, so at least some of the entries must be offset. Ouaz, that should be easy enough for you to go through and add commented blank lines to fr.txt to get the entries to match up, yes?
Yes, these 75 lines are the double blank lines not yet removed in EN.txt. No problem to deal with it in the FR file until the PR is accepted for EN.txt.
It sounds to me like we may as well go ahead and put this version into the main repo. Ouaz can then simply work with the main repo copy and submit a PR when he has new translations to add. It sounds like Ouaz will be happy enough to keep manually checking the commented-out entries to see if the en.txt version has changed, or if en.txt has new entries he can also copy them into fr.txt (commented out with a leading '#' until he actually translates them).
Yes, I will be happy.
However, there are some things I don't understand:
1) I thought that
each key will be commented. Currently, the commented keys are only those for which the value is not yet translated (or the french word is the same than in english, e.g. infrastructure = infrastructure):
- comment_untranslated.PNG (22.47 KiB) Viewed 6294 times
As you see, the Artificial Planet description is commented (both key and value, because the value is not yet translated), but the Subterranean Habitation keys aren't (because the value is already translated). Wouldn't be more logic to comment each key (for which their values are translated or not)? -although I keep them up-to-date regularly -
2) As I said, some french words are the same than in english (e.g. production = production). So, there is a bunch of "translated strings" that are commented:
- french_same_english.PNG (15.76 KiB) Viewed 6294 times
These three french words are the same than in english. So, can I "uncomment" them? (to mark that is actually translated)
3) For Cj's: sometimes, some strings are not commented, whereas it should be (not a problem though, I can manually fix it):
- missing_comment.PNG (17.25 KiB) Viewed 6294 times
As you see, Endomorphic IV and Fractal I are commented (both key and value, because I kept the same name in the french file), but Gravitator I isn't. Happens with some tech description stuff too.
Otherwise, everything is perfect. I can work easily and quickly as before, with this "commented" FR file.
Thanks to all of you, guys.
I release every updated file under the CC-BY-SA 3.0 license.