Page 7 of 7

Re: English stringtable

Posted: Fri Jul 29, 2016 11:09 am
by Geoff the Medio
Say something like "... further increases ..." instead of "... increases the size of increased ..."?

Re: English stringtable

Posted: Fri Jul 29, 2016 5:13 pm
by MatGB
One of the increases needs to be improves, or similar, yeah, good catch, as written it's both clunky and unclear, I don't mind clunky if it's the only way to be clear but but together is bad.

Re: English stringtable

Posted: Sat Jul 30, 2016 7:51 am
by adrian_broher
Improved centralized management of dispersed industrial activities further increases industrial output provided.
Yeah, I'm okay with that.

Re: English stringtable

Posted: Mon Aug 01, 2016 11:22 am
by adrian_broher
I'm brushing up the documentation of the english string table and have not even the remotest idea what the author of theNEW_ASTEROIDS_NAME comment is trying to say to me. So Geoff, speak up. What substitution values of the %1% and %2% placeholders? And why should I care about internals on how an asteroid belt is generated as a translator?

Re: English stringtable

Posted: Mon Aug 01, 2016 2:04 pm
by Geoff the Medio
adrian_broher wrote:I'm brushing up the documentation of the english string table and have not even the remotest idea what the author of theNEW_ASTEROIDS_NAME comment is trying to say to me. So Geoff, speak up. What substitution values of the %1% and %2% placeholders? And why should I care about internals on how an asteroid belt is generated as a translator?
I assume you're asking about:

Code: Select all

# new asteroids or new planet names...
# used to generate name for effect-created planets, when no name = (string) is specified.
# When specifying an object name for these effects, if the specified string matches a
# stringtable key, it will be looked up and used directly. Alternatively, the
# UserString("STRING_KEY") function can be used. In this case, the % operator can be used
# to specify substitutions using string gamestate references, such as Source.Name
# these are applied to the %1% style placeholders according the order in which the
# parameters are specified in the effect
NEW_ASTEROIDS_NAME
%1% %2% remnants
I don't know why this comment in the stringtable is telling you about syntax for effect scripting, and I don't know what the author of that comment did in scripts in general... But I think I've seen in relevant test games something like "Systemname II remnants[/quote], so I guess %1% would be the system name, and %2% would be a numeral for the planet number. Not sure though.

Re: English stringtable

Posted: Mon Aug 01, 2016 2:53 pm
by adrian_broher
Geoff the Medio wrote:I assume you're asking about:
Yes, that's the comment in question.
I don't know why this comment in the stringtable is telling you about syntax for effect scripting, and I don't know what the author of that comment did in scripts in general... But I think I've seen in relevant test games something like "Systemname II remnants, so I guess %1% would be the system name, and %2% would be a numeral for the planet number. Not sure though.
Well, I asked you because you added this comment in the first place (git blame says so) with the commits c2fcafa5, and a4d24919. No intermediate predecessor of the those commit for those lines was of any help either so I'm just asking here. The commit itself is complete irrelevant for translators and more helpful for people, who want wo use UserString inside the FOCS script.

Re: English stringtable

Posted: Mon Aug 01, 2016 3:25 pm
by MatGB
I can't find those commits my git client fu is failing but I'm fairly certain that comment was put in at the same time Geoff fixed the planet creation effects ages ago when Sloth and I were messing around making nebulas work properly and the planet naming just wasn't working right.

It's also in the process of being revised in some way by either Dbenage-CX or LGM-Doyle as part of the asteroid renaming thing but I can't find that PR either, I think I need more coffee.

We are a bit bad when it comes to documenting things in the right place, but I like having an explanation for a weird key with parameters with that key myself, especially given it can be used in multiple different effects.

Re: English stringtable

Posted: Mon Aug 01, 2016 8:16 pm
by Vezzra
MatGB wrote:I think I need more coffee.
That, or you need to take a nap (more healthy! ;)).

Re: English stringtable

Posted: Wed Aug 03, 2016 7:26 pm
by Ouaz
I plan to add the # StarTypes, # PlanetTypes, and # PlanetSizes keys in the stringtables (# PlanetEnvironments already done in a previous commit), but in the same time, to reorganize/rewrite each article that contains "Increases value on planets per population, by planet size/star type/planetary environment or habitability" description stuff, in order to be more easy/convenient to read.

But prior to that, I want to know if you think it's a good idea or not, and if it's yes, if the rewrite is clear enough (or if it could be better), and if the english syntax is OK^^.

Thanks.

Ex:
tomo.png
tomo.png (29.2 KiB) Viewed 1721 times
xeno.png
xeno.png (31.82 KiB) Viewed 1719 times

Re: English stringtable

Posted: Wed Aug 03, 2016 8:00 pm
by Vezzra
IMO definitely an improvement.

Re: English stringtable

Posted: Wed Aug 03, 2016 11:28 pm
by MatGB
Agreed.

I've been toying with the idea of a very clearly worded 'planet size' page and then using that in all those places where the bonus is based on planet size, I think "hostile planets get a bonus equal to twice planet size" is clearer than what we have but also having the summary would help.

From my end it's partially inspired by thinking of increasing the number of costs that are partially determined by size, I already did artificial planet, terraform and gaia, I'm thinking that Space Elevator might benefit from that as well.

But improved clarity in the way population growth and the various tech interactions definitely needs to be a documentation priority.

Re: English stringtable

Posted: Thu Aug 04, 2016 8:24 pm
by adrian_broher
I'm still updating the comments.

What is the functional difference between a 'bout' and a 'round' in combat events? Reading the code didn't gave me any insight.

Re: English stringtable

Posted: Thu Aug 04, 2016 8:55 pm
by LGM-Doyle
adrian_broher, the description in the code and the description in game are not consistent. Bouts in the code are the same as rounds in the game descriptions.

In the code/programmer perspective:
[*] round: 1 ship/planet fires all its weapons. There are as many rounds as there are attacking ships/planets.
[*] bout: all ships/planets fire all their weapons once. The number of bouts is fixed at 3.

In the game/player perspective:
[*] round: all ships/planets fire all their weapons once. There are 3 rounds.

Re: English stringtable

Posted: Thu Aug 04, 2016 11:14 pm
by MatGB
Aye, until now I'd not encountered 'bout' as a term, and wouldn't want to introduce it, if it's in en.txt it needs removing, consistency in terms—especially terms that confuse new players, is important.