Planet naming error

Describe your experience with the latest version of FreeOrion to help us improve it.
Forum rules
Always mention the exact version of FreeOrion you are testing.

When reporting an issue regarding the AI, if possible provide the relevant AI log file and a save game file that demonstrates the issue.
Post Reply
Message
Author
Starionx
Space Floater
Posts: 30
Joined: Mon Jul 04, 2016 9:33 am

Planet naming error

#1 Post by Starionx » Sat Aug 13, 2016 12:37 pm

I think something went wrong at Krull. :?
It doesn't appear to be affecting production, but I've only just noticed it, so not sure.
Attachments
Krull.jpg
Krull.jpg (745.91 KiB) Viewed 377 times

User avatar
Vezzra
Release Manager, Design
Posts: 4674
Joined: Wed Nov 16, 2011 12:56 pm
Location: Sol III

Re: Planet naming error

#2 Post by Vezzra » Sat Aug 13, 2016 9:39 pm

Hm, apparently that planet naming thing for systems that form from a nebula doesn't quite work as intended. All planets are named "Krull I". Can you open a github issue?

dbenage-cx
Programmer
Posts: 389
Joined: Sun Feb 14, 2016 12:08 am

Re: Planet naming error

#3 Post by dbenage-cx » Sat Aug 13, 2016 11:32 pm

Addressed with PR#761.

Vezzra: Would you prefer an issue be opened in tandem with PR's in the future?

User avatar
Vezzra
Release Manager, Design
Posts: 4674
Joined: Wed Nov 16, 2011 12:56 pm
Location: Sol III

Re: Planet naming error

#4 Post by Vezzra » Sun Aug 14, 2016 9:01 am

dbenage-cx wrote:Vezzra: Would you prefer an issue be opened in tandem with PR's in the future?
Once a PR is already up, no need to open an issue as well. The main purpose of the issue is to have that item on the one centralized todo list. That avoids having to keep track of things which have only been reported on the forum (which have this nasty tendency to get buried and forgotten anyway).

However, if that PR gets closed instead of merged (for whatever reason), then, unless a follow-up PR is opened immediately afterwards, opening an issue for the unresolved problem would be necessary.

User avatar
EricF
Space Dragon
Posts: 282
Joined: Fri Jul 29, 2016 10:12 am

Re: Planet naming error

#5 Post by EricF » Mon Aug 22, 2016 2:51 pm

playing FreeOrion_2016-08-16.6a394b5_Test_Win32_Setup.exe

I've seen this same issue.

User avatar
Nutster
Krill Swarm
Posts: 13
Joined: Fri Aug 30, 2013 3:41 pm
Location: Toronto, Ontario, Canada area

Re: Planet naming error

#6 Post by Nutster » Wed Aug 24, 2016 3:26 pm

A work-around for the players would be to right-click and rename each planet: Krull Inner Asteroids, Krull I (leave it as is), Krull Outer Asteroids, Krull II, Krull III, etc. That does not solve the original problem but is a quick enough fix while playing the game.

User avatar
Vezzra
Release Manager, Design
Posts: 4674
Joined: Wed Nov 16, 2011 12:56 pm
Location: Sol III

Re: Planet naming error

#7 Post by Vezzra » Wed Aug 24, 2016 6:25 pm

A fix for that issue is currently worked on, it just turned out to be a bit more comlicated than expected...

Post Reply