Eccentric orbit

Describe your experience with the latest version of FreeOrion to help us improve it.
Forum rules
Always mention the exact version of FreeOrion you are testing.

When reporting an issue regarding the AI, if possible provide the relevant AI log file and a save game file that demonstrates the issue.
Message
Author
Scara
Space Kraken
Posts: 140
Joined: Thu Apr 23, 2015 11:21 am

Eccentric orbit

#1 Post by Scara » Fri Apr 28, 2017 5:39 am

Hi,

it seems the eccentric orbit malus to supply is missing in 04-26.e5a0756.
I outposted a tiny planet (+2) with eccetric orbit (-2) and thought i needed orbital construction to get 1 point, but already without it I got 2 supply points.
Sun hulls now have only 4 interior slots, is that a change on purpose?
Greetings =)

User avatar
Dilvish
AI Lead, Programmer
Posts: 4712
Joined: Sat Sep 22, 2012 6:25 pm

Re: Eccentric orbit

#2 Post by Dilvish » Fri Apr 28, 2017 6:34 am

please show us a screenshot showing both the eccentric orbit special and the tooltip for the supply meter.
Sun hulls now have only 4 interior slots, is that a change on purpose?
Yes; at least, it's my recollection there was a change along those lines.
If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0

User avatar
MatGB
Creative Contributor
Posts: 3310
Joined: Fri Jun 28, 2013 11:45 pm

Re: Eccentric orbit

#3 Post by MatGB » Fri Apr 28, 2017 7:30 am

I'm on my Win laptop with a clean install of the same and the supply malus is in the script and it should be working.

Bear in mind a Tiny world gives you +2 supply and a species gives +1 or +2 normally: if you're playing Etty or George you'd still get 2 supply. But yeah, screenshot showing the tooltip as it's a weird bug if it's not working.

Re the Solar Hull, it was decided that it was way overpowered so as a temporary fix we removed a chunk of the slots: it's still the most powerful hull in the game though. I think the main problem is the engine parts so going to fix them and see if that solves the problem. We need more internal slot parts but having ships with speed 300+ is a little over the top, unless you've also got them pinning them down is almost impossible.
Mat Bowles

Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.

User avatar
Oberlus
Small Juggernaut
Posts: 703
Joined: Mon Apr 10, 2017 4:25 pm

Re: Eccentric orbit

#4 Post by Oberlus » Fri Apr 28, 2017 8:32 am

MatGB wrote:We need more internal slot parts
I certainly miss some powerful carrier designs. I'd love to get a 5 int. slot hull to put in 4x fighter hangar + 1 stealth (and 6 launchbays, so at least 6 ext. slots).

User avatar
MatGB
Creative Contributor
Posts: 3310
Joined: Fri Jun 28, 2013 11:45 pm

Re: Eccentric orbit

#5 Post by MatGB » Fri Apr 28, 2017 8:58 am

Yeah, I want to do some work on some of the hulls so a carrier is more viable but, well, it probably requries rethinking how that part of the tech tree works.

Nerfing the Solar was a concern in terms of introducing Fighters but it was non-Fighter designs that were the biggest problem, especially in multi-player vs multiple humans, the first to get them had such massive advantage it needed fixing.
Mat Bowles

Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.

User avatar
Oberlus
Small Juggernaut
Posts: 703
Joined: Mon Apr 10, 2017 4:25 pm

Re: Eccentric orbit

#6 Post by Oberlus » Fri Apr 28, 2017 10:21 am

Your idea of making engines (speed) ship parts non stackable seems to me the best way to tackle that. Currently there are +10 and +20 for int. slots and +30 and +40 (+40 stealth) for core slots. I'd add a new +30 ship part for int. slots (and another tech for that), change the +30 core part to give +40, and add another new, very expensive core part to give +50 or +60 (and another tech for it).

User avatar
MatGB
Creative Contributor
Posts: 3310
Joined: Fri Jun 28, 2013 11:45 pm

Re: Eccentric orbit

#7 Post by MatGB » Fri Apr 28, 2017 10:33 am

My current plan is to simply double all the existing parts, I'd like to simplify ship speeds so they're always a multiple of 20 but that's a lower priority. If they're all doubled then the max speed is 200, and I'm fine with that. 20, 40, 60, 80 are nice simple stat bonuses.

But everything is subject to testing.
Mat Bowles

Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.

User avatar
Oberlus
Small Juggernaut
Posts: 703
Joined: Mon Apr 10, 2017 4:25 pm

Re: Eccentric orbit

#8 Post by Oberlus » Fri Apr 28, 2017 11:25 am

Yeah, I like your way.

Scara
Space Kraken
Posts: 140
Joined: Thu Apr 23, 2015 11:21 am

Re: Eccentric orbit

#9 Post by Scara » Sat Apr 29, 2017 6:28 pm

Hi,

sorry, long time not in. Here is a screenshot I made of the situation. Planet was outposted, no species bonus, only +2 tiny planet. I don't think I have a savegame...
ecce.jpg
ecce.jpg (38.47 KiB) Viewed 608 times

Morlic
AI Contributor
Posts: 248
Joined: Tue Feb 17, 2015 11:54 am

Re: Eccentric orbit

#10 Post by Morlic » Sat Apr 29, 2017 6:36 pm

The special is scripted to only affect populated planets:

Code: Select all

    effectsgroups =
        EffectsGroup
            scope = Source
            activation = NOT Population high = 0
            priority = [[LATE_PRIORITY]]
            effects = [
                SetTargetResearch value = Value + 3
                SetMaxSupply value = Value -2
            ]
If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0

User avatar
Dilvish
AI Lead, Programmer
Posts: 4712
Joined: Sat Sep 22, 2012 6:25 pm

Re: Eccentric orbit

#11 Post by Dilvish » Sat Apr 29, 2017 7:49 pm

Morlic wrote:The special is scripted to only affect populated planets:
Excellent catch, Morlic! If we don't wind up changing this aspect then I think we should be sure to fix the Pedia description so that rather than just saying it decreases Supply, that it decreases Supply if the planet is populated.

And also in that case, then we should adjust AI handling of this in ColonisationAI.evaluate_planet() so that this particular supply mod only applies to colonisation missions and not to outposting missions. It looks to me like we don't necessarily need an adjustment to the supply_val calculation, but I think its been a while since we've done anything with that and it might be worthwhile reviewing/tweaking that sometime. I'll bookmark this to my todo list to hopefully get around to it sometime, assuming we don't decide to change the special.

As for changing the special or not -- the current setup does seem to me to have the major drawback that if you have already outposted the planet and get a suitability report on it, it's my recollection that the suitability report is not going to reflect changes in supply-connected-growth-specials that would result from the planet being colonized, so folks could easily be caught by an unexpected die-off after colonization. Perhaps we should consider having the penalty be only -1 rather than -2 so that most species could not have any risk of that die-off.
If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0

Scara
Space Kraken
Posts: 140
Joined: Thu Apr 23, 2015 11:21 am

Re: Eccentric orbit

#12 Post by Scara » Sat Apr 29, 2017 8:11 pm

Hmm, I guessed it might be that, but thought rather then changing the description, changing the special to work on outposted planets aswell.
I would be logical, because the eccentric orbit should change the supply, whether or not its colonized, what the scientists make of it is a other thing...

User avatar
Vezzra
Release Manager, Design
Posts: 4664
Joined: Wed Nov 16, 2011 12:56 pm
Location: Sol III

Re: Eccentric orbit

#13 Post by Vezzra » Sat Apr 29, 2017 8:40 pm

Scara wrote:Hmm, I guessed it might be that, but thought rather then changing the description, changing the special to work on outposted planets aswell.
I would be logical, because the eccentric orbit should change the supply, whether or not its colonized, what the scientists make of it is a other thing...
This.

I consider the special only working for populated planets a bug, so the fix should be to remove that restriction. Unless there was a specific reason why that restriction had been added...?

dbenage-cx
Programmer
Posts: 389
Joined: Sun Feb 14, 2016 12:08 am

Re: Eccentric orbit

#14 Post by dbenage-cx » Sat Apr 29, 2017 9:17 pm

Changed in PR #1090.
Guessing that change was only concerned with the effect on research?

User avatar
Vezzra
Release Manager, Design
Posts: 4664
Joined: Wed Nov 16, 2011 12:56 pm
Location: Sol III

Re: Eccentric orbit

#15 Post by Vezzra » Sat Apr 29, 2017 9:26 pm

dbenage-cx wrote:Changed in PR #1090.
Guessing that change was only concerned with the effect on research?
Most likely. That would make sense at least. So the research bonus and the supply malus need to be separated into two effectsgroups I guess.

Post Reply