trouble running multiplayer moderator or observer

Describe your experience with the latest version of FreeOrion to help us improve it.
Forum rules
Always mention the exact version of FreeOrion you are testing.

When reporting an issue regarding the AI, if possible provide the relevant AI log file and a save game file that demonstrates the issue.
Post Reply
Message
Author
User avatar
Dilvish
AI Lead, Programmer
Posts: 4753
Joined: Sat Sep 22, 2012 6:25 pm

trouble running multiplayer moderator or observer

#1 Post by Dilvish » Wed Jun 14, 2017 12:05 am

It seems I am now unable to run a multiplayer game with myself set as either moderator or as observer (plus 1 or 2 AIs)-- the game just sits there with the multiplayer setup screen still showing, and does nothing. I am not seeing anything helpful in the logs (just some seemingly fairly typical lines about invalid TurnProgress event for current state of FSM). I tried a number of different commits, going back about a month in the code, to commit 622177367912b9dd982119511d0110815fd8126c, but still the same problem. Starting a single player game or a multiplayer game with me as a regular player works fine.

Before putting more time into looking into this or opening an issue I wanted to see if anyone else has the same trouble.
If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0

User avatar
Geoff the Medio
Programming, Design, Admin
Posts: 12297
Joined: Wed Oct 08, 2003 1:33 am
Location: Munich

Re: trouble running multiplayer moderator or observer

#2 Post by Geoff the Medio » Wed Jun 14, 2017 6:21 am

Looks like part of the code in NewGameInitVerifyJoiners

https://github.com/freeorion/freeorion/ ... p.cpp#L732

assumes no non-empire-controlling player types, or at least that the host controls an empire?

Code: Select all

08:17:53.924919 [error] server : ServerApp.cpp:754 : ServerApp::NewSPGameInit skipping unsupported client type in player setup data
08:18:40.770645 [error] server : ServerApp.cpp:766 : NewGameInitVerifyJoiners : Host id 1 is not a valid player id.
Maybe related to https://github.com/freeorion/freeorion/ ... daa98660d1

Edit: https://github.com/freeorion/freeorion/ ... d7a3d681f2 hopefully resolves it, at least temporarily. A more careful reconsideration of the relevant checks might be good.

LGM-Doyle
Programmer
Posts: 219
Joined: Mon Feb 29, 2016 8:37 pm

Re: trouble running multiplayer moderator or observer

#3 Post by LGM-Doyle » Wed Jun 14, 2017 9:03 pm

That is my bug.

I never tested the case of a non-empire controlling host.

Thanks for fixing it.

Post Reply