Minor sitrep bug

Describe your experience with the latest version of FreeOrion to help us improve it.

Moderator: Oberlus

Forum rules
Always mention the exact version of FreeOrion you are testing.

When reporting an issue regarding the AI, if possible provide the relevant AI log file and a save game file that demonstrates the issue.
Post Reply
Message
Author
wobbly
Cosmic Dragon
Posts: 1880
Joined: Thu Oct 10, 2013 6:48 pm

Minor sitrep bug

#1 Post by wobbly »

v0.4.10.1[build 2020-09-25.39cfe10]

If you have damaged ships sitting in a system on the turn the drydock is finished, they do repair that turn, but you don't get the repaired sitrep

defaultuser
Juggernaut
Posts: 854
Joined: Wed Aug 26, 2015 6:15 pm

Re: Minor sitrep bug

#2 Post by defaultuser »

wobbly wrote: Thu Nov 19, 2020 12:41 pm v0.4.10.1[build 2020-09-25.39cfe10]

If you have damaged ships sitting in a system on the turn the drydock is finished, they do repair that turn, but you don't get the repaired sitrep
It's been that way for a while. I mentioned it here:

viewtopic.php?f=28&t=10294

Speaking of old threads, what ever happened to Mat?

User avatar
The Silent One
Graphics
Posts: 1129
Joined: Tue Jul 01, 2003 8:27 pm

Re: Minor sitrep bug

#3 Post by The Silent One »

defaultuser wrote: Fri Nov 20, 2020 3:08 am Speaking of old threads, what ever happened to Mat?
He appeared once on Github maybe half a year ago, but hasn't been around again since AFAIK.
If I provided any images, code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0.

Ophiuchus
Programmer
Posts: 3433
Joined: Tue Sep 30, 2014 10:01 am
Location: Wall IV

Re: Minor sitrep bug

#4 Post by Ophiuchus »

defaultuser wrote: Fri Nov 20, 2020 3:08 am
wobbly wrote: Thu Nov 19, 2020 12:41 pm v0.4.10.1[build 2020-09-25.39cfe10]

If you have damaged ships sitting in a system on the turn the drydock is finished, they do repair that turn, but you don't get the repaired sitrep
It's been that way for a while. I mentioned it here:

viewtopic.php?f=28&t=10294
Its not possible to do the sitrep message in the same turn you build things. Sitreps are handled before object creation happens. There is another effect pass afterwards.

This kind of effect got fixed for technologies, but not for buildings and ships.

The workaround is to delay the drydock effect in the activation condition. The backend fix is to handle initialisation of newly build ships/buildings differently (probably by an explicit 'initialisationEffects' property in FOCS).
Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.

Look, ma... four combat bouts!

Post Reply