New tags for github issues and pull requests

Discussion about the project in general, organization, website, or any other details that aren't directly about the game.
Post Reply
Message
Author
User avatar
Vezzra
Release Manager, Design
Posts: 4605
Joined: Wed Nov 16, 2011 12:56 pm
Location: Sol III

New tags for github issues and pull requests

#1 Post by Vezzra » Fri Apr 01, 2016 1:39 pm

I've created a couple of new tags on github for issues and pull requests: "idea", "request", "testing requested", "work in progress". All these should be more or less self-explaining, maybe with the exception of "request": don't know if we are really going to need that, but I put it in for requests that aren't either feature requests or requests for testing.

Two additional labels I created some time ago: "documentation" (pls use for issues/PRs concerning any kind of docs, be it technical like docs for the Python interface, FOCS, or game documentation like the quickstart guide, etc.), "scripting" (pls use for all issues/PRs concerning FOCS and Python scripts).

Objections, corrections, suggestions, comments?

dbenage-cx
Programmer
Posts: 389
Joined: Sun Feb 14, 2016 12:08 am

Re: New tags for github issues and pull requests

#2 Post by dbenage-cx » Fri Apr 01, 2016 2:07 pm

Based on the comments, not sure if https://github.com/freeorion/freeorion/pull/576 is in a state ready to be tested yet.

Maybe split scripting into FOCS and AI?
Any content posted should be considered licensed GNU GPL 2.0 and/or CC-BY-SA 3.0 as appropriate.

User avatar
Vezzra
Release Manager, Design
Posts: 4605
Joined: Wed Nov 16, 2011 12:56 pm
Location: Sol III

Re: New tags for github issues and pull requests

#3 Post by Vezzra » Fri Apr 01, 2016 2:20 pm

dbenage-cx wrote:Based on the comments, not sure if https://github.com/freeorion/freeorion/pull/576 is in a state ready to be tested yet.
Well, I inferred that from the "[Testing required]" remark in the PR title. But if you want, I can remove that tag.
Maybe split scripting into FOCS and AI?
Hm, I'm a bit torn. On the one hand I've been considering a split between FOCS and Python myself (which also makes much sense), on the other hand I don't want to create too many tags, otherwise the tag list gets cluttered/confusing. But an "AI" tag probably makes sense, you can then combine that with "scritping" if you want to specifically refer to Python AI scripts?

What do the others think?

User avatar
MatGB
Creative Contributor
Posts: 3310
Joined: Fri Jun 28, 2013 11:45 pm

Re: New tags for github issues and pull requests

#4 Post by MatGB » Fri Apr 01, 2016 5:16 pm

#576 specifically is testable,b ut at a very early stage, it's going to need some serious work to balance it, plus the whole of the fighter setup needs bughunting, etc. I've got some work done on a first pass at balancing the individual parts (and it was nice to see the AI adapt designs based on me changing costs and strengths of some things), etc.

I think it's a prime example of a good 'testing required' tag as it can't be merged in until it's been heavily tested.

On other issues, I'd like to see a separation of FOCs stuff and AI stuff, for a number of reasons but partially because FOCs stuff can be given to a brand new contributor who may not really know how to code at all, whereas AI stuff is advanced need to know how it works and work with the team stuff.

I can't really contribute to AI stuff, but am heavily involved in FOCS stuff which is where our new scripters want tob e pointed at, so I'd like to see a split (we have a 'scripting' folder as well as an AI folder within default now so it makes sense).
Mat Bowles

Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.

Post Reply