Potential GiGi replacements: Godot

Programmers discuss here anything related to FreeOrion programming. Primarily for the developers to discuss.

Moderator: Committer

Message
Author
o01eg
Programmer
Posts: 1189
Joined: Sat Dec 10, 2011 5:46 am

Re: Potential GiGi replacements: Godot

#91 Post by o01eg »

Change GIT_TAG of godot-cpp external project back to cb837cb97ba09834c1a6ad813f82f2756d63d010 or update build-godot-windows-cmake branch.
Gentoo Linux x64, gcc-10.2, boost-1.75.0
Ubuntu Server 20.04 x64, gcc-9.3, boost-1.71.0
Welcome to the slow multiplayer game at freeorion-lt.dedyn.io.Version 2021-05-10.4f04bdc.
Donations are welcome: BTC:14XLekD9ifwqLtZX4iteepvbLQNYVG87zK

User avatar
Geoff the Medio
Programming, Design, Admin
Posts: 12975
Joined: Wed Oct 08, 2003 1:33 am
Location: Munich

Re: Potential GiGi replacements: Godot

#92 Post by Geoff the Medio »

o01eg wrote: Sun Apr 18, 2021 9:33 am Should we use some format and lint tools for Godot? https://www.gdquest.com/tutorial/godot/ ... formatter/
No idea, but if you think it would be useful...

User avatar
Geoff the Medio
Programming, Design, Admin
Posts: 12975
Joined: Wed Oct 08, 2003 1:33 am
Location: Munich

Re: Potential GiGi replacements: Godot

#93 Post by Geoff the Medio »

Building build-godot-windows-cmake 66dd4b23ea9727e2ca39a3a0cea2cd1b1a2600a7 which has message "Use working commt from repo", I get

Code: Select all

  -- Link from dest C:/Users/g_top/Desktop/FOSDK11_Godot/FreeOrionG/build/Release target test-scripting to source C:/Users/g_top/Desktop/FOSDK11_Godot/FreeOrionG/test-scripting
  -- Executing mklink /J C:\Users\g_top\Desktop\FOSDK11_Godot\FreeOrionG\build\Release\test-scripting C:\Users\g_top\Desktop\FOSDK11_Godot\FreeOrionG\test-scripting at C:/Users/g_top/Desktop/FOSDK11_Godot/FreeOrionG/build/Release
  -- Mklink result The system cannot find the file specified output  error 
  -- Link from dest C:/Users/g_top/Desktop/FOSDK11_Godot/FreeOrionG/build/Release target default to source C:/Users/g_top/Desktop/FOSDK11_Godot/FreeOrionG/default
  -- Executing mklink /J C:\Users\g_top\Desktop\FOSDK11_Godot\FreeOrionG\build\Release\default C:\Users\g_top\Desktop\FOSDK11_Godot\FreeOrionG\default at C:/Users/g_top/Desktop/FOSDK11_Godot/FreeOrionG/build/Release
  -- Mklink result The system cannot find the file specified output  error 
and a few other similar errors.

o01eg
Programmer
Posts: 1189
Joined: Sat Dec 10, 2011 5:46 am

Re: Potential GiGi replacements: Godot

#94 Post by o01eg »

Geoff the Medio wrote: Sun Apr 18, 2021 9:43 pm Building build-godot-windows-cmake 66dd4b23ea9727e2ca39a3a0cea2cd1b1a2600a7 which has message "Use working commt from repo", I get

Code: Select all

  -- Link from dest C:/Users/g_top/Desktop/FOSDK11_Godot/FreeOrionG/build/Release target test-scripting to source C:/Users/g_top/Desktop/FOSDK11_Godot/FreeOrionG/test-scripting
  -- Executing mklink /J C:\Users\g_top\Desktop\FOSDK11_Godot\FreeOrionG\build\Release\test-scripting C:\Users\g_top\Desktop\FOSDK11_Godot\FreeOrionG\test-scripting at C:/Users/g_top/Desktop/FOSDK11_Godot/FreeOrionG/build/Release
  -- Mklink result The system cannot find the file specified output  error 
  -- Link from dest C:/Users/g_top/Desktop/FOSDK11_Godot/FreeOrionG/build/Release target default to source C:/Users/g_top/Desktop/FOSDK11_Godot/FreeOrionG/default
  -- Executing mklink /J C:\Users\g_top\Desktop\FOSDK11_Godot\FreeOrionG\build\Release\default C:\Users\g_top\Desktop\FOSDK11_Godot\FreeOrionG\default at C:/Users/g_top/Desktop/FOSDK11_Godot/FreeOrionG/build/Release
  -- Mklink result The system cannot find the file specified output  error 
and a few other similar errors.
Could you try again at commit 83056ca361bd9491d7eb067d392c411e8842779d?

Edit: CI shows https://github.com/o01eg/freeorion/runs ... focus=true

Code: Select all

2021-04-19T07:13:54.2291088Z     Directory: D:\a\freeorion\freeorion\build\Release
2021-04-19T07:13:54.2291685Z 
2021-04-19T07:13:54.2292493Z Mode                 LastWriteTime         Length Name
2021-04-19T07:13:54.2293133Z ----                 -------------         ------ ----
2021-04-19T07:13:54.2293870Z l----           4/19/2021  7:08 AM                default -> D:\a\freeorion\freeorion\default
2021-04-19T07:13:54.2297646Z l----           4/19/2021  7:08 AM                test-scripting -> D:\a\freeorion\freeorion\test-scripting
2021-04-19T07:13:54.2352236Z -a---           4/19/2021  7:07 AM          50688 boost_date_time.dll
2021-04-19T07:13:54.2355036Z -a---           4/19/2021  7:07 AM         108032 boost_filesystem.dll
2021-04-19T07:13:54.2357596Z -a---           4/19/2021  7:09 AM          76288 boost_iostreams.dll
2021-04-19T07:13:54.2359930Z -a---           4/19/2021  7:07 AM         436224 boost_locale.dll
Gentoo Linux x64, gcc-10.2, boost-1.75.0
Ubuntu Server 20.04 x64, gcc-9.3, boost-1.71.0
Welcome to the slow multiplayer game at freeorion-lt.dedyn.io.Version 2021-05-10.4f04bdc.
Donations are welcome: BTC:14XLekD9ifwqLtZX4iteepvbLQNYVG87zK

o01eg
Programmer
Posts: 1189
Joined: Sat Dec 10, 2011 5:46 am

Re: Potential GiGi replacements: Godot

#95 Post by o01eg »

Also back to Godot project. What about to place Godot project to top-level directory godot/ instead of godot/client/ same way it done with snap or msvc projects, and GDNative C++ code to client/godot/ instead of godot/ like other clients?
Gentoo Linux x64, gcc-10.2, boost-1.75.0
Ubuntu Server 20.04 x64, gcc-9.3, boost-1.71.0
Welcome to the slow multiplayer game at freeorion-lt.dedyn.io.Version 2021-05-10.4f04bdc.
Donations are welcome: BTC:14XLekD9ifwqLtZX4iteepvbLQNYVG87zK

User avatar
Geoff the Medio
Programming, Design, Admin
Posts: 12975
Joined: Wed Oct 08, 2003 1:33 am
Location: Munich

Re: Potential GiGi replacements: Godot

#96 Post by Geoff the Medio »

o01eg wrote: Mon Apr 19, 2021 6:28 amCould you try again at commit 83056ca361bd9491d7eb067d392c411e8842779d?

Code: Select all

  -- Link from dest C:/Users/g_top/Desktop/FOSDK11_Godot/FreeOrionG/build/Release target test-scripting to source C:/Users/g_top/Desktop/FOSDK11_Godot/FreeOrionG/test-scripting
  -- Executing cmd /C mklink /J test-scripting C:\Users\g_top\Desktop\FOSDK11_Godot\FreeOrionG\test-scripting at C:\Users\g_top\Desktop\FOSDK11_Godot\FreeOrionG\build\Release
  -- Mklink result 0 output Junction created for test-scripting <<===>> C:\Users\g_top\Desktop\FOSDK11_Godot\FreeOrionG\test-scripting
   error 
  -- Link from dest C:/Users/g_top/Desktop/FOSDK11_Godot/FreeOrionG/build/Release target default to source C:/Users/g_top/Desktop/FOSDK11_Godot/FreeOrionG/default
  -- Executing cmd /C mklink /J default C:\Users\g_top\Desktop\FOSDK11_Godot\FreeOrionG\default at C:\Users\g_top\Desktop\FOSDK11_Godot\FreeOrionG\build\Release
  -- Mklink result 0 output Junction created for default <<===>> C:\Users\g_top\Desktop\FOSDK11_Godot\FreeOrionG\default
   error 

o01eg
Programmer
Posts: 1189
Joined: Sat Dec 10, 2011 5:46 am

Re: Potential GiGi replacements: Godot

#97 Post by o01eg »

Geoff the Medio wrote: Tue Apr 20, 2021 9:00 pm
o01eg wrote: Mon Apr 19, 2021 6:28 amCould you try again at commit 83056ca361bd9491d7eb067d392c411e8842779d?

Code: Select all

  -- Link from dest C:/Users/g_top/Desktop/FOSDK11_Godot/FreeOrionG/build/Release target test-scripting to source C:/Users/g_top/Desktop/FOSDK11_Godot/FreeOrionG/test-scripting
  -- Executing cmd /C mklink /J test-scripting C:\Users\g_top\Desktop\FOSDK11_Godot\FreeOrionG\test-scripting at C:\Users\g_top\Desktop\FOSDK11_Godot\FreeOrionG\build\Release
  -- Mklink result 0 output Junction created for test-scripting <<===>> C:\Users\g_top\Desktop\FOSDK11_Godot\FreeOrionG\test-scripting
   error 
  -- Link from dest C:/Users/g_top/Desktop/FOSDK11_Godot/FreeOrionG/build/Release target default to source C:/Users/g_top/Desktop/FOSDK11_Godot/FreeOrionG/default
  -- Executing cmd /C mklink /J default C:\Users\g_top\Desktop\FOSDK11_Godot\FreeOrionG\default at C:\Users\g_top\Desktop\FOSDK11_Godot\FreeOrionG\build\Release
  -- Mklink result 0 output Junction created for default <<===>> C:\Users\g_top\Desktop\FOSDK11_Godot\FreeOrionG\default
   error 
I suppose it doesn't help much until we update to boot 1.74. Maybe set project directory as installation directory and call cmake --build . --target install to "install" required files here? Or install them somewhere else as default is installing too.
Gentoo Linux x64, gcc-10.2, boost-1.75.0
Ubuntu Server 20.04 x64, gcc-9.3, boost-1.71.0
Welcome to the slow multiplayer game at freeorion-lt.dedyn.io.Version 2021-05-10.4f04bdc.
Donations are welcome: BTC:14XLekD9ifwqLtZX4iteepvbLQNYVG87zK

User avatar
Geoff the Medio
Programming, Design, Admin
Posts: 12975
Joined: Wed Oct 08, 2003 1:33 am
Location: Munich

Re: Potential GiGi replacements: Godot

#98 Post by Geoff the Medio »

o01eg wrote: Tue Apr 20, 2021 9:17 pm Maybe set project directory as installation directory and call cmake --build . --target install to "install" required files here? Or install them somewhere else as default is installing too.
I'd prefer to have the built executables put into the root FreeOrion repository directory, which also contains default, at least by default, like the existing MSVC project files do. (I assume there is a CMake option to specify another location if the builder prefers).

o01eg
Programmer
Posts: 1189
Joined: Sat Dec 10, 2011 5:46 am

Re: Potential GiGi replacements: Godot

#99 Post by o01eg »

Geoff the Medio wrote: Tue Apr 20, 2021 10:32 pm
o01eg wrote: Tue Apr 20, 2021 9:17 pm Maybe set project directory as installation directory and call cmake --build . --target install to "install" required files here? Or install them somewhere else as default is installing too.
I'd prefer to have the built executables put into the root FreeOrion repository directory, which also contains default, at least by default, like the existing MSVC project files do. (I assume there is a CMake option to specify another location if the builder prefers).
I suppose this should work.

Without creating separate build directory call cmake in project root:

Code: Select all

cmake -G "Visual Studio 16 2019" -T v141 -A Win32 -DBUILD_TESTING=On -DCMAKE_C_FLAGS=/MP -DCMAKE_CXX_FLAGS=/MP -DCMAKE_INSTALL_PREIFX=. .
And then

Code: Select all

cmake --build . --config "Release" -- /maxcpucount
cmake --build . --target install --config "Release" -- /maxcpucount
Gentoo Linux x64, gcc-10.2, boost-1.75.0
Ubuntu Server 20.04 x64, gcc-9.3, boost-1.71.0
Welcome to the slow multiplayer game at freeorion-lt.dedyn.io.Version 2021-05-10.4f04bdc.
Donations are welcome: BTC:14XLekD9ifwqLtZX4iteepvbLQNYVG87zK

o01eg
Programmer
Posts: 1189
Joined: Sat Dec 10, 2011 5:46 am

Re: Potential GiGi replacements: Godot

#100 Post by o01eg »

Alternatively use SDK from https://github.com/freeorion/freeorion-sdk/pull/83 with boost 1.74 where symlinks should be fixed
Gentoo Linux x64, gcc-10.2, boost-1.75.0
Ubuntu Server 20.04 x64, gcc-9.3, boost-1.71.0
Welcome to the slow multiplayer game at freeorion-lt.dedyn.io.Version 2021-05-10.4f04bdc.
Donations are welcome: BTC:14XLekD9ifwqLtZX4iteepvbLQNYVG87zK

User avatar
Vezzra
Release Manager, Design
Posts: 5522
Joined: Wed Nov 16, 2011 12:56 pm
Location: Sol III

Re: Potential GiGi replacements: Godot

#101 Post by Vezzra »

o01eg wrote: Tue Apr 20, 2021 5:35 pm Also back to Godot project. What about to place Godot project to top-level directory godot/ instead of godot/client/ same way it done with snap or msvc projects, and GDNative C++ code to client/godot/ instead of godot/ like other clients?
I don't have a strong opinion/preference regarding the layout of the source code tree, so as far as I am concerned, fine...

User avatar
Geoff the Medio
Programming, Design, Admin
Posts: 12975
Joined: Wed Oct 08, 2003 1:33 am
Location: Munich

Re: Potential GiGi replacements: Godot

#102 Post by Geoff the Medio »

o01eg wrote: Wed Apr 21, 2021 4:34 amI suppose this should work.

Without creating separate build directory call cmake in project root:

Code: Select all

cmake -G "Visual Studio 16 2019" -T v141 -A Win32 -DBUILD_TESTING=On -DCMAKE_C_FLAGS=/MP -DCMAKE_CXX_FLAGS=/MP -DCMAKE_INSTALL_PREIFX=. .
And then

Code: Select all

cmake --build . --config "Release" -- /maxcpucount
cmake --build . --target install --config "Release" -- /maxcpucount
That works up until the last command, which gives some errors:

Code: Select all

  -- Install configuration: "Release"
  CMake Error at cmake_install.cmake:36 (file):
    file cannot create directory: C:/Program Files (x86)/FreeOrion/..  Maybe
    need administrative privileges.
It's trying to install into Program Files, but it should be writing into . (when I'm running this from the root FreeOrion respository directory).

The executables built in FreeOrion/Release/ work with the symlink to default also in that directory.

o01eg
Programmer
Posts: 1189
Joined: Sat Dec 10, 2011 5:46 am

Re: Potential GiGi replacements: Godot

#103 Post by o01eg »

Yes, we should set -DCMAKE_INSTALL_PREFIX=. to install into working directory
Gentoo Linux x64, gcc-10.2, boost-1.75.0
Ubuntu Server 20.04 x64, gcc-9.3, boost-1.71.0
Welcome to the slow multiplayer game at freeorion-lt.dedyn.io.Version 2021-05-10.4f04bdc.
Donations are welcome: BTC:14XLekD9ifwqLtZX4iteepvbLQNYVG87zK

Post Reply